Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95AEDC5DF60 for ; Thu, 7 Nov 2019 11:58:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 643A5218AE for ; Thu, 7 Nov 2019 11:58:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 643A5218AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E7DFC6B0003; Thu, 7 Nov 2019 06:58:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E2E366B0006; Thu, 7 Nov 2019 06:58:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D44EE6B0007; Thu, 7 Nov 2019 06:58:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id BE7326B0003 for ; Thu, 7 Nov 2019 06:58:10 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id EE5008249980 for ; Thu, 7 Nov 2019 11:58:09 +0000 (UTC) X-FDA: 76129333098.25.jar04_8174388d3f962 X-HE-Tag: jar04_8174388d3f962 X-Filterd-Recvd-Size: 2959 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Nov 2019 11:58:09 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 0039BADBF; Thu, 7 Nov 2019 11:58:07 +0000 (UTC) Date: Thu, 7 Nov 2019 12:58:06 +0100 From: Michal Hocko To: Knut Omang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton Subject: Re: [PATCH] mm: provide interface for retrieving kmem_cache name Message-ID: <20191107115806.GP8314@dhcp22.suse.cz> References: <20191107115404.3030723-1-knut.omang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191107115404.3030723-1-knut.omang@oracle.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 07-11-19 12:54:04, Knut Omang wrote: > With the restructuring done in commit 9adeaa226988 > ("mm, slab: move memcg_cache_params structure to mm/slab.h") > > it is no longer possible for code external to mm to access > the name of a kmem_cache as struct kmem_cache has effectively become > opaque. Having access to the cache name is helpful to kernel testing > infrastructure. > > Expose a new function kmem_cache_name to mitigate that. Who is going to use that symbol? It is preferred that a user is added in the same patch as the newly added symbol. > Signed-off-by: Knut Omang > --- > include/linux/slab.h | 1 + > mm/slab_common.c | 9 +++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 4d2a2fa55ed5..3298c9db6e46 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -702,6 +702,7 @@ static inline void *kzalloc_node(size_t size, gfp_t flags, int node) > } > > unsigned int kmem_cache_size(struct kmem_cache *s); > +const char *kmem_cache_name(struct kmem_cache *s); > void __init kmem_cache_init_late(void); > > #if defined(CONFIG_SMP) && defined(CONFIG_SLAB) > diff --git a/mm/slab_common.c b/mm/slab_common.c > index f9fb27b4c843..269a99dc8214 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -82,6 +82,15 @@ unsigned int kmem_cache_size(struct kmem_cache *s) > } > EXPORT_SYMBOL(kmem_cache_size); > > +/* > + * Get the name of a slab object > + */ > +const char *kmem_cache_name(struct kmem_cache *s) > +{ > + return s->name; > +} > +EXPORT_SYMBOL(kmem_cache_name); > + > #ifdef CONFIG_DEBUG_VM > static int kmem_cache_sanity_check(const char *name, unsigned int size) > { > -- > 2.20.1 -- Michal Hocko SUSE Labs