Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D68C43331 for ; Thu, 7 Nov 2019 20:03:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0574720869 for ; Thu, 7 Nov 2019 20:03:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725870AbfKGUDv (ORCPT ); Thu, 7 Nov 2019 15:03:51 -0500 Received: from ms.lwn.net ([45.79.88.28]:39410 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725792AbfKGUDv (ORCPT ); Thu, 7 Nov 2019 15:03:51 -0500 Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 955826EC; Thu, 7 Nov 2019 20:03:50 +0000 (UTC) Date: Thu, 7 Nov 2019 13:03:49 -0700 From: Jonathan Corbet To: Jeff Layton Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH] Documentation: atomic_open called with shared lock on non-O_CREAT open Message-ID: <20191107130349.5b590947@lwn.net> In-Reply-To: <20191030104654.6315-1-jlayton@kernel.org> References: <20191030104654.6315-1-jlayton@kernel.org> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, 30 Oct 2019 06:46:54 -0400 Jeff Layton wrote: > The exclusive lock is only held when O_CREAT is set. > > Signed-off-by: Jeff Layton > --- > Documentation/filesystems/locking.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst > index fc3a0704553c..5057e4d9dcd1 100644 > --- a/Documentation/filesystems/locking.rst > +++ b/Documentation/filesystems/locking.rst > @@ -105,7 +105,7 @@ getattr: no > listxattr: no > fiemap: no > update_time: no > -atomic_open: exclusive > +atomic_open: shared (exclusive if O_CREAT is set in open flags) > tmpfile: no > ============ ============================================= Applied, thanks. jon