From: Tom Rini Date: Thu, 7 Nov 2019 15:05:27 -0500 Subject: [U-Boot] [PATCH v4 2/5] omap: mmc: Avoid using libfdt with of-platdata In-Reply-To: <20191107155318.103300-3-sjg@chromium.org> References: <20191107155318.103300-1-sjg@chromium.org> <20191107155318.103300-3-sjg@chromium.org> Message-ID: <20191107200527.GM19317@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Nov 07, 2019 at 08:53:09AM -0700, Simon Glass wrote: > At present this driver is enabled in SPL on omapl138_lcdk, which uses > of-platdata. The driver needs to be ported to use of-platdata properly. > For now, avoid a build error by returning an error. > > Signed-off-by: Simon Glass > > --- > > Changes in v4: > - Add new patch for omap MMC build errors > > Changes in v3: None > > drivers/mmc/davinci_mmc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mmc/davinci_mmc.c b/drivers/mmc/davinci_mmc.c > index 0d63279db0..79a7f50d25 100644 > --- a/drivers/mmc/davinci_mmc.c > +++ b/drivers/mmc/davinci_mmc.c > @@ -507,6 +507,12 @@ static int davinci_mmc_probe(struct udevice *dev) > priv->version = data->version; > } > > + /* FIXME: Cannot read from device tree with of-platdata */ > + if (CONFIG_IS_ENABLED(OF_PLATDATA)) { > + printf("Please fix this driver to use of-platdata"); > + return -ENOSYS; > + } > + > priv->reg_base = (struct davinci_mmc_regs *)dev_read_addr(dev); > priv->input_clk = clk_get(DAVINCI_MMCSD_CLKID); Let me add the board maintainer here. Peter, are we even using MMC in SPL on the omapl138_lcdk? If so, I believe we need to add platdata ala other platforms like board/ti/am335x/board.c for example. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: