From: Jason Gunthorpe Subject: Re: [PATCH v2 02/15] mm/mmu_notifier: add an interval tree notifier Date: Thu, 7 Nov 2019 20:11:06 +0000 Message-ID: <20191107201102.GC21728@mellanox.com> References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-3-jgg@ziepe.ca> <35c2b322-004e-0e18-87e4-1920dc71bfd5@nvidia.com> <20191107020807.GA747656@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191107020807.GA747656@redhat.com> Content-Language: en-US Content-ID: <9C8D977ED7A453449570F9D0913CEE68@eurprd05.prod.outlook.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jerome Glisse Cc: "nouveau@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , Michal Hocko , "linux-mm@kvack.org" , Andrea Arcangeli , David Zhou , Stefano Stabellini , Oleksandr Andrushchenko , "linux-rdma@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , Christoph Hellwig , Ben Skeggs , "xen-devel@lists.xenproject.org" , Ralph Campbell , John Hubbard , Boris Ostrovsky , Petr Cvek , Juergen Gross , Mike Marciniszyn List-Id: amd-gfx.lists.freedesktop.org T24gV2VkLCBOb3YgMDYsIDIwMTkgYXQgMDk6MDg6MDdQTSAtMDUwMCwgSmVyb21lIEdsaXNzZSB3 cm90ZToKCj4gPiAKPiA+IEV4dHJhIGNyZWRpdDogSU1ITywgdGhpcyBjbGVhcmx5IGRlc2VydmVz IHRvIGFsbCBiZSBpbiBhIG5ldyBtbXVfcmFuZ2Vfbm90aWZpZXIuaAo+ID4gaGVhZGVyIGZpbGUs IGJ1dCBJIGtub3cgdGhhdCdzIGV4dHJhIHdvcmsuIE1heWJlIGxhdGVyIGFzIGEgZm9sbG93LXVw IHBhdGNoLAo+ID4gaWYgYW55b25lIGhhcyB0aGUgdGltZS4KPiAKPiBUaGUgcmFuZ2Ugbm90aWZp ZXIgc2hvdWxkIGdldCB0aGUgZXZlbnQgdG9vLCBpdCB3b3VsZCBiZSBhIHdhc3RlLCBpIHRoaW5r IGl0IGlzCj4gYW4gb3ZlcnNpZ2h0IGhlcmUuIFRoZSByZWxlYXNlIGV2ZW50IGlzIGZpbmUgc28g TkFLIHRvIHlvdSBzZXBhcmF0ZSBldmVudC4gRXZlbnQKPiBpcyByZWFsbHkgYW4gaGVscGVyIGZv ciBub3RpZmllciBpIGhhZCBhIHNldCBvZiBwYXRjaCBmb3Igbm91dmVhdSB0byBsZXZlcmFnZQo+ IHRoaXMgaSBuZWVkIHRvIHJlc3VjaXRlIHRoZW0uIFNvIG5vIG5lZWQgdG8gc3BsaXQgdGhpbmcs IGkgd291bGQganVzdCBmb3J3YXJkCj4gdGhlIGV2ZW50IGllIGFkZCBldmVudCB0byBtbXVfcmFu Z2Vfbm90aWZpZXJfb3BzLmludmFsaWRhdGUoKSBpIGZhaWxlZCB0byBjYXRjaAo+IHRoYXQgaW4g djEgc29ycnkuCgpJIHRoaW5rIHdoYXQgeW91IG1lYW4gaXMgYWxyZWFkeSBkb25lPwoKc3RydWN0 IG1tdV9yYW5nZV9ub3RpZmllcl9vcHMgewoJYm9vbCAoKmludmFsaWRhdGUpKHN0cnVjdCBtbXVf cmFuZ2Vfbm90aWZpZXIgKm1ybiwKCQkJICAgY29uc3Qgc3RydWN0IG1tdV9ub3RpZmllcl9yYW5n ZSAqcmFuZ2UsCgkJCSAgIHVuc2lnbmVkIGxvbmcgY3VyX3NlcSk7Cgo+IE5vIGl0IGlzIGFsd2F5 cyBvZGQsIHlvdSBtdXN0IGNhbGwgbW11X3JhbmdlX3NldF9zZXEoKSBvbmx5IGZyb20gdGhlCj4g b3AtPmludmFsaWRhdGVfcmFuZ2UoKSBjYWxsYmFjayBhdCB3aGljaCBwb2ludCB0aGUgc2VxIGlz IG9kZC4gQXMgd2VsbAo+IHdoZW4gbXJuIGlzIGFkZGVkIGFuZCBpdHMgc2VxIGZpcnN0IHNldCBp dCBpcyBzZXQgdG8gYW4gb2RkIHZhbHVlCj4gYWx3YXlzLiBNYXliZSB0aGUgY29tbWVudCwgc2hv dWxkIHJlYWQ6Cj4gCj4gICogbXJuLT5pbnZhbGlkYXRlX3NlcSBpcyBhbHdheXMsIHllcyBhbHdh eXMsIHNldCB0byBhbiBvZGQgdmFsdWUuIFRoaXMgZW5zdXJlcwo+IAo+IFRvIHN0cmVzcyB0aGF0 IGl0IGlzIG5vdCBhbiBlcnJvci4KCkkgd2VudCB3aXRoIHRoaXM6CgoJLyoKCSAqIG1ybi0+aW52 YWxpZGF0ZV9zZXEgbXVzdCBhbHdheXMgYmUgc2V0IHRvIGFuIG9kZCB2YWx1ZSB2aWEKCSAqIG1t dV9yYW5nZV9zZXRfc2VxKCkgdXNpbmcgdGhlIHByb3ZpZGVkIGN1cl9zZXEgZnJvbQoJICogbW5f aXRyZWVfaW52X3N0YXJ0X3JhbmdlKCkuIFRoaXMgZW5zdXJlcyB0aGF0IGlmIHNlcSBkb2VzIHdy YXAgd2UKCSAqIHdpbGwgYWx3YXlzIGNsZWFyIHRoZSBiZWxvdyBzbGVlcCBpbiBzb21lIHJlYXNv bmFibGUgdGltZSBhcwoJICogbW1uX21tLT5pbnZhbGlkYXRlX3NlcSBpcyBldmVuIGluIHRoZSBp ZGxlIHN0YXRlLgoJICovCgo+ID4gPiArCXNwaW5fbG9jaygmbW1uX21tLT5sb2NrKTsKPiA+ID4g KwlpZiAobW1uX21tLT5hY3RpdmVfaW52YWxpZGF0ZV9yYW5nZXMpIHsKPiA+ID4gKwkJaWYgKG1u X2l0cmVlX2lzX2ludmFsaWRhdGluZyhtbW5fbW0pKQo+ID4gPiArCQkJaGxpc3RfYWRkX2hlYWQo Jm1ybi0+ZGVmZXJyZWRfaXRlbSwKPiA+ID4gKwkJCQkgICAgICAgJm1tbl9tbS0+ZGVmZXJyZWRf bGlzdCk7Cj4gPiA+ICsJCWVsc2Ugewo+ID4gPiArCQkJbW1uX21tLT5pbnZhbGlkYXRlX3NlcSB8 PSAxOwo+ID4gPiArCQkJaW50ZXJ2YWxfdHJlZV9pbnNlcnQoJm1ybi0+aW50ZXJ2YWxfdHJlZSwK PiA+ID4gKwkJCQkJICAgICAmbW1uX21tLT5pdHJlZSk7Cj4gPiA+ICsJCX0KPiA+ID4gKwkJbXJu LT5pbnZhbGlkYXRlX3NlcSA9IG1tbl9tbS0+aW52YWxpZGF0ZV9zZXE7Cj4gPiA+ICsJfSBlbHNl IHsKPiA+ID4gKwkJV0FSTl9PTihtbl9pdHJlZV9pc19pbnZhbGlkYXRpbmcobW1uX21tKSk7Cj4g PiA+ICsJCW1ybi0+aW52YWxpZGF0ZV9zZXEgPSBtbW5fbW0tPmludmFsaWRhdGVfc2VxIC0gMTsK PiA+IAo+ID4gT2hoaCwgY2hlY2ttYXRlLiBJIGxvc2UuIFdoeSBpcyAqc3VidHJhY3RpbmcqIHRo ZSByaWdodCB0aGluZyB0byBkbwo+ID4gZm9yIHNlcSBudW1iZXJzIGhlcmU/ICBJJ20gYWN1dGVs eSB1bmhhcHB5IHRyeWluZyB0byBmaWd1cmUgdGhpcyBvdXQuCj4gPiBJIHN1c3BlY3QgaXQncyBh bm90aGVyIHVuZm9ydHVuYXRlIHNpZGUgZWZmZWN0IG9mIHRyeWluZyB0byB1c2UgdGhlCj4gPiBs b3dlciBiaXQgb2YgdGhlIHNlcSBudW1iZXIgKGV2ZW4vb2RkKSBmb3Igc29tZXRoaW5nIGVsc2Uu Cj4gCj4gSWYgdGhlcmUgaXMgbm8gbW1uX21tLT5hY3RpdmVfaW52YWxpZGF0ZV9yYW5nZXMgdGhl biBpdCBtZWFucyB0aGF0Cj4gbW1uX21tLT5pbnZhbGlkYXRlX3NlcSBpcyBldmVuIGFuZCB0aHVz IG1tbl9tbS0+aW52YWxpZGF0ZV9zZXEgLSAxCj4gaXMgYW4gb2RkIG51bWJlciB3aGljaCBtZWFu cyB0aGF0IG1ybi0+aW52YWxpZGF0ZV9zZXEgaXMgaW5pdGlhbGl6ZWQKPiB0byBvZGQgdmFsdWUg YW5kIGlmIHlvdSBmb2xsb3cgdGhlIHJ1bGUgZm9yIGNhbGxpbmcgbW11X3JhbmdlX3NldF9zZXEo KQo+IHRoZW4gaXQgd2lsbCBfYWx3YXlzXyBiZSBhbiBvZGQgbnVtYmVyIGFuZCB0aGlzIGNsb3Nl IHRoZSBsb29wIHdpdGgKPiB0aGUgYWJvdmUgY29tbWVudHMgOikKClRoZSBrZXkgdGhpbmcgaXMg dGhhdCBpdCBpcyBhbiBvZGQgdmFsdWUgdGhhdCB3aWxsIHRha2UgYSBsb25nIHRpbWUKYmVmb3Jl IG1tbl9tbS0+aW52YWxpZGF0ZSBzZXEgcmVhY2hlcyBpdAoKPiA+ID4gKwltaWdodF9sb2NrKCZt bS0+bW1hcF9zZW0pOwo+ID4gPiArCj4gPiA+ICsJbW1uX21tID0gc21wX2xvYWRfYWNxdWlyZSgm bW0tPm1tdV9ub3RpZmllcl9tbSk7Cj4gPiAKPiA+IFdoYXQgZG9lcyB0aGUgYWJvdmUgcGFpciB3 aXRoPyBTaG91bGQgaGF2ZSBhIGNvbW1lbnQgdGhhdCBzcGVjaWZpZXMgdGhhdC4KPiAKPiBJdCB3 YXMgZGlzY3Vzc2VkIGluIHYxIGJ1dCBtYXliZSBhIGNvbW1lbnQgb2Ygd2hhdCB3YXMgc2FpZCBi YWNrIHRoZW4gd291bGQKPiBiZSBoZWxwZnVsLiBTb21ldGhpbmcgbGlrZToKPiAKPiAvKgo+ICAq IFdlIG5lZWQgdG8gaW5zdXJlIHRoYXQgYWxsIHdyaXRlcyB0byBtbS0+bW11X25vdGlmaWVyX21t IGFyZSB2aXNpYmxlIGJlZm9yZQo+ICAqIGFueSBjaGVja3Mgd2UgZG8gb24gbW1uX21tIGJlbG93 IGFzIG90aGVyd2lzZSBDUFUgbWlnaHQgcmUtb3JkZXIgd3JpdGUgZG9uZQo+ICAqIGJ5IGFub3Ro ZXIgQ1BVIGNvcmUgdG8gbW0tPm1tdV9ub3RpZmllcl9tbSBzdHJ1Y3R1cmUgZmllbGRzIGFmdGVy IHRoZSByZWFkCj4gICogYmVsb3dzLgo+ICAqLwoKVGhpcyBjb21tZW50IG1hZGUgaXQsIGp1c3Qg YXQgdGhlIHN0b3JlIHNpZGU6CgoJLyoKCSAqIFNlcmlhbGl6ZSB0aGUgdXBkYXRlIGFnYWluc3Qg bW11X25vdGlmaWVyX3VucmVnaXN0ZXIuIEEKCSAqIHNpZGUgbm90ZTogbW11X25vdGlmaWVyX3Jl bGVhc2UgY2FuJ3QgcnVuIGNvbmN1cnJlbnRseSB3aXRoCgkgKiB1cyBiZWNhdXNlIHdlIGhvbGQg dGhlIG1tX3VzZXJzIHBpbiAoZWl0aGVyIGltcGxpY2l0bHkgYXMKCSAqIGN1cnJlbnQtPm1tIG9y IGV4cGxpY2l0bHkgd2l0aCBnZXRfdGFza19tbSgpIG9yIHNpbWlsYXIpLgoJICogV2UgY2FuJ3Qg cmFjZSBhZ2FpbnN0IGFueSBvdGhlciBtbXUgbm90aWZpZXIgbWV0aG9kIGVpdGhlcgoJICogdGhh bmtzIHRvIG1tX3Rha2VfYWxsX2xvY2tzKCkuCgkgKgoJICogcmVsZWFzZSBzZW1hbnRpY3Mgb24g dGhlIGluaXRpYWxpemF0aW9uIG9mIHRoZSBtbXVfbm90aWZpZXJfbW0ncwogICAgICAgICAqIGNv bnRlbnRzIGFyZSBwcm92aWRlZCBmb3IgdW5sb2NrZWQgcmVhZGVycy4gIGFjcXVpcmUgY2FuIG9u bHkgYmUKICAgICAgICAgKiB1c2VkIHdoaWxlIGhvbGRpbmcgdGhlIG1tZ3JhYiBvciBtbWdldCwg YW5kIGlzIHNhZmUgYmVjYXVzZSBvbmNlCiAgICAgICAgICogY3JlYXRlZCB0aGUgbW11X25vdGlm aWZlcl9tbSBpcyBub3QgZnJlZWQgdW50aWwgdGhlIG1tIGlzCiAgICAgICAgICogZGVzdHJveWVk LiAgQXMgYWJvdmUsIHVzZXJzIGhvbGRpbmcgdGhlIG1tYXBfc2VtIG9yIG9uZSBvZiB0aGUKICAg ICAgICAgKiBtbV90YWtlX2FsbF9sb2NrcygpIGRvIG5vdCBuZWVkIHRvIHVzZSBhY3F1aXJlIHNl bWFudGljcy4KCSAqLwoJaWYgKG1tdV9ub3RpZmllcl9tbSkKCQlzbXBfc3RvcmVfcmVsZWFzZSgm bW0tPm1tdV9ub3RpZmllcl9tbSwgbW11X25vdGlmaWVyX21tKTsKCldoaWNoIEkgdGhpbmsgaXMg cmVhbGx5IG92ZXJseSBiZWxhYm9yaW5nIHRoZSB0eXBpY2FsIHNtcApzdG9yZS9yZWxlYXNlIHBh dHRlcm4sIGJ1dCBwZW9wbGUgZG8gc2VlbSB1bmZhbWlsaWFyIHdpdGggdGhlbS4uLgoKVGhhbmtz LApKYXNvbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K WGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0 cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==