Content-Type: multipart/mixed; boundary="===============5158372760159048154==" MIME-Version: 1.0 From: Florian Westphal To: mptcp at lists.01.org Subject: [MPTCP] [RFC PATCH 6/6] sendmsg: block until mptcp sk is writeable Date: Fri, 08 Nov 2019 23:09:53 +0100 Message-ID: <20191108220953.30904-7-fw@strlen.de> In-Reply-To: 20191108220953.30904-1-fw@strlen.de X-Status: X-Keywords: X-UID: 2455 --===============5158372760159048154== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This disables transmit of new data until the peer has acked enough mptcp data to get below the wspace write threshold (more than half of wspace upperlimit is available again). Also have poll not report EPOLLOUT in this case, its not relevant if a subflow is writeable. The latter is a temporary workaround that is needed because mptcp_poll walks the subflows and calls __tcp_poll on each of them. Because subflow ssk is usually writable, we will have to undo-that if the mptcp sndbuf is exhausted. This won't be needed anymore once __tcp_poll is removed, I am working on this. Signed-off-by: Florian Westphal --- net/mptcp/protocol.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 5c6948085ef4..db0261abe4df 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -406,6 +406,18 @@ static int mptcp_sendmsg(struct sock *sk, struct msghd= r *msg, size_t len) return ret; } = + timeo =3D sock_sndtimeo(sk, msg->msg_flags & MSG_DONTWAIT); + + mptcp_clean_una(sk); + + while (!sk_stream_is_writeable(sk)) { + ret =3D sk_stream_wait_memory(sk, &timeo); + if (ret) + goto out; + + mptcp_clean_una(sk); + } + ssk =3D mptcp_subflow_get(msk); if (!ssk) { release_sock(sk); @@ -421,8 +433,6 @@ static int mptcp_sendmsg(struct sock *sk, struct msghdr= *msg, size_t len) pr_debug("conn_list->subflow=3D%p", ssk); = lock_sock(ssk); - mptcp_clean_una(sk); - timeo =3D sock_sndtimeo(sk, msg->msg_flags & MSG_DONTWAIT); while (msg_data_left(msg)) { ret =3D mptcp_sendmsg_frag(sk, ssk, msg, NULL, &timeo, &mss_now, &size_goal); @@ -1328,6 +1338,10 @@ static __poll_t mptcp_poll(struct file *file, struct= socket *sock, tcp_sock =3D mptcp_subflow_tcp_socket(subflow); ret |=3D __tcp_poll(tcp_sock->sk); } + + if (!sk_stream_is_writeable(sk)) + ret &=3D ~(EPOLLOUT|EPOLLWRNORM); + release_sock(sk); = return ret; -- = 2.23.0 --===============5158372760159048154==--