Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4D8EC17440 for ; Sun, 10 Nov 2019 03:00:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CCC621019 for ; Sun, 10 Nov 2019 03:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573354853; bh=fg91nLDGVt3w607YoMYtnBvNOU3I7TSwxUy5GAjZX40=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=W82/qmF8GEbmuh18qOdjsSaiebRwMLa4FQ0pIEvsA6Fq6ZiMIOLSHwPo8jnEckzDX 79aN9jTXjd5ABLWRFJaSXwguqDeheCb5TfkNbtT396aPjxwvb99FKDWXf6eUf5htSW ZhIAT2DFehav9nc7jmU/iqWLUmFQRbV7c5q7/FVw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728209AbfKJDAx (ORCPT ); Sat, 9 Nov 2019 22:00:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:47202 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729205AbfKJC4q (ORCPT ); Sat, 9 Nov 2019 21:56:46 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F2FD32249E; Sun, 10 Nov 2019 02:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573354086; bh=fg91nLDGVt3w607YoMYtnBvNOU3I7TSwxUy5GAjZX40=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qS/T/2YY7VCsxIfv9Z2e/PUJRRLWSi3KpaCCxepIgvuKyAKBYpkBTT1rKTWirGS0H BCgY9/nKavdmbqRchHu++cg0cJgxium5zApat8uF2fg/N+ymPxQIv/46JUTXWjdXiu LQ5S0aqlp9QTk6wQYOeihCJ4qiXPy8iO8IPnaX/o= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Balakrishna Godavarthi , Marcel Holtmann , Sasha Levin , linux-bluetooth@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 083/109] Bluetooth: hci_serdev: clear HCI_UART_PROTO_READY to avoid closing proto races Date: Sat, 9 Nov 2019 21:45:15 -0500 Message-Id: <20191110024541.31567-83-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191110024541.31567-1-sashal@kernel.org> References: <20191110024541.31567-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Balakrishna Godavarthi [ Upstream commit 7cf7846d27bfc9731e449857db3eec5e0e9701ba ] Clearing HCI_UART_PROTO_READY will avoid usage of proto function pointers before running the proto close function pointer. There is chance of kernel crash, due to usage of non proto close function pointers after proto close. Signed-off-by: Balakrishna Godavarthi Signed-off-by: Marcel Holtmann Signed-off-by: Sasha Levin --- drivers/bluetooth/hci_serdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c index 52e6d4d1608e3..69c00a3db5382 100644 --- a/drivers/bluetooth/hci_serdev.c +++ b/drivers/bluetooth/hci_serdev.c @@ -360,6 +360,7 @@ void hci_uart_unregister_device(struct hci_uart *hu) { struct hci_dev *hdev = hu->hdev; + clear_bit(HCI_UART_PROTO_READY, &hu->flags); hci_unregister_dev(hdev); hci_free_dev(hdev); -- 2.20.1