Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE51EC43331 for ; Mon, 11 Nov 2019 17:35:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72052214DB for ; Mon, 11 Nov 2019 17:35:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RAy2pJIt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="cdX7Ac0A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72052214DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qfHlFCpScVuzWlaHTaKMURzRVbjEtwsHJjbEtKH+/Js=; b=RAy2pJItxDmg2E+XWkmxrMVdy S+6o0VbYb6SuAxTRfTEX4RIfoKoXXG5mjjxWgVvyiwoQS5e3g3kBzpDw5KJM6YikxsGmE9pVj+Psc ylA4Jm72Ee5KY6wT8UJbh5Tz5f5Yn8ZEabxjYtlto82/LXtGm0kIvwhpkhB1aYFWqa9Ai7n5ov6ws npGq/z1axJ0C8GbcvC8eYv0gLRDRySdl4Z3wAJMwDGO9utW6EpCmsobKBR2aYZJHW33wuwYQ+ti+A sKCGkoTfhXxU9vXCFMxNg6+Jc9ao6wP5FNgdb53xAEB2O1H6OhuJSDGuy4foiQusmbZJjV+CQP4AI RJJ5IJWZw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUDb8-0003tn-N4; Mon, 11 Nov 2019 17:35:30 +0000 Received: from heliosphere.sirena.org.uk ([172.104.155.198]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUDb6-0003sk-33 for linux-arm-kernel@lists.infradead.org; Mon, 11 Nov 2019 17:35:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GlQJdcse6wO1nHPeRjgm0snqCR0okS99BVp/xqVRpiY=; b=cdX7Ac0A4CqBU+v0mannGiJ+H 7NsaQS9+uir92uYkkB2874BsR+aoLOS0G0Av6p1tZe4W+lFJhem2xVt+Lj7usmPOdpn6ViBd91xBS 21p6jNdqGN99ptsq1QEeq0lFisnnopjqZMSE39ycEV0GfVkcrGIbLxTTp+3XMVg6ilK+8=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iUDb3-00056s-Hq; Mon, 11 Nov 2019 17:35:25 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id AC7BF27429EB; Mon, 11 Nov 2019 17:35:24 +0000 (GMT) Date: Mon, 11 Nov 2019 17:35:24 +0000 From: Mark Brown To: Suzuki K Poulose Subject: Re: [PATCH v8 1/4] arm64: Add initial support for E0PD Message-ID: <20191111173524.GC4264@sirena.co.uk> References: <20191108170116.32105-1-broonie@kernel.org> <20191108170116.32105-2-broonie@kernel.org> <97449111-a649-8e78-7f33-afbfae293eaf@arm.com> MIME-Version: 1.0 In-Reply-To: <97449111-a649-8e78-7f33-afbfae293eaf@arm.com> X-Cookie: A lie in time saves nine. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_093528_134444_AEC1A023 X-CRM114-Status: GOOD ( 12.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============6740045904983630893==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6740045904983630893== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CblX+4bnyfN0pR09" Content-Disposition: inline --CblX+4bnyfN0pR09 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 11, 2019 at 02:22:33PM +0000, Suzuki K Poulose wrote: > On 08/11/2019 17:01, Mark Brown wrote: > > + /* > > + * The cpu_enable() callback gets called even on CPUs that > > + * don't detect the feature so we need to verify if we can > > + * enable. > > + */ > > + if (this_cpu_has_cap(ARM64_HAS_E0PD)) > > + sysreg_clear_set(tcr_el1, 0, TCR_E0PD1); > As mentioned in the previous version, this could set a superfluous model > for people to do the same check for future SYSTEM_FEATURE type capabilities. > I leave it to the maintainers. To also reiterate the check doesn't hurt anything and avoids the potential for future breakage if the capability gets changed (which would be good to do). --CblX+4bnyfN0pR09 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3Jm9sACgkQJNaLcl1U h9DmJwf/fxqH/Vhl/65JZWWFB8QNEN96T8bT3WzNYb1Mq1razoIDsXSLA8a8r+rM dpy80CFxr/obLK5EHcp0xoNK6QXxexThGbeW5ohk33u9NHTnywcPNUCGWncX5YLO QYpgs9u7m2p102yQt1xtnRC57MOpQoYLt1QtBXMUv7Mkh9skexfb3lFglz5GFGmc Ip5Sq6P7qahIAAagxpxsfAnIbP9m0v5Lcb0qqQtOWA5ti7Fz78p6YMzEPjzJfqr5 +Sqnh6g3DXuv469+aBxLULNA+uLfMVQ6ZzaUxRfgwvzEh5RnMHJky5mn5ECmIoZs yxtddNbwGlh8yqYqpF0DaM63eur66g== =O4WX -----END PGP SIGNATURE----- --CblX+4bnyfN0pR09-- --===============6740045904983630893== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6740045904983630893==--