Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D44E4C43331 for ; Mon, 11 Nov 2019 18:56:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A751521925 for ; Mon, 11 Nov 2019 18:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573498605; bh=OKGQPToTmHIJ8jurJdl4brdaM0zohBVeFg0cgXCGx0Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uaOg1KbvQrI1G0sd3KlcexYZHVwCCrqnlBFvAJhW9orB4pJlR1deDjAEgpIfnA5e4 +2rR+DNbGiYcqkRA6bh1/6/LoAyV4Xtf6TNOaRqGPi71B3fEScOTLtQMlAu4V+/Sr7 AwJKe/8ljFGyWa+9g7c1+lV25BatxD0pkH80IuKQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730736AbfKKS4o (ORCPT ); Mon, 11 Nov 2019 13:56:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:55206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730727AbfKKS4k (ORCPT ); Mon, 11 Nov 2019 13:56:40 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5073E20818; Mon, 11 Nov 2019 18:56:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573498599; bh=OKGQPToTmHIJ8jurJdl4brdaM0zohBVeFg0cgXCGx0Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FzrtS5Lfmh6xsh3HATT9tX94N06Gc47k3TLkaWM4u12uaK9DAY2lJxA6HS28Rm65I uMwjT4pelTL1z2K9jjXcKvjXZ7dwP+JKj9sXEPcKKZ/TkCXU2fyIax3qngMv/7BpME gMV/79eY07A5dYzXrac3pB9zCb874LQJaPgbEC50= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jun Lei , Yongqiang Sun , Anthony Koo , Leo Li , Alex Deucher , Sasha Levin Subject: [PATCH 5.3 167/193] drm/amd/display: do not synchronize "drr" displays Date: Mon, 11 Nov 2019 19:29:09 +0100 Message-Id: <20191111181513.449469732@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191111181459.850623879@linuxfoundation.org> References: <20191111181459.850623879@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jun Lei [ Upstream commit 8775e89fa7121535d2da738c95167b8c65aa6e90 ] [why] A display that supports DRR can never really be considered "synchronized" with any other display because we can dynamically enable DRR (i.e. without modeset). this will cause their relative CRTC positions to drift and lose sync. this will disrupt features such as MCLK switching that assume and depend on their permanent alignment (that can only change with modeset) [how] check for ignore_msa in stream when considered synchronizability this ignore_msa is basically actually implemented as "supports drr" Signed-off-by: Jun Lei Reviewed-by: Yongqiang Sun Acked-by: Anthony Koo Acked-by: Leo Li Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c index 68db60e4caf32..d1a33e04570f4 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c @@ -394,6 +394,9 @@ bool resource_are_streams_timing_synchronizable( if (stream1->view_format != stream2->view_format) return false; + if (stream1->ignore_msa_timing_param || stream2->ignore_msa_timing_param) + return false; + return true; } static bool is_dp_and_hdmi_sharable( @@ -1566,6 +1569,9 @@ bool dc_is_stream_unchanged( if (!are_stream_backends_same(old_stream, stream)) return false; + if (old_stream->ignore_msa_timing_param != stream->ignore_msa_timing_param) + return false; + return true; } -- 2.20.1