Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iUWWP-0003sC-9m for mharc-qemu-riscv@gnu.org; Tue, 12 Nov 2019 08:47:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52172) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUWWM-0003qH-OR for qemu-riscv@nongnu.org; Tue, 12 Nov 2019 08:47:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUWWK-00064V-PD for qemu-riscv@nongnu.org; Tue, 12 Nov 2019 08:47:50 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:41754 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iUWWG-0005qI-Mw for qemu-riscv@nongnu.org; Tue, 12 Nov 2019 08:47:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573566454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RYLIFYQlGm9Ki6YHiQ6cr/ujzB2VBpC1BfYM0Iim6bA=; b=T5gs3IXM0rIlCcCwqVoTT3fxfphT9IDzAu5lpjrKz1S/Ont/MGqPVSQcjjX0cfoeZbDVG3 +OAETxwth7WuECnYXEmL9ike/D2ISd6i84TDiy1ohTfQps1c+95XtM04U3b2YJWBghw9bU 9HIdadj1fy1s+Ip19xWOTLQm365Rc+4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274-zlx4a0vzMP2Ou6GrLn4HXA-1; Tue, 12 Nov 2019 08:47:31 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2DF3385EE6D; Tue, 12 Nov 2019 13:47:27 +0000 (UTC) Received: from gondolin (dhcp-192-218.str.redhat.com [10.33.192.218]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4CE076106A; Tue, 12 Nov 2019 13:46:40 +0000 (UTC) Date: Tue, 12 Nov 2019 14:46:38 +0100 From: Cornelia Huck To: =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau Cc: Vladimir Sementsov-Ogievskiy , "qemu-devel@nongnu.org" , "armbru@redhat.com" , Gerd Hoffmann , "Gonglei (Arei)" , Eduardo Habkost , Igor Mammedov , Laurent Vivier , Amit Shah , Kevin Wolf , Max Reitz , John Snow , Ari Sundholm , Pavel Dovgalyuk , Paolo Bonzini , Stefan Hajnoczi , Fam Zheng , Stefan Weil , Ronnie Sahlberg , Peter Lieven , Eric Blake , Denis Lunev , Alberto Garcia , Jason Dillaman , Wen Congyang , Xie Changlong , Liu Yuan , "Richard W.M. Jones" , Jeff Cody , "Daniel P. =?UTF-8?B?QmVycmFuZ8Op?=" , Richard Henderson , Greg Kurz , "Michael S. Tsirkin" , Marcel Apfelbaum , Beniamino Galvani , Peter Maydell , =?UTF-8?B?Q8OpZHJpYw==?= Le Goater , Andrew Jeffery , Joel Stanley , Andrew Baumann , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Antony Pavlov , Jean-Christophe Dubois , Peter Chubb , Subbaraya Sundeep , Eric Auger , Alistair Francis , "Edgar E. Iglesias" , Stefano Stabellini , Anthony Perard , Paul Durrant , Paul Burton , Aleksandar Rikalo , Chris Wulff , Marek Vasut , David Gibson , Halil Pasic , Christian Borntraeger , =?UTF-8?B?SGVydsOp?= Poussineau , Xiao Guangrong , Aurelien Jarno , Aleksandar Markovic , Mark Cave-Ayland , Jason Wang , Laszlo Ersek , Yuval Shaia , Palmer Dabbelt , Sagar Karandikar , Bastian Koppelmann , David Hildenbrand , Thomas Huth , Eric Farman , Matthew Rosato , Hannes Reinecke , Michael Walle , Artyom Tarasenko , Stefan Berger , Samuel Thibault , Alex Williamson , Tony Krowiak , Pierre Morel , Michael Roth , Hailiang Zhang , Juan Quintela , "Dr. David Alan Gilbert" , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Jan Kiszka , Anthony Green , Stafford Horne , Guan Xuetao , Max Filippov , "qemu-block@nongnu.org" , "integration@gluster.org" , "sheepdog@lists.wpkg.org" , "qemu-arm@nongnu.org" , "xen-devel@lists.xenproject.org" , "qemu-ppc@nongnu.org" , "qemu-s390x@nongnu.org" , "qemu-riscv@nongnu.org" Subject: Re: [RFC v5 000/126] error: auto propagated local_err Message-ID: <20191112144638.4baf555a.cohuck@redhat.com> In-Reply-To: References: <20191011160552.22907-1-vsementsov@virtuozzo.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: zlx4a0vzMP2Ou6GrLn4HXA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Nov 2019 13:47:52 -0000 On Fri, 8 Nov 2019 22:57:25 +0400 Marc-Andr=C3=A9 Lureau wrote: > Hi >=20 > On Fri, Nov 8, 2019 at 7:31 PM Vladimir Sementsov-Ogievskiy > wrote: > > > > Finally, what is the plan? > > > > Markus what do you think? > > > > Now a lot of patches are reviewed, but a lot of are not. > > > > Is there any hope that all patches will be reviewed? Should I resend th= e > > whole series, or may be reduce it to reviewed subsystems only? =20 >=20 > I don't think we have well established rules for whole-tree cleanups > like this. In the past, several cleanup series got lost. Yes, it is always problematic if a series touches a lot of different subsystems. >=20 > It will take ages to get every subsystem maintainer to review the > patches. Most likely, since they are quite systematic, there isn't > much to say and it is easy to miss something that has some hidden > ramifications. Perhaps whole-tree cleanups should require at least 2 > reviewers to bypass the subsytem maintainer review? But my past > experience with this kind of exercice doesn't encourage me, and > probably I am not the only one. It's not just the reviews; it's easy to miss compile problems on less mainstream architectures (and even easier to miss functional problems there, although they are probably less likely with automated rework.) CI can probably help, but that's something for the future. Anyway, I've now gotten around to that series; spotted one problem in s390x code, I think. One thing that's helpful for such a large series is a git branch that makes it easy to give the series a quick go. (You can use patchew, but it takes time before it gets all mails, so just pushing it somewhere and letting people know is a good idea anyway.)