Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD03CC43331 for ; Tue, 12 Nov 2019 15:36:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A332C2196E for ; Tue, 12 Nov 2019 15:36:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="vNZK49hL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727438AbfKLPgT (ORCPT ); Tue, 12 Nov 2019 10:36:19 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38328 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727413AbfKLPgS (ORCPT ); Tue, 12 Nov 2019 10:36:18 -0500 Received: by mail-wr1-f67.google.com with SMTP id i12so12114781wro.5 for ; Tue, 12 Nov 2019 07:36:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=k17G4/k14hbg33i0y5emKB2JxsbyP5lZINIA3GVR6Ac=; b=vNZK49hL08luZcKZcNcKfN1l0ymztc0UsMX8ackvR3mqdcw+Pv2JwSJmkt96MtfoEi dyy0MAniEffSDa2q+7Zy/98OJfySrJOc8dYsqobLW392O8eJyuXPbnzdXQQTJEIScITd 9DW+mV/22nfs3qdoy9Cuuh5VdhElFTDHORRig= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=k17G4/k14hbg33i0y5emKB2JxsbyP5lZINIA3GVR6Ac=; b=fGpQdx+co8FTw8k6Pg182yIYzGZj+lGpXg8iRujMk9lVBKOyEdINeXzBujFFgEkwOg 4CP/fIjFXzFdGJta83uAgOJC3fN5beERjUw9bf+yjcTdpLkzM3eqnN4wR788ZSE7+MLu CDccm69SXtMfeuyL4HKK73ZSly+IgpnwBPinRhVYt/2QqM3yrFoLgsUu7jBsxTVoZ/+7 gnWbT35Y8lqqdUcLK1C7g0vEQq2uj3xptu9qaY+wfDs/eF16UqbjjF0+B9K1pCkZFqBd LSaEQObdk/xfnMMXErloy7pYZLb6BunfkyUCZBkzA0n9Finx0aGJ7fazeLDSln1I6fY6 Sxvw== X-Gm-Message-State: APjAAAWovXCTvYEvYIYHIsP10TtJ8GJKHs/1o9kGgUOu9KeIGSRb3P2V q6pxhbNHxohNsublrscPbz0n1g== X-Google-Smtp-Source: APXvYqzwUrXvfa2S84jmvkf+1VHxA7jW0AXBWdIpOIYr1V07/+IUjlgLUHUcp7h5W4FRHudbPBwvRg== X-Received: by 2002:a5d:5227:: with SMTP id i7mr7311556wra.277.1573572975840; Tue, 12 Nov 2019 07:36:15 -0800 (PST) Received: from localhost.localdomain ([2a06:98c0:1000:8250:6be3:785e:4546:dd8f]) by smtp.gmail.com with ESMTPSA id f19sm35887935wrf.23.2019.11.12.07.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 07:36:14 -0800 (PST) From: Arthur Fabre To: Solarflare linux maintainers , Edward Cree , Charles McLachlan , Martin Habets , David Miller , Alexei Starovoitov , Daniel Borkmann , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, bpf@vger.kernel.org Cc: kernel-team@cloudflare.com, Arthur Fabre Subject: [PATCH v2 net-next] sfc: trace_xdp_exception on XDP failure Date: Tue, 12 Nov 2019 15:36:01 +0000 Message-Id: <20191112153601.5849-1-afabre@cloudflare.com> X-Mailer: git-send-email 2.24.0.rc2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The sfc driver can drop packets processed with XDP, notably when running out of buffer space on XDP_TX, or returning an unknown XDP action. This increments the rx_xdp_bad_drops ethtool counter. Call trace_xdp_exception everywhere rx_xdp_bad_drops is incremented, except for fragmented RX packets as the XDP program hasn't run yet. This allows it to easily be monitored from userspace. This mirrors the behavior of other drivers. Signed-off-by: Arthur Fabre --- Changes since v1: - Removed trace_xdp_exception from receive fragements check, as XDP program hasn't been run yet drivers/net/ethernet/sfc/rx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/sfc/rx.c b/drivers/net/ethernet/sfc/rx.c index a7d9841105d8..bec261905530 100644 --- a/drivers/net/ethernet/sfc/rx.c +++ b/drivers/net/ethernet/sfc/rx.c @@ -724,6 +724,7 @@ static bool efx_do_xdp(struct efx_nic *efx, struct efx_channel *channel, netif_err(efx, rx_err, efx->net_dev, "XDP TX failed (%d)\n", err); channel->n_rx_xdp_bad_drops++; + trace_xdp_exception(efx->net_dev, xdp_prog, xdp_act); } else { channel->n_rx_xdp_tx++; } @@ -737,6 +738,7 @@ static bool efx_do_xdp(struct efx_nic *efx, struct efx_channel *channel, netif_err(efx, rx_err, efx->net_dev, "XDP redirect failed (%d)\n", err); channel->n_rx_xdp_bad_drops++; + trace_xdp_exception(efx->net_dev, xdp_prog, xdp_act); } else { channel->n_rx_xdp_redirect++; } @@ -746,6 +748,7 @@ static bool efx_do_xdp(struct efx_nic *efx, struct efx_channel *channel, bpf_warn_invalid_xdp_action(xdp_act); efx_free_rx_buffers(rx_queue, rx_buf, 1); channel->n_rx_xdp_bad_drops++; + trace_xdp_exception(efx->net_dev, xdp_prog, xdp_act); break; case XDP_ABORTED: -- 2.24.0.rc2