From: Daniel Vetter Subject: Re: [PATCH v2] drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap Date: Wed, 13 Nov 2019 17:28:43 +0100 Message-ID: <20191113162843.GR23790@phenom.ffwll.local> References: <20191025073042.GL11828@phenom.ffwll.local> <20191108162759.GY23790@phenom.ffwll.local> <20191112093246.GD23790@phenom.ffwll.local> <06f1f400-2e20-5c40-c0ea-967f1ab2b787@suse.de> <20191112103819.vcuhtqpfzbkta6ml@sirius.home.kraxel.org> <20191112144435.GK23790@phenom.ffwll.local> <20191113073902.343vfunbjuzy725y@sirius.home.kraxel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 07F8D6ED85 for ; Wed, 13 Nov 2019 16:28:48 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id n1so3080441wra.10 for ; Wed, 13 Nov 2019 08:28:47 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Thomas Zimmermann , dri-devel , Gerd Hoffmann List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMTMsIDIwMTkgYXQgMDc6NTM6NTZBTSAtMDYwMCwgUm9iIEhlcnJpbmcgd3Jv dGU6Cj4gT24gV2VkLCBOb3YgMTMsIDIwMTkgYXQgMjoxOCBBTSBEYW5pZWwgVmV0dGVyIDxkYW5p ZWxAZmZ3bGwuY2g+IHdyb3RlOgo+ID4KPiA+IE9uIFdlZCwgTm92IDEzLCAyMDE5IGF0IDg6Mzkg QU0gR2VyZCBIb2ZmbWFubiA8a3JheGVsQHJlZGhhdC5jb20+IHdyb3RlOgo+ID4gPgo+ID4gPiAg IEhpLAo+ID4gPgo+ID4gPiA+ID4gPiA+PiBWUkFNIGhlbHBlcnMgdXNlIGRybV9nZW1fdHRtX21t YXAoKSwgd2hpY2ggd3JhcHMgdHRtX2JvX21tYXBfb2JqKCkuCj4gPiA+ID4gPiA+ID4+IFRoZXNl IGNoYW5nZXMgc2hvdWxkIGJlIHRyYW5zcGFyZW50Lgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ ID4gVGhlcmUncyBzdGlsbCB0aGUgaXNzdWUgdGhhdCBmb3IgZG1hLWJ1ZiBtbWFwIHZzIGRybSBt bWFwIHlvdSB1c2UKPiA+ID4gPiA+ID4gPiBkaWZmZXJlbnQgZl9tYXBwaW5nLCB3aGljaCBtZWFu cyB0dG0ncyBwdGUgc2hvb3Rkb3duIHdvbid0IHdvcmsgY29ycmVjdGx5Cj4gPiA+ID4gPiA+ID4g Zm9yIGRtYS1idWYgbW1hcHMuIEJ1dCB5ZWFoIG5vcm1hbCBvcGVyYXRpb24gZm9yIHR0bS92cmFt IGhlbHBlcnMgc2hvdWxkCj4gPiA+ID4gPiA+ID4gYmUgZmluZS4KPiA+ID4gPiA+ID4KPiA+ID4g PiA+ID4gVlJBTSBoZWxwZXJzIGRvbid0IHN1cHBvcnQgZG1hYnVmcy4KPiA+ID4gPiA+Cj4gPiA+ ID4gPiBJdCdzIG5vdCB0aGF0IHNpbXBsZS4gIEV2ZW4gd2hlbiBub3Qgc3VwcG9ydGluZyBkbWEt YnVmIGV4cG9ydCBhbmQKPiA+ID4gPiA+IGltcG9ydCBpdCBpcyBzdGlsbCBwb3NzaWJsZSB0byBj cmVhdGUgZG1hLWJ1ZnMsIGltcG9ydCB0aGVtIGludG8gdGhlCj4gPiA+ID4gPiBzYW1lIGRyaXZl ciAod2hpY2ggZG9lc24ndCBhY3R1YWxseSBleHBvcnQraW1wb3J0IGJ1dCBqdXN0IGdyYWJzIGEg Z2VtCj4gPiA+ID4gPiBvYmplY3QgcmVmZXJlbmNlIGluc3RlYWQpIGFuZCBhbHNvIHRvIG1tYXAg dGhlbSB2aWEgcHJpbWUvZG1hLWJ1ZiBjb2RlCj4gPiA+ID4gPiBwYXRoIC4uLgo+ID4gPgo+ID4g PiAuLi4gYnV0IGFmdGVyIGxvb2tpbmcgYWdhaW4gSSB0aGluayB3ZSBhcmUgYWxsIGdyZWVuIGhl cmUuICBHaXZlbiB0aGF0Cj4gPiA+IG9ubHkgc2VsZi1pbXBvcnQgd29ya3Mgd2UnbGwgb25seSBz ZWUgdnJhbSBnZW0gb2JqZWN0cyBpbiB0aGUgbW1hcCBjb2RlCj4gPiA+IHBhdGgsIHdoaWNoIHNo b3VsZCBoYXZlIGV2ZXJ5dGhpbmcgc2V0IHVwIGNvcnJlY3RseS4gIFNhbWUgZ29lcyBmb3IgcXhs Lgo+ID4gPgo+ID4gPiBBbGwgb3RoZXIgdHRtIGRyaXZlcnMgc3RpbGwgdXNlIHRoZSBvbGQgbW1h cCBjb2RlIHBhdGgsIHNvIGFsbCBncmVlbgo+ID4gPiB0aGVyZSB0b28gSSB0aGluay4gIEFsc28g SSBzb21laG93IGRvdWJ0IGRtYS1idWYgbW1hcCB2cy4gZHJtIG1tYXAgZW5kcwo+ID4gPiB1cCB1 c2luZyBkaWZmZXJlbnQgZl9tYXBwaW5nLCB0dG0gY29kZSBoYXMgYSBXQVJOX09OIGluIHR0bV9i b192bV9vcGVuKCkKPiA+ID4gd2hpY2ggd291bGQgZmlyZSBzaG91bGQgdGhhdCBiZSB0aGUgY2Fz ZS4KPiA+ID4KPiA+ID4gRG8gaW1wb3J0ZWQgZG1hLWJ1ZnMgaGl0IHRoZSBkcm0gbW1hcCBjb2Rl IHBhdGggaW4gdGhlIGZpcnN0IHBsYWNlPwo+ID4gPiBXb3VsZG4ndCBtbWFwIGJlIGhhbmRsZWQg YnkgdGhlIGV4cG9ydGluZyBkcml2ZXI/Cj4gPgo+ID4gZHJtX2dlbV9kbWFidWZfbW1hcCAtPiBv YmotPmZ1bmNzLT5tbWFwIC0+IHR0bV9ib19tbWFwX29iago+ID4KPiA+IEFuZCBJJ20gbm90IHNl ZWluZyBhbnlvbmUgYWRqdXN0aW5nIHZtX2ZpbGUtPmZfbWFwcGluZyBhbnl3aGVyZSBoZXJlIGF0 IGFsbC4KPiA+Cj4gPiBOb3RlIHRvIGhpdCB0aGlzIHlvdSBuZWVkIHVzZXJzcGFjZSB0bwo+ID4g LSBoYW5kbGUyZmQgb24gYSBidWZmZXIgdG8gY3JlYXRlIGEgZG1hLWJ1ZiBmZAo+ID4gLSBjYWxs IG1tYXAgZGlyZWN0bHkgb24gdGhhdCBkbWEtYnVmIGZkCj4gCj4gVGhhdCB3YXMgZXhhY3RseSB0 aGUgdmdlbSBJR1QgdGVzdCB0aGF0IHByb21wdGVkICRzdWJqZWN0IGZpeC4gKFdpdGgKPiB2Z2Vt IG1vZGlmaWVkIHRvIHVzZSBzaG1lbSBoZWxwZXJzKQoKU2VlIG15IG90aGVyIG1haWwsIHRoaXMg b25seSBoaXRzIHRoZSByaWdodCBtbWFwIHBhdGhzLiBGb3IgdGhlIHVubWFwIHNpZGUKeW91IG5l ZWQgZXZlbiBtb3JlIChhbmQgdGhhdCBwYXJ0IGlzIGRyaXZlciBkZXBlbmRlbnQsIGFuZCB2Z2Vt IHdvdWxkIG5lZWQKc29tZSBkZWJ1ZyB0cmlja3MgdG8gZXhwb3NlIHRoYXQgZm9yIHRlc3Rpbmcp LgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jw b3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw=