From: Daniel Vetter Subject: Re: [PATCH] drm/ttm: fix mmap refcounting Date: Wed, 13 Nov 2019 17:33:00 +0100 Message-ID: <20191113163300.GS23790@phenom.ffwll.local> References: <20191113135612.19679-1-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F495897E3 for ; Wed, 13 Nov 2019 16:33:05 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id j18so5319374wmk.1 for ; Wed, 13 Nov 2019 08:33:05 -0800 (PST) Content-Disposition: inline In-Reply-To: <20191113135612.19679-1-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: David Airlie , "open list:DRM DRIVERS" , open list , drm@redhat.com, Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMTMsIDIwMTkgYXQgMDI6NTY6MTJQTSArMDEwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiBXaGVuIG1hcHBpbmcgdHRtIG9iamVjdHMgdmlhIGRybV9nZW1fdHRtX21tYXAoKSBo ZWxwZXIKPiBkcm1fZ2VtX21tYXBfb2JqKCkgd2lsbCB0YWtlIGFuIG9iamVjdCByZWZlcmVuY2Uu ICBUaGF0IGdldHMKPiBuZXZlciByZWxlYXNlZCBkdWUgdG8gdHRtIGhhdmluZyBpdHMgb3duIHJl ZmVyZW5jZSBjb3VudGluZy4KPiAKPiBGaXggdGhhdCBieSBkcm9wcGluZyB0aGUgZ2VtIG9iamVj dCByZWZlcmVuY2Ugb25jZSB0aGUgdHRtIG1tYXAKPiBjb21wbGV0ZWQgKGFuZCB0dG0gcmVmY291 bnQgZ290IGJ1bXBlZCkuCj4gCj4gRm9yIHRoYXQgdG8gd29yayBwcm9wZXJseSB0aGUgZHJtX2dl bV9vYmplY3RfZ2V0KCkgY2FsbCBpbgo+IGRybV9nZW1fdHRtX21tYXAoKSBtdXN0IGJlIG1vdmVk IHNvIGl0IGhhcHBlbnMgYmVmb3JlIGNhbGxpbmcKPiBvYmotPmZ1bmNzLT5tbWFwKCksIG90aGVy d2lzZSB0aGUgZ2VtIHJlZmNvdW50IHdvdWxkIGdvIGRvd24KPiB0byB6ZXJvLgo+IAo+IEZpeGVz OiAyMzE5MjdkOTM5ZjAgKCJkcm0vdHRtOiBhZGQgZHJtX2dlbV90dG1fbW1hcCgpIikKClNpbmNl IHRoZSBvZmZlbmRpbmcgcGF0Y2ggaXMgaW4gZHJtLW5leHQgYW5kIHdlJ3JlIGluIHRoZSBtZXJn ZSB3aW5kb3cKZnJlZXplIHBhc3QgLXJjNiBwbGVhc2UgcmVtZW1iZXIgdG8gYXBwbHkgdGhpcyB0 byBkcm0tbWlzYy1uZXh0LWZpeGVzLgpPdGhlcndpc2UgaXQnbGwgbWlzcyB0aGUgbWVyZ2Ugd2lu ZG93LgoKPiBTaWduZWQtb2ZmLWJ5OiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4K Ckkgd2FzIHdvbmRlcmluZyB3aGV0aGVyIHdlJ2QgbmVlZCBhIGNjOiBzdGFibGUsIGluIGNhc2Ug c29tZW9uZSBpcyByZWFsbHkKZmFzdCBhbmQgZ2V0cyB0aGUgdm1fY2xvc2UgaW4gYmVmb3JlIHdl IGZpbmlzaCB0aGUgbW1hcC4gQnV0IEkgdGhpbmsgd2UKc2hvdWxkIGJlIHNlcmlhbGl6ZWQgYnkg bW1hcF9zZW0gaGVyZSBlbm91Z2ggLi4uCgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFu aWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMg ICAgICAgICAgICB8IDI0ICsrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vZHJtX2dlbV90dG1faGVscGVyLmMgfCAxMyArKysrKysrKysrKystCj4gIDIgZmlsZXMgY2hh bmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jCj4g aW5kZXggMmYyYjg4OTA5NmIwLi4wMDBmYTRhMTg5OWYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2RybV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiBAQCAt MTEwNSwyMSArMTEwNSwzMyBAQCBpbnQgZHJtX2dlbV9tbWFwX29iaihzdHJ1Y3QgZHJtX2dlbV9v YmplY3QgKm9iaiwgdW5zaWduZWQgbG9uZyBvYmpfc2l6ZSwKPiAgCWlmIChvYmpfc2l6ZSA8IHZt YS0+dm1fZW5kIC0gdm1hLT52bV9zdGFydCkKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCj4gKwkv KiBUYWtlIGEgcmVmIGZvciB0aGlzIG1hcHBpbmcgb2YgdGhlIG9iamVjdCwgc28gdGhhdCB0aGUg ZmF1bHQKPiArCSAqIGhhbmRsZXIgY2FuIGRlcmVmZXJlbmNlIHRoZSBtbWFwIG9mZnNldCdzIHBv aW50ZXIgdG8gdGhlIG9iamVjdC4KPiArCSAqIFRoaXMgcmVmZXJlbmNlIGlzIGNsZWFuZWQgdXAg YnkgdGhlIGNvcnJlc3BvbmRpbmcgdm1fY2xvc2UKPiArCSAqICh3aGljaCBzaG91bGQgaGFwcGVu IHdoZXRoZXIgdGhlIHZtYSB3YXMgY3JlYXRlZCBieSB0aGlzIGNhbGwsIG9yCj4gKwkgKiBieSBh IHZtX29wZW4gZHVlIHRvIG1yZW1hcCBvciBwYXJ0aWFsIHVubWFwIG9yIHdoYXRldmVyKS4KPiAr CSAqLwo+ICsJZHJtX2dlbV9vYmplY3RfZ2V0KG9iaik7Cj4gKwo+ICAJaWYgKG9iai0+ZnVuY3Mg JiYgb2JqLT5mdW5jcy0+bW1hcCkgewo+ICAJCS8qIFJlbW92ZSB0aGUgZmFrZSBvZmZzZXQgKi8K PiAgCQl2bWEtPnZtX3Bnb2ZmIC09IGRybV92bWFfbm9kZV9zdGFydCgmb2JqLT52bWFfbm9kZSk7 Cj4gIAo+ICAJCXJldCA9IG9iai0+ZnVuY3MtPm1tYXAob2JqLCB2bWEpOwo+IC0JCWlmIChyZXQp Cj4gKwkJaWYgKHJldCkgewo+ICsJCQlkcm1fZ2VtX29iamVjdF9wdXRfdW5sb2NrZWQob2JqKTsK PiAgCQkJcmV0dXJuIHJldDsKPiArCQl9Cj4gIAkJV0FSTl9PTighKHZtYS0+dm1fZmxhZ3MgJiBW TV9ET05URVhQQU5EKSk7Cj4gIAl9IGVsc2Ugewo+ICAJCWlmIChvYmotPmZ1bmNzICYmIG9iai0+ ZnVuY3MtPnZtX29wcykKPiAgCQkJdm1hLT52bV9vcHMgPSBvYmotPmZ1bmNzLT52bV9vcHM7Cj4g IAkJZWxzZSBpZiAoZGV2LT5kcml2ZXItPmdlbV92bV9vcHMpCj4gIAkJCXZtYS0+dm1fb3BzID0g ZGV2LT5kcml2ZXItPmdlbV92bV9vcHM7Cj4gLQkJZWxzZQo+ICsJCWVsc2Ugewo+ICsJCQlkcm1f Z2VtX29iamVjdF9wdXRfdW5sb2NrZWQob2JqKTsKPiAgCQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwkJ fQo+ICAKPiAgCQl2bWEtPnZtX2ZsYWdzIHw9IFZNX0lPIHwgVk1fUEZOTUFQIHwgVk1fRE9OVEVY UEFORCB8IFZNX0RPTlREVU1QOwo+ICAJCXZtYS0+dm1fcGFnZV9wcm90ID0gcGdwcm90X3dyaXRl Y29tYmluZSh2bV9nZXRfcGFnZV9wcm90KHZtYS0+dm1fZmxhZ3MpKTsKPiBAQCAtMTEyOCwxNCAr MTE0MCw2IEBAIGludCBkcm1fZ2VtX21tYXBfb2JqKHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2Jq LCB1bnNpZ25lZCBsb25nIG9ial9zaXplLAo+ICAKPiAgCXZtYS0+dm1fcHJpdmF0ZV9kYXRhID0g b2JqOwo+ICAKPiAtCS8qIFRha2UgYSByZWYgZm9yIHRoaXMgbWFwcGluZyBvZiB0aGUgb2JqZWN0 LCBzbyB0aGF0IHRoZSBmYXVsdAo+IC0JICogaGFuZGxlciBjYW4gZGVyZWZlcmVuY2UgdGhlIG1t YXAgb2Zmc2V0J3MgcG9pbnRlciB0byB0aGUgb2JqZWN0Lgo+IC0JICogVGhpcyByZWZlcmVuY2Ug aXMgY2xlYW5lZCB1cCBieSB0aGUgY29ycmVzcG9uZGluZyB2bV9jbG9zZQo+IC0JICogKHdoaWNo IHNob3VsZCBoYXBwZW4gd2hldGhlciB0aGUgdm1hIHdhcyBjcmVhdGVkIGJ5IHRoaXMgY2FsbCwg b3IKPiAtCSAqIGJ5IGEgdm1fb3BlbiBkdWUgdG8gbXJlbWFwIG9yIHBhcnRpYWwgdW5tYXAgb3Ig d2hhdGV2ZXIpLgo+IC0JICovCj4gLQlkcm1fZ2VtX29iamVjdF9nZXQob2JqKTsKPiAtCj4gIAly ZXR1cm4gMDsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9nZW1fbW1hcF9vYmopOwo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV90dG1faGVscGVyLmMgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX2dlbV90dG1faGVscGVyLmMKPiBpbmRleCA3NDEyYmZjNWMwNWEuLjYwNWE4YTNk YTdmOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV90dG1faGVscGVyLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV90dG1faGVscGVyLmMKPiBAQCAtNjQsOCAr NjQsMTkgQEAgaW50IGRybV9nZW1fdHRtX21tYXAoc3RydWN0IGRybV9nZW1fb2JqZWN0ICpnZW0s Cj4gIAkJICAgICBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSkKPiAgewo+ICAJc3RydWN0IHR0 bV9idWZmZXJfb2JqZWN0ICpibyA9IGRybV9nZW1fdHRtX29mX2dlbShnZW0pOwo+ICsJaW50IHJl dDsKPiAgCj4gLQlyZXR1cm4gdHRtX2JvX21tYXBfb2JqKHZtYSwgYm8pOwo+ICsJcmV0ID0gdHRt X2JvX21tYXBfb2JqKHZtYSwgYm8pOwo+ICsJaWYgKHJldCA8IDApCj4gKwkJcmV0dXJuIHJldDsK PiArCj4gKwkvKgo+ICsJICogdHRtIGhhcyBpdHMgb3duIG9iamVjdCByZWZjb3VudGluZywgc28g ZHJvcCBnZW0gcmVmZXJlbmNlCj4gKwkgKiB0byBhdm9pZCBkb3VibGUgYWNjb3VudGluZyBjb3Vu dGluZy4KPiArCSAqLwo+ICsJZHJtX2dlbV9vYmplY3RfcHV0X3VubG9ja2VkKGdlbSk7Cj4gKwo+ ICsJcmV0dXJuIDA7Cj4gIH0KPiAgRVhQT1JUX1NZTUJPTChkcm1fZ2VtX3R0bV9tbWFwKTsKPiAg Cj4gLS0gCj4gMi4xOC4xCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwg SW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs