From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/ast: Replace drm_get_pci_device() and drm_put_dev() Date: Wed, 13 Nov 2019 17:35:41 +0100 Message-ID: <20191113163541.GT23790@phenom.ffwll.local> References: <20191113155857.9507-1-tzimmermann@suse.de> <20191113155857.9507-2-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id A3DC16ED92 for ; Wed, 13 Nov 2019 16:35:45 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id i12so3131228wro.5 for ; Wed, 13 Nov 2019 08:35:45 -0800 (PST) Content-Disposition: inline In-Reply-To: <20191113155857.9507-2-tzimmermann@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Zimmermann Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org, sam@ravnborg.org, kraxel@redhat.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMTMsIDIwMTkgYXQgMDQ6NTg6NTZQTSArMDEwMCwgVGhvbWFzIFppbW1lcm1h bm4gd3JvdGU6Cj4gQm90aCBmdW5jdGlvbnMgYXJlIGRlcHJlY2F0ZWQuIE9wZW4tY29kZSB0aGVt IHRoZW0gaW4gcHJlcGFyYXRpb24KPiBvZiByZW1vdmluZyBzdHJ1Y3QgZHJtX2RyaXZlci57bG9h ZCx1bmxvYWR9Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IFRob21hcyBaaW1tZXJtYW5uIDx0emltbWVy bWFubkBzdXNlLmRlPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYXN0L2FzdF9kcnYuYyB8IDMx ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI5IGlu c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9hc3QvYXN0X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2FzdC9hc3RfZHJ2LmMKPiBpbmRl eCBkNzYzZGE2ZjA4MzQuLjc4YzkwYTNjOTAzYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vYXN0L2FzdF9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hc3QvYXN0X2Rydi5jCj4g QEAgLTg2LDkgKzg2LDM1IEBAIHN0YXRpYyB2b2lkIGFzdF9raWNrX291dF9maXJtd2FyZV9mYihz dHJ1Y3QgcGNpX2RldiAqcGRldikKPiAgCj4gIHN0YXRpYyBpbnQgYXN0X3BjaV9wcm9iZShzdHJ1 Y3QgcGNpX2RldiAqcGRldiwgY29uc3Qgc3RydWN0IHBjaV9kZXZpY2VfaWQgKmVudCkKPiAgewo+ ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldjsKPiArCWludCByZXQ7Cj4gKwo+ICAJYXN0X2tpY2tf b3V0X2Zpcm13YXJlX2ZiKHBkZXYpOwo+ICAKPiAtCXJldHVybiBkcm1fZ2V0X3BjaV9kZXYocGRl diwgZW50LCAmZHJpdmVyKTsKPiArCXJldCA9IHBjaV9lbmFibGVfZGV2aWNlKHBkZXYpOwo+ICsJ aWYgKHJldCkKPiArCQlyZXR1cm4gcmV0Owo+ICsKPiArCWRldiA9IGRybV9kZXZfYWxsb2MoJmRy aXZlciwgJnBkZXYtPmRldik7CgpXb3VsZCBiZSBuaWNlIHRvIGFsc28gc3dpdGNoIG92ZXIgdG8g ZW1iZWRkaW5nIGRybV9kZXZpY2UgYW5kCmRybV9kZXZfaW5pdCwgYnV0IGZvciBhbm90aGVyIHBh dGNoLiBUaGlzIGlzCgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBm ZndsbC5jaD4KCj4gKwlpZiAoSVNfRVJSKGRldikpIHsKPiArCQlyZXQgPSBQVFJfRVJSKGRldik7 Cj4gKwkJZ290byBlcnJfcGNpX2Rpc2FibGVfZGV2aWNlOwo+ICsJfQo+ICsKPiArCWRldi0+cGRl diA9IHBkZXY7Cj4gKwlwY2lfc2V0X2RydmRhdGEocGRldiwgZGV2KTsKPiArCj4gKwlyZXQgPSBk cm1fZGV2X3JlZ2lzdGVyKGRldiwgZW50LT5kcml2ZXJfZGF0YSk7Cj4gKwlpZiAocmV0KQo+ICsJ CWdvdG8gZXJyX2RybV9kZXZfcHV0Owo+ICsKPiArCXJldHVybiAwOwo+ICsKPiArZXJyX2RybV9k ZXZfcHV0Ogo+ICsJZHJtX2Rldl9wdXQoZGV2KTsKPiArZXJyX3BjaV9kaXNhYmxlX2RldmljZToK PiArCXBjaV9kaXNhYmxlX2RldmljZShwZGV2KTsKPiArCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4g IHN0YXRpYyB2b2lkCj4gQEAgLTk2LDcgKzEyMiw4IEBAIGFzdF9wY2lfcmVtb3ZlKHN0cnVjdCBw Y2lfZGV2ICpwZGV2KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gcGNpX2dldF9k cnZkYXRhKHBkZXYpOwo+ICAKPiAtCWRybV9wdXRfZGV2KGRldik7Cj4gKwlkcm1fZGV2X3VucmVn aXN0ZXIoZGV2KTsKPiArCWRybV9kZXZfcHV0KGRldik7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQg YXN0X2RybV9mcmVlemUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAtLSAKPiAyLjIzLjAKPiAK Ci0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpo dHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWw=