From: Daniel Vetter Subject: Re: [PATCH] drm/ast: Fix potential NULL-pointer read during atomic mode setting Date: Thu, 14 Nov 2019 15:19:44 +0100 Message-ID: <20191114141944.GZ23790@phenom.ffwll.local> References: <20191114114532.31551-1-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 122526EA82 for ; Thu, 14 Nov 2019 14:19:49 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id f2so6650826wrs.11 for ; Thu, 14 Nov 2019 06:19:48 -0800 (PST) Content-Disposition: inline In-Reply-To: <20191114114532.31551-1-tzimmermann@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Zimmermann Cc: daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, kraxel@redhat.com, airlied@redhat.com, sam@ravnborg.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBOb3YgMTQsIDIwMTkgYXQgMTI6NDU6MzJQTSArMDEwMCwgVGhvbWFzIFppbW1lcm1h bm4gd3JvdGU6Cj4gV2hlbiBlbmFibGluZyB0aGUgQ1JUQyBhZnRlciB3YWtpbmcgdXAgZnJvbSBh IHBvd2VyLXNhdmluZyBtb2RlLCB0aGUKPiBwcmltYXJ5IHBsYW5lJ3MgZnJhbWVidWZmZXIgbWln aHQgYmUgTlVMTCwgd2hpY2ggbGVhZHMgdG8gYSBzdGFjayB0cmFjZQo+IGFzIHNob3duIGJlbG93 Lgo+IAo+ICAgWyAgNjMyLjYyNDYwOF0gQlVHOiBrZXJuZWwgTlVMTCBwb2ludGVyIGRlcmVmZXJl bmNlLCBhZGRyZXNzOiAwMDAwMDAwMDAwMDAwMDQ4Cj4gICBbICA2MzIuNjI0NjMxXSAjUEY6IHN1 cGVydmlzb3IgcmVhZCBhY2Nlc3MgaW4ga2VybmVsIG1vZGUKPiAgIFsgIDYzMi42MjQ2MzldICNQ RjogZXJyb3JfY29kZSgweDAwMDApIC0gbm90LXByZXNlbnQgcGFnZQo+ICAgWyAgNjMyLjYyNDY0 N10gUEdEIDAgUDREIDAKPiAgIFsgIDYzMi42MjQ2NTRdIE9vcHM6IDAwMDAgWyMxXSBTTVAgUFRJ Cj4gICBbICA2MzIuNjI0NjYyXSBDUFU6IDAgUElEOiAyMDgyIENvbW06IGdub21lLXNoZWxsIFRh aW50ZWQ6IEcgICAgICAgICAgICBFICAgICA1LjQuMC1yYzctMS1kZWZhdWx0KyAjMTE0Cj4gICBb ICA2MzIuNjI0NjczXSBIYXJkd2FyZSBuYW1lOiBTdW4gTWljcm9zeXN0ZW1zIFNVTiBGSVJFIFgy MjcwIE0yL1NVTiBGSVJFIFgyMjcwIE0yLCBCSU9TIDIuMDUgICAgMDcvMDEvMjAxMAo+ICAgWyAg NjMyLjYyNDY4OV0gUklQOiAwMDEwOmFzdF9jcnRjX2hlbHBlcl9hdG9taWNfZW5hYmxlKzB4N2Qv MHg2ODAgW2FzdF0KPiAgIFsgIDYzMi42MjQ2OThdIENvZGU6IDQ4IDhiIDgwIGUwIDAyIDAwIDAw IDRjIDhiIDYwIDEwIDMxIGMwIGYzIDQ4IGFiIDQ4IDhiIDgzIDc4IDA0IDAwIDAwIDRjIDg5IGVm IDQ4IDhkIDcwIDE4IGU4IDlhIGU5IDU1IGNlIDQ4IDhiIDgzIDc4IDA0IDAwIDAwIDw0OT4gOGIg N2MgMjQgNDggNGMgODkgZWEgNGMgOGQgNDQgMjQgMjggNDggOGQgNGMgMjQgMjAgNDggOGQgNzAg MTgKPiAgIFsgIDYzMi42MjQ3MThdIFJTUDogMDAxODpmZmZmYmU5ZWMxMjNmYTQwIEVGTEFHUzog MDAwMTAyNDYKPiAgIFsgIDYzMi42MjQ3MjZdIFJBWDogZmZmZjk1YTEzY2ZkMzQwMCBSQlg6IGZm ZmY5NWExM2NmMzIwMDAgUkNYOiAwMDAwMDAwMDAwMDAwMDAwCj4gICBbICA2MzIuNjI0NzM1XSBS RFg6IDAwMDAwMDAwMDAwMDAwMDAgUlNJOiBmZmZmOTVhMTNjZmQzNGU4IFJESTogZmZmZmJlOWVj MTIzZmI0MAo+ICAgWyAgNjMyLjYyNDc0NF0gUkJQOiBmZmZmYmU5ZWMxMjNmYjgwIFIwODogMDAw MDAwMDAwMDAwMDAwMCBSMDk6IDAwMDAwMDAwMDAwMDAwMDMKPiAgIFsgIDYzMi42MjQ3NTNdIFIx MDogMDAwMDAwMDAwMDAwMDAwMCBSMTE6IDAwMDAwMDAwMDAwMDAwMDAgUjEyOiAwMDAwMDAwMDAw MDAwMDAwCj4gICBbICA2MzIuNjI0NzYyXSBSMTM6IGZmZmZiZTllYzEyM2ZhNzAgUjE0OiBmZmZm OTVhMTNiZWI3MDAwIFIxNTogZmZmZjk1YTEzY2YzMjgwMAo+ICAgWyAgNjMyLjYyNDc3Ml0gRlM6 ICAwMDAwN2Y2ZDI3NjNlMTQwKDAwMDApIEdTOmZmZmY5NWExMzQwMDAwMDAoMDAwMCkga25sR1M6 MDAwMDAwMDAwMDAwMDAwMAo+ICAgWyAgNjMyLjYyNDc4Ml0gQ1M6ICAwMDEwIERTOiAwMDAwIEVT OiAwMDAwIENSMDogMDAwMDAwMDA4MDA1MDAzMwo+ICAgWyAgNjMyLjYyNDc5MF0gQ1IyOiAwMDAw MDAwMDAwMDAwMDQ4IENSMzogMDAwMDAwMDExOTJmODAwNCBDUjQ6IDAwMDAwMDAwMDAwMjA2ZjAK PiAgIFsgIDYzMi42MjQ4MDBdIENhbGwgVHJhY2U6Cj4gICBbICA2MzIuNjI0ODExXSAgPyBfX2xv Y2tfYWNxdWlyZSsweDQwOS8weDdjMAo+ICAgWyAgNjMyLjYyNDgzMF0gIGRybV9hdG9taWNfaGVs cGVyX2NvbW1pdF9tb2Rlc2V0X2VuYWJsZXMrMHgxYWYvMHgyMDAKPiAgIFsgIDYzMi42MjQ4NDBd ICBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfdGFpbCsweDMyLzB4NzAKPiAgIFsgIDYzMi42MjQ4 NDldICBjb21taXRfdGFpbCsweGM3LzB4MTEwCj4gICBbICA2MzIuNjI0ODU3XSAgZHJtX2F0b21p Y19oZWxwZXJfY29tbWl0KzB4MTIxLzB4MTMwCj4gICBbICA2MzIuNjI0ODY3XSAgZHJtX2F0b21p Y19jb25uZWN0b3JfY29tbWl0X2RwbXMrMHhkNy8weDEwMAo+ICAgWyAgNjMyLjYyNDg3OF0gIHNl dF9wcm9wZXJ0eV9hdG9taWMrMHhhZi8weDExMAo+ICAgWyAgNjMyLjYyNDg5MF0gIGRybV9tb2Rl X29ial9zZXRfcHJvcGVydHlfaW9jdGwrMHhiYi8weDE5MAo+ICAgWyAgNjMyLjYyNDg5OV0gID8g ZHJtX21vZGVfb2JqX2ZpbmRfcHJvcF9pZCsweDQwLzB4NDAKPiAgIFsgIDYzMi42MjQ5MDldICBk cm1faW9jdGxfa2VybmVsKzB4ODYvMHhkMAo+ICAgWyAgNjMyLjYyNDkxOF0gIGRybV9pb2N0bCsw eDFlNC8weDM2Ygo+ICAgWyAgNjMyLjYyNDkyNV0gID8gZHJtX21vZGVfb2JqX2ZpbmRfcHJvcF9p ZCsweDQwLzB4NDAKPiAgIFsgIDYzMi42MjQ5MzldICBkb192ZnNfaW9jdGwrMHg0YmQvMHg2ZTAK PiAgIFsgIDYzMi42MjQ5NDldICBrc3lzX2lvY3RsKzB4NWUvMHg5MAo+ICAgWyAgNjMyLjYyNDk1 N10gIF9feDY0X3N5c19pb2N0bCsweDE2LzB4MjAKPiAgIFsgIDYzMi42MjQ5NjZdICBkb19zeXNj YWxsXzY0KzB4NWEvMHgyMjAKPiAgIFsgIDYzMi42MjQ5NzZdICBlbnRyeV9TWVNDQUxMXzY0X2Fm dGVyX2h3ZnJhbWUrMHg0OS8weGJlCj4gICBbICA2MzIuNjI0OTg0XSBSSVA6IDAwMzM6MHg3ZjZk MmIwZGUzODcKPiAgIFsgIDYzMi42MjQ5OTFdIENvZGU6IDAwIDAwIDkwIDQ4IDhiIDA1IGY5IDlh IDBjIDAwIDY0IGM3IDAwIDI2IDAwIDAwIDAwIDQ4IGM3IGMwIGZmIGZmIGZmIGZmIGMzIDY2IDJl IDBmIDFmIDg0IDAwIDAwIDAwIDAwIDAwIGI4IDEwIDAwIDAwIDAwIDBmIDA1IDw0OD4gM2QgMDEg ZjAgZmYgZmYgNzMgMDEgYzMgNDggOGIgMGQgYzkgOWEgMGMgMDAgZjcgZDggNjQgODkgMDEgNDgK PiAgIFsgIDYzMi42MjUwMTFdIFJTUDogMDAyYjowMDAwN2ZmZmI0OWRlZjM4IEVGTEFHUzogMDAw MDAyNDYgT1JJR19SQVg6IDAwMDAwMDAwMDAwMDAwMTAKPiAgIFsgIDYzMi42MjUwMjFdIFJBWDog ZmZmZmZmZmZmZmZmZmZkYSBSQlg6IDAwMDA3ZmZmYjQ5ZGVmNzAgUkNYOiAwMDAwN2Y2ZDJiMGRl Mzg3Cj4gICBbICA2MzIuNjI1MDMwXSBSRFg6IDAwMDA3ZmZmYjQ5ZGVmNzAgUlNJOiAwMDAwMDAw MGMwMTg2NGJhIFJESTogMDAwMDAwMDAwMDAwMDAwOQo+ICAgWyAgNjMyLjYyNTA0MF0gUkJQOiAw MDAwMDAwMGMwMTg2NGJhIFIwODogMDAwMDAwMDAwMDAwMDAwMCBSMDk6IDAwMDAwMDAwYzBjMGMw YzAKPiAgIFsgIDYzMi42MjUwNDldIFIxMDogMDAwMDAwMDAwMDAwMDAzMCBSMTE6IDAwMDAwMDAw MDAwMDAyNDYgUjEyOiAwMDAwNTViYzM2N2ViOTIwCj4gICBbICA2MzIuNjI1MDU4XSBSMTM6IDAw MDAwMDAwMDAwMDAwMDkgUjE0OiAwMDAwMDAwMDAwMDAwMDAyIFIxNTogMDAwMDAwMDAwMDAwMDAw MAo+ICAgWyAgNjMyLjYyNTA3MV0gTW9kdWxlcyBsaW5rZWQgaW46IGVidGFibGVfZmlsdGVyKEUp IGVidGFibGVzKEUpIGlwNnRhYmxlX2ZpbHRlcihFKSBpcDZfdGFibGVzKEUpIGlwdGFibGVfZmls dGVyKEUpIGlwX3RhYmxlcyhFKSB4X3RhYmxlcyhFKSBhZl9wYWNrZXQoRSkgc2NzaV90cmFuc3Bv cnRfaXNjc2koRSkgZG1pX3N5c2ZzKEUpIG1zcihFKSB4ZnMoRSkgaW50ZWxfcG93ZXJjbGFtcChF KSBjb3JldGVtcChFKSBrKQo+ICAgWyAgNjMyLjYyNTE4NV0gQ1IyOiAwMDAwMDAwMDAwMDAwMDQ4 Cj4gCj4gVGhlIFNUUiBpcwo+IAo+ICAgKiBzdGFydCBnZG0gYW5kIHdhaXQgZm9yIGl0IHRvIHN3 aXRjaCBvZmYgdGhlIGRpc3BsYXkKPiAgICogd2FrZSB1cCB0aGUgZGlzcGxheSBieSBwcmVzc2lu ZyBhIGtleQo+IAo+IFRoZSBmaXggYXZvaWRzIGRlcmVmZXJlbmNpbmcgdGhlIHBvaW50ZXIgYW5k IHBvc3Rwb25lcyBtb2Rlc2V0dGluZyB1bnRpbAo+IHRoZXJlJ3MgYSBmcmFtZWJ1ZmZlciBib3Vu ZCB0byB0aGUgQ1JUQy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgWmltbWVybWFubiA8dHpp bW1lcm1hbm5Ac3VzZS5kZT4KPiBGaXhlczogYjQ4ZTFiNmZmZDI4ICgiZHJtL2FzdDogQWRkIENS VEMgaGVscGVycyBmb3IgYXRvbWljIG1vZGVzZXR0aW5nIikKPiBDYzogR2VyZCBIb2ZmbWFubiA8 a3JheGVsQHJlZGhhdC5jb20+Cj4gQ2M6IERhdmUgQWlybGllIDxhaXJsaWVkQHJlZGhhdC5jb20+ Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6ICJZLkMu IENoZW4iIDx5Y19jaGVuQGFzcGVlZHRlY2guY29tPgo+IENjOiBTYW0gUmF2bmJvcmcgPHNhbUBy YXZuYm9yZy5vcmc+CgpUaGlzIGxvb2tzIGxpa2UgcGFwZXJpbmcgb3ZlciB0aGUgcmVhbCBidWcs IHdoaWNoIGlzIGxhY2sgb2YgYXRvbWljX2NoZWNrCmluIHRoZSBwcmltYXJ5IHBsYW5lLiBZb3Ug cHJvYmFibHkgd2FudCB0byBjYWxsCmRybV9hdG9taWNfaGVscGVyX2NoZWNrX3BsYW5lX3N0YXRl IHNpbWlsYXIgdG8gd2hhdCB0aGUgc2ltcGxlciBrbXMgaGVscGVyCmRvZXMuIFRoYXQgc2hvdWxk IHN0b3AgdGhpcyBraW5kIG9mIHN0dWZmLgoKU3BlY2lmaWNhbGx5IHlvdSB0aGVuIHdhbnQgdG8g Y2hlY2sgd2hldGhlciB5b3VyIHByaW1hcnkgcGxhbmUgaXMgdmlzaWJsZQooY29tcHV0ZSBpbnRv IHBsYW5lX3N0YXRlLT52aXNpYmxlKSBhbmQgcmVqZWN0IHRoZSBhdG9taWMgY29tbWl0IGlmIHRo YXQncwpub3QgdGhlIGNhc2UuCi1EYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hc3Qv YXN0X21vZGUuYyB8IDEzICsrKysrKysrKysrKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2FzdC9hc3RfbW9kZS5jIGIvZHJpdmVycy9ncHUvZHJtL2FzdC9hc3RfbW9kZS5jCj4gaW5kZXgg NDcyNWVjOTExYTY2Li5iMTczYThlNWMwMGIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2FzdC9hc3RfbW9kZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FzdC9hc3RfbW9kZS5jCj4g QEAgLTc3NCw3ICs3NzQsOCBAQCBzdGF0aWMgaW50IGFzdF9jcnRjX2hlbHBlcl9hdG9taWNfY2hl Y2soc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJCQkJCSAgICAgICAmYWRqdXN0ZWRfbW9kZSwg JnZiaW9zX21vZGUpOwo+ICAJCWlmICghc3VjYykKPiAgCQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQl9 Cj4gKwl9IGVsc2UKPiArCQlzdGF0ZS0+bW9kZV9jaGFuZ2VkID0gdHJ1ZTsKPiAgCj4gIAlyZXR1 cm4gMDsKPiAgfQo+IEBAIC04MjQsNiArODI1LDkgQEAgYXN0X2NydGNfaGVscGVyX2F0b21pY19l bmFibGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJc3RydWN0IGFzdF92Ymlvc19tb2RlX2lu Zm8gdmJpb3NfbW9kZTsKPiAgCWJvb2wgc3VjYzsKPiAgCj4gKwlpZiAoIWZiKQo+ICsJCXJldHVy bjsKPiArCj4gIAltZW1zZXQoJmFkanVzdGVkX21vZGUsIDAsIHNpemVvZihhZGp1c3RlZF9tb2Rl KSk7Cj4gIAlkcm1fbW9kZV9jb3B5KCZhZGp1c3RlZF9tb2RlLCAmY3J0Yy0+c3RhdGUtPmFkanVz dGVkX21vZGUpOwo+ICAKPiBAQCAtODMyLDYgKzgzNiwxMyBAQCBhc3RfY3J0Y19oZWxwZXJfYXRv bWljX2VuYWJsZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAlpZiAoV0FSTl9PTl9PTkNFKCFz dWNjKSkKPiAgCQlyZXR1cm47Cj4gIAo+ICsJLyoKPiArCSAqIFRPRE86IFNvbWUgb2YgdGhlIHJl Z2lzdGVycycgdmFsdWVzIGRlcGVuZCBvbiB0aGUgZnJhbWVidWZmZXIKPiArCSAqICAgICAgIGNv bmZpZ3VyYXRpb24uIFRvIHJlc29sdmUgdGhpcywgZnVsbHkgc2VwYXJhdGUgdGhlIG1vZGUKPiAr CSAqCSBzZXR0aW5nIGZyb20gdGhlIGZyYW1lYnVmZmVyIHVwZGF0ZS4gVGhlIHZiaW9zIG1vZGUg aW5mbwo+ICsJICogICAgICAgc2hvdWxkIGJlIGdhdGhlcmVkIGJ5IGF0b21pY19jaGVjaywgdGhl IGZyYW1lYnVmZmVyIHJlZ3MKPiArCSAqICAgICAgIHNob3VsZCBiZSBzZXQgaW4gcHJpbWFyeSBw bGFuZSdzIHVwZGF0ZSBmdW5jdGlvbi4KPiArCSAqLwo+ICAJYXN0X3NldF92Ymlvc19tb2RlX3Jl ZyhjcnRjLCAmYWRqdXN0ZWRfbW9kZSwgJnZiaW9zX21vZGUpOwo+ICAJYXN0X3NldF9pbmRleF9y ZWcoYXN0LCBBU1RfSU9fQ1JUQ19QT1JULCAweGExLCAweDA2KTsKPiAgCWFzdF9zZXRfc3RkX3Jl ZyhjcnRjLCAmYWRqdXN0ZWRfbW9kZSwgJnZiaW9zX21vZGUpOwo+IC0tIAo+IDIuMjMuMAo+IAoK LS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0 dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbA==