Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76E3AC432C3 for ; Sat, 16 Nov 2019 16:06:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E67F206C0 for ; Sat, 16 Nov 2019 16:06:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="5bwICsIV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729233AbfKPQGq (ORCPT ); Sat, 16 Nov 2019 11:06:46 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:42916 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731755AbfKPQGn (ORCPT ); Sat, 16 Nov 2019 11:06:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dDvq4hjwRLkHy9iSXQNS5lcXEmes4uzOMftkB6Mwr+c=; b=5bwICsIVqPkawy7/Z7/C/+1bQL 1fogwvVD9YwYi6AjWODtH1/2gU6cDbeT+6bVNn16/sr1eOznTuLSOceKEEeTlbiNZvfsyUJEUZM1x wh0cC5MH9srBxefJctqD93PpK0990qm+S1VWBX/OonC8W4PMtcr1UYc4/YI0CSNfOScg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iW0ap-0005qI-8Y; Sat, 16 Nov 2019 17:06:35 +0100 Date: Sat, 16 Nov 2019 17:06:35 +0100 From: Andrew Lunn To: Russell King Cc: Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 3/3] net: phy: marvell10g: add SFP+ support Message-ID: <20191116160635.GB5653@lunn.ch> References: <20191115195339.GR25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > +static int mv3310_sfp_insert(void *upstream, const struct sfp_eeprom_id *id) > +{ > + struct phy_device *phydev = upstream; > + __ETHTOOL_DECLARE_LINK_MODE_MASK(support) = { 0, }; > + phy_interface_t iface; > + > + sfp_parse_support(phydev->sfp_bus, id, support); > + iface = sfp_select_interface(phydev->sfp_bus, id, support); > + > + if (iface != PHY_INTERFACE_MODE_10GKR) { > + dev_err(&phydev->mdio.dev, "incompatible SFP module inserted\n"); > + return -EINVAL; > + } Hi Russell Is it possible to put an SFP module into an SFP+ cage? sfp_select_interface() would then say 1000Base-X or 2500Base-X. The SFP+ cage has a single SERDES pair, so electrically, would it be possible to do 1000Base-X? Should mv3310_sfp_insert() be reconfiguring the PHY so the SFP side swaps to 1000Base-X? Andrew