From: Maxime Ripard Subject: Re: [PATCH v2 10/13] drm/modes: parse_cmdline: Remove some unnecessary code (v2) Date: Mon, 18 Nov 2019 13:25:12 +0100 Message-ID: <20191118122512.GG4345@gilmour.lan> References: <20191113164434.254159-1-hdegoede@redhat.com> <20191113164434.254159-10-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0923868477==" Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29D686E4AE for ; Mon, 18 Nov 2019 12:25:15 +0000 (UTC) In-Reply-To: <20191113164434.254159-10-hdegoede@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans de Goede Cc: David Airlie , Derek Basehore , dri-devel@lists.freedesktop.org, Sean Paul , Daniel Vetter , Mathieu =?iso-8859-1?Q?Alexandre-T=E9treault?= List-Id: dri-devel@lists.freedesktop.org --===============0923868477== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GXT8AkipAZwA99QD" Content-Disposition: inline --GXT8AkipAZwA99QD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 13, 2019 at 05:44:31PM +0100, Hans de Goede wrote: > fb_get_options() will return fb_mode_option if no video= > argument is present on the kernel commandline, so there is no need to also > do this in drm_mode_parse_command_line_for_connector() as our only caller > uses fb_get_options() to get the mode_option argument. > > Changes in v2: > -Split out the changes dealing with the initialization of the mode struct > into a separate patch > > Signed-off-by: Hans de Goede Acked-by: Maxime Ripard --GXT8AkipAZwA99QD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXdKNqAAKCRDj7w1vZxhR xaqSAP4gER/CB6XS9aJzWcARzi/7kgyEPQdUwV+aefmfa0FykwEAmAJoXdI+2m5W N3s679q8wPTAKCM4TXFy6OmLF8JR6wY= =ukPv -----END PGP SIGNATURE----- --GXT8AkipAZwA99QD-- --===============0923868477== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0923868477==--