From: Maxime Ripard Subject: Re: [PATCH v2 09/13] drm/modes: parse_cmdline: Add support for specifying panel_orientation (v2) Date: Mon, 18 Nov 2019 13:25:57 +0100 Message-ID: <20191118122557.GI4345@gilmour.lan> References: <20191113164434.254159-1-hdegoede@redhat.com> <20191113164434.254159-9-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1620992091==" Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5FBD06E4CB for ; Mon, 18 Nov 2019 12:26:00 +0000 (UTC) In-Reply-To: <20191113164434.254159-9-hdegoede@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans de Goede Cc: David Airlie , Derek Basehore , dri-devel@lists.freedesktop.org, Sean Paul , Daniel Vetter , Mathieu =?iso-8859-1?Q?Alexandre-T=E9treault?= List-Id: dri-devel@lists.freedesktop.org --===============1620992091== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kvWJmX0bB3Sab/3X" Content-Disposition: inline --kvWJmX0bB3Sab/3X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 13, 2019 at 05:44:30PM +0100, Hans de Goede wrote: > Sometimes we want to override a connector's panel_orientation from the > kernel commandline. Either for testing and for special cases, e.g. a kiosk > like setup which uses a TV mounted in portrait mode. > > Users can already specify a "rotate" option through a video= kernel cmdline > option. But that only supports 0/180 degrees (see drm_client_modeset TODO) > and only works for in kernel modeset clients, not for userspace kms users. > > The "panel-orientation" connector property OTOH does support 90/270 degrees > as it leaves dealing with the rotation up to userspace and this does work > for userspace kms clients (at least those which support this property). > > Changes in v2: > -Add missing ':' after @panel_orientation (reported by kbuild test robot) > > BugLink: https://gitlab.freedesktop.org/plymouth/plymouth/merge_requests/83 > Signed-off-by: Hans de Goede Acked-by: Maxime Ripard Maxime --kvWJmX0bB3Sab/3X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXdKN1QAKCRDj7w1vZxhR xWYzAP9swi3Ck5m39PW81GIQcLneKM6b6W6P2ttPWSa7Zj6ONQD/bKTE29elYmKj qBV37OFTj3w2AnLbcULyDanX9fnJkwY= =t6kD -----END PGP SIGNATURE----- --kvWJmX0bB3Sab/3X-- --===============1620992091== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1620992091==--