From: Daniel Vetter Subject: Re: [PATCH v2] drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap Date: Mon, 18 Nov 2019 17:49:27 +0100 Message-ID: <20191118164927.GF23790@phenom.ffwll.local> References: <20191112144435.GK23790@phenom.ffwll.local> <20191113073902.343vfunbjuzy725y@sirius.home.kraxel.org> <20191113135145.itdsbojzrj5elzvu@sirius.home.kraxel.org> <20191113162729.GQ23790@phenom.ffwll.local> <20191115093738.kdi4qopah6hvntrb@sirius.home.kraxel.org> <20191115105601.i7ahtapysv4j7mn7@sirius.home.kraxel.org> <20191118104026.zg5pt5yg2wkulmrr@sirius.home.kraxel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2EEFE6E69C for ; Mon, 18 Nov 2019 16:49:31 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id z10so20321753wrs.12 for ; Mon, 18 Nov 2019 08:49:31 -0800 (PST) Content-Disposition: inline In-Reply-To: <20191118104026.zg5pt5yg2wkulmrr@sirius.home.kraxel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: dri-devel , Thomas Zimmermann List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBOb3YgMTgsIDIwMTkgYXQgMTE6NDA6MjZBTSArMDEwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiAgIEhpLAo+IAo+ID4gPiA+ID4gSXMgYW55IG1vdmUgYnVmZmVyIGdvb2QgZW5vdWdo IHRvIHRyaWdnZXIgdGhpcywgaS5lLiB3aWxsIFNZU1RFTSAtPiBWUkFNCj4gPiA+ID4gPiB3b3Jr IHRvbz8gIFRoYXQnbGwgYmUgZWFzaWVyIGJlY2F1c2UgYWxsIEkgbmVlZCB0byBkbyBpcyBtYXAg dGhlIGJ1ZmZlcgo+ID4gPiA+ID4gdG8gYSBjcnRjIHRvIGZvcmNlIHBpbm5pbmcgdG8gdnJhbSwg dGhlbiBjaGVjayBpZiB0aGUgbWFwcGluZ3MgYXJlCj4gPiA+ID4gPiBpbnRhY3Qgc3RpbGwgLi4u Cj4gPiA+ID4KPiA+ID4gPiBJIHRoaW5rIHRoYXQgc2hvdWxkIHdvcmsgdG9vLgo+ID4gPgo+ID4g PiBTZWVtcyB0byB3b3JrIG9rIGZvciB0dG0vdnJhbS4KPiA+ID4KPiA+ID4gVGVzdCBjb2RlOgo+ ID4gPiAgIGh0dHBzOi8vZ2l0LmtyYXhlbC5vcmcvY2dpdC9kcm1pbmZvL2NvbW1pdC8/aWQ9YTll Yjk2NTA0ZGMxNzM3NmUwN2I1YzZlZGY1Mjk2YjQxYTQ4YmJmZQo+ID4gCj4gPiBJIHRoaW5rIHRo YXQncyBub3QgbmFzdHkgZW5vdWdoLiBJZiB0aGUgbWFwcGluZ3MgYXJlbid0IHVwZGF0ZWQsIHRo ZW4KPiA+IHlvdSdsbCBzdGlsbCBzZWUgdGhlIHRoZSBzYW1lIG9sZCBwYWdlcyB3aXRoIHRoZSBy aWdodCBjb250ZW50cy4gWW91Cj4gPiBuZWVkIHRvIGNoYW5nZSB0aGVtIHNvbWVob3cgYWZ0ZXIg dGhleSBtaWdyYXRlZCAod2l0aCB2cmFtIGV2aWN0aW9uCj4gPiB0aGF0IGhhcHBlbnMgYXV0b21h dGljYWxseSBzaW5jZSB0aGVyZSdsbCBiIGFub3RoZXIgb2JqZWN0IGluIHRoZSBzYW1lCj4gPiBz cG90LCBmb3Igc3lzdGVtIG1lbW9yeSBJIHRoaW5rIHlvdSBuZWVkIHRoZSBzaHJpbmtlciB0byBr aWNrIGluIGFuZAo+ID4gZnJlZSB0aGUgcGFnZXMgZmlyc3QpLiBFYXNpZXN0IHByb2JhYmx5IHRv IHdhaXQgZm9yIGEga2V5IHByZXNzIHNvIHlvdQo+ID4gY2FuIGFwcHJlY2lhdGUgdGhlIGNvbG9y LCB0aGVuIHdyaXRlIGEgZGlmZmVyZW50IGNvbG9yIChmdWxsIHNjcmVlbikKPiA+IHdoZW4gdGhl IGJ1ZmZlciBpcyBpbiB2cmFtLgo+IAo+IHVwZGF0ZS1vYmplY3QtYWZ0ZXItbW92ZSB3b3JrcyBm aW5lLgo+IAo+IHRyeSB6YXAgbWFwcGluZ3Mgd2l0aCBtYWR2aXNlKGRvbnRuZWVkKSBoYXMgbm8g YmFkIGVmZmVjdHMgKGFmdGVyIHZyYW0KPiBtb3ZlLCB0cnlpbmcgdG8gZm9yY2UgcmUtY3JlYXRp bmcgdGhlIHB0ZXMpLgoKV2VsbCBpZiBpdCdzIGJyb2tlbiB0aGUgemFwcGluZyB3b3VsZG4ndCB3 b3JrIDotKQoKPiBkaWRuJ3QgdHJ5IHRoZSBtZW1vcnkgcHJlc3N1cmUgdGhpbmcgeWV0LgoKSSdt IHN1cnByaXNlZCAuLi4gYW5kIEkgaGF2ZSBubyBpZGVhIGhvdy93aHkgaXQga2VlcHMgd29ya2lu Zy4KCkZvciBteSBwYXJhbm9pYSwgY2FuIHlvdSBpbnN0cnVtZW50IHRoZSB0dG0gcGFnZSBmYXVs dCBoYW5kbGVyLCBhbmQgZG91YmxlCmNoZWNrIHRoYXQgd2UgZ2V0IG5ldyBmYXVsdHMgYWZ0ZXIg dGhlIG1vdmUsIGFuZCBzZXQgdXAgbmV3IHB0ZXMgZm9yIHRoZQpzYW1lIG9sZCBtYXBwaW5nLCBi dXQgbm93IHBvaW50aW5nIGF0IHRoZSBuZXcgcGxhY2UgaW4gdnJhbT8KCj4gPiBZb3UnZCBuZWVk IHRvIGNoZWNrIHRoZSBwdGVzIHRoZW1zZWx2ZXMuIFdoaWNoIEkgdGhpbmsgbm90IGV2ZW4gcHJv Ywo+ID4gc2hvd3MgYnkgZGVmYXVsdCAob25seSB0aGUgZmlsZSB0aGF0J3Mgc3VwcG9zZWQgdG8g YmUgbWFwcGVkKS4gQnV0Cj4gPiBnb29kIHRvIGNvbmZpcm0gdGhhdCB0aGUgYnVmZmVyIG1vdmVk IGF0IGxlYXN0Lgo+IAo+IE9uZSByZXByb2R1Y2FibGUgZ2xpdGNoIGZvdW5kOiAgZm9yaygpIHdo aWxlIGhhdmluZyBhIGRtYS1idWYgbWFwcGVkCj4gdHJpZ2dlcnMgdGhlIFdBUk5fT04gaW4gdHRt X2JvX3ZtX29wZW4oKS4gIEJvdGggb2xkICYgbmV3IG1tYXAgY29kZQo+IHBhdGhzLCBzbyB0aGlz IGlzbid0IHNvbWV0aGluZyBuZXcgY29taW5nIGZyb20gdGhlCj4gZHJtX2dlbV9vYmplY3RfZnVu Y3MubW1hcCBzd2l0Y2guICBJbnN0ZWFkIGl0IGlzIGFuIG9sZCBpc3N1ZSBjb21pbmcKPiBmcm9t IHRoZSBhZGRyZXNzIHNwYWNlIGhhbmRsaW5nIGJlaW5nIGRpZmZlcmVudCBpbiBkcm0gbW1hcCBh bmQgZG1hYnVmCj4gbW1hcCBjb2RlIHBhdGhzLgo+IAo+IEkgY2FuIHNlZSBub3cgd2h5IHlvdSB3 YW50IGEgcHJpdmF0ZSBhZGRyZXNzIHNwYWNlIGZvciBlYWNoIG9iamVjdC4KPiBEb2VzIHRoYXQg aW1wbHkgd2UgbmVlZCBhbiBhbm9uX2lub2RlIGZvciBlYWNoIGdlbSBvYmplY3Q/ICBPciBpcwo+ IHRoZXJlIHNvbWUgbW9yZSBsaWdodHdlaWdodCB3YXkgdG8gZG8gdGhpcz8KCkkgaGF2ZSBubyBp ZGVhIHdoZXRoZXIgd2UgY2FuIGdldCBhIGFkZHJlc3Nfc3BhY2Ugc3RydWN0IHdpdGhvdXQgYW4g aW5vZGUKKGFuZCBubyBkaXNhc3RlcnMpLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3 YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=