From: Maxime Ripard Subject: Re: [PATCH v3 11/13] drm/modes: parse_cmdline: Explicitly memset the passed in drm_cmdline_mode struct Date: Mon, 18 Nov 2019 17:56:39 +0100 Message-ID: <20191118165639.GR4345@gilmour.lan> References: <20191118155134.30468-1-hdegoede@redhat.com> <20191118155134.30468-11-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1406198569==" Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8ACC689167 for ; Mon, 18 Nov 2019 16:56:43 +0000 (UTC) In-Reply-To: <20191118155134.30468-11-hdegoede@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans de Goede Cc: David Airlie , Derek Basehore , Sean Paul , dri-devel@lists.freedesktop.org, Daniel Vetter , Mathieu =?iso-8859-1?Q?Alexandre-T=E9treault?= List-Id: dri-devel@lists.freedesktop.org --===============1406198569== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BF73NQnaRilDmNOH" Content-Disposition: inline --BF73NQnaRilDmNOH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 18, 2019 at 04:51:32PM +0100, Hans de Goede wrote: > Instead of only setting mode->specified on false on an early exit and > leaving e.g. mode->bpp_specified and mode->refresh_specified as is, > lets be consistent and just zero out the entire passed in struct at > the top of drm_mode_parse_command_line_for_connector() > > Changes in v3: > -Drop "mode->specified = false;" line instead of the "return false;" (oops) > This crasher was reported-by: kernel test robot > > Signed-off-by: Hans de Goede Acked-by: Maxime Ripard Thanks! Maxime --BF73NQnaRilDmNOH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXdLNRwAKCRDj7w1vZxhR xQk1AP9XtVqOhNcTiaQxip6sZP71nBRozV9vdpHbK2EYlQUE5QD9E5jG7lAInqW0 SHEUcKaSUL7bHPydlDb95yu6iJuOBwg= =6vLm -----END PGP SIGNATURE----- --BF73NQnaRilDmNOH-- --===============1406198569== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1406198569==--