From: Tom Rini Date: Tue, 19 Nov 2019 19:46:32 -0500 Subject: [U-Boot] [PATCH v4 09/42] spl: bootcount: Move code out of header file In-Reply-To: <20191114195751.30357-2-sjg@chromium.org> References: <20191114195751.30357-1-sjg@chromium.org> <20191114195751.30357-2-sjg@chromium.org> Message-ID: <20191120004632.GU19317@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Nov 14, 2019 at 12:57:17PM -0700, Simon Glass wrote: > It is not good practice to write code in a header file. If it is included > multiple times then the code can cause duplicate functions. > > Move the bootcount_store() and bootcount_load() functions into SPL. > > Note: bootcount is a bit strange in that it uses driver model but does not > define proper drivers. This should be fixed. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: