Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44DD1C43141 for ; Thu, 21 Nov 2019 03:20:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F70E20898 for ; Thu, 21 Nov 2019 03:20:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="O/wA9wtY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727085AbfKUDTO (ORCPT ); Wed, 20 Nov 2019 22:19:14 -0500 Received: from mail-yw1-f73.google.com ([209.85.161.73]:37584 "EHLO mail-yw1-f73.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726574AbfKUDTN (ORCPT ); Wed, 20 Nov 2019 22:19:13 -0500 Received: by mail-yw1-f73.google.com with SMTP id 12so1203048ywr.4 for ; Wed, 20 Nov 2019 19:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=649w9NPZH4a33tdCKHIJx9A/bxLeL3sF3iibuigtKuY=; b=O/wA9wtYYLYwbqmDxABd+k6vcQFy4NvSTAj3DRniuP9y+gcOyL1B0wgO2X0VXe4Ot9 prwoWQWA7sjNkVfltoFXc6Uyp16bSjptnGBcyCYNsMh3wND/0+V52GYYKPzNSe4itibh t9jymMzhiRHwHrGTGtP+C5hkLkMM2QkajCH23POldiIyjbZfohqg0OrgIpHiiikA9J7G rBFauVuDLTIEyN4ocjEYmMrZcHj6nY+gtkB2xyKOtwdgUA2gxC6ugjov5VDv6j/SFFeH HQTYzpiYPCqzfy+roaSLPo5I3UWOwhUguXEvcXOc0rrpNpEfC0zxgQL5yin9J/cF9ReH xfjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=649w9NPZH4a33tdCKHIJx9A/bxLeL3sF3iibuigtKuY=; b=P5aaIhSp8WZaPE7vtazLEo+cBEZ1N3HyvinKA4KrYdEhSoDFObY3WVgnXac9xHAjHd Z3WsOg7WZLNdzKPYW3aV9Cgd48nGo9cb3FTuImdKK23k9WV+DJj1GorcPLyDDd02rLj6 9DN2Ygkl8KYh9/4TXBScKOxqfki3ivftKFcnjnrNZlKmRaZyv+BRueDDP9x4VACac1Im HZ7kSb1WU6dcY04bL98kvHm/M+SOZOc9c0sXkwwPMPaoCixf1IQAcBawVGhASEXVIvNR 7jUM6XkZ2gGHXxjypF0NQFkpKaRoAwGqsfoMD4cfMGxrFdtA6fM1fpStXFyeErlXDzSa bpjQ== X-Gm-Message-State: APjAAAXkABwdgDbNWKpSzNB23x606oU6pe2YZGYDqqoCBxdYCGByEtMj whb6P/10iKn1zrbHrTcVntS06ztOXtsXrQ== X-Google-Smtp-Source: APXvYqzg5cJGb9m3qBSM+FWaPbPvQ8G4Yp0gmo8/vXvHgf1vyhrmBDrIdzmeEJoK6l2ssvkkEsaEyfwBdAFTGA== X-Received: by 2002:a0d:d692:: with SMTP id y140mr4216855ywd.151.1574306351280; Wed, 20 Nov 2019 19:19:11 -0800 (PST) Date: Wed, 20 Nov 2019 19:19:07 -0800 Message-Id: <20191121031907.159416-1-edumazet@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.24.0.432.g9d3f5f5b63-goog Subject: [PATCH net] net-sysfs: fix netdev_queue_add_kobject() breakage From: Eric Dumazet To: "David S . Miller" Cc: netdev , Eric Dumazet , Eric Dumazet , Jouni Hogander Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org kobject_put() should only be called in error path. Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject") Signed-off-by: Eric Dumazet Cc: Jouni Hogander --- net/core/net-sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 4f404bf33e44c977c1a8ba00706817b76215b75c..ae3bcb1540ec57df311dac6847323a23a74ec960 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -1474,6 +1474,7 @@ static int netdev_queue_add_kobject(struct net_device *dev, int index) #endif kobject_uevent(kobj, KOBJ_ADD); + return 0; err: kobject_put(kobj); -- 2.24.0.432.g9d3f5f5b63-goog