From: Daniel Vetter Subject: Re: [PATCH 1/2] drm: call drm_gem_object_funcs.mmap with fake offset Date: Thu, 21 Nov 2019 14:52:59 +0100 Message-ID: <20191121135259.GE6236@phenom.ffwll.local> References: <20191121103807.18424-1-kraxel@redhat.com> <20191121103807.18424-2-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20191121103807.18424-2-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Gerd Hoffmann , Rob Herring Cc: David Airlie , intel-gfx@lists.freedesktop.org, open list , Maxime Ripard , Huang Rui , dri-devel@lists.freedesktop.org, Christian Koenig List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBOb3YgMjEsIDIwMTkgYXQgMTE6Mzg6MDZBTSArMDEwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiBUaGUgZmFrZSBvZmZzZXQgaXMgZ29pbmcgdG8gc3RheSwgc28gY2hhbmdlIHRoZSBj YWxsaW5nIGNvbnZlbnRpb24gZm9yCj4gZHJtX2dlbV9vYmplY3RfZnVuY3MubW1hcCB0byBpbmNs dWRlIHRoZSBmYWtlIG9mZnNldC4gIFVwZGF0ZSBhbGwgdXNlcnMKPiBhY2NvcmRpbmdseS4KClBs ZWFzZSBhZGQgdG8gdGhlIGNvbW1pdCBtZXNzYWdlOgoKTm90ZSB0aGF0IHRoaXMgcmV2ZXJ0cyA4 M2I4YTZmMjQyZWEgKCJkcm0vZ2VtOiBGaXggbW1hcCBmYWtlIG9mZnNldApoYW5kbGluZyBmb3Ig ZHJtX2dlbV9vYmplY3RfZnVuY3MubW1hcCIpIGFuZCBvbiB0b3AgdGhlbiBhZGRzIHRoZSBmYWtl Cm9mZnNldCB0byAgZHJtX2dlbV9wcmltZV9tbWFwIHRvIG1ha2Ugc3VyZSBhbGwgcGF0aHMgbGVh ZGluZyB0bwpvYmotPmZ1bmNzLT5tbWFwIGFyZSBjb25zaXN0ZW50LgoKRml4ZXM6IDgzYjhhNmYy NDJlYSAoImRybS9nZW06IEZpeCBtbWFwIGZha2Ugb2Zmc2V0IGhhbmRsaW5nIGZvciBkcm1fZ2Vt X29iamVjdF9mdW5jcy5tbWFwIikKQ2M6IEdlcmQgSG9mZm1hbm4gPGtyYXhlbEByZWRoYXQuY29t PgpDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KQ2M6IFJvYiBIZXJy aW5nIDxyb2JoQGtlcm5lbC5vcmc+CgpXaXRoIHRoYXQgYWxzbyBSZXZpZXdlZC1ieTogRGFuaWVs IFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KLURhbmllbAo+IAo+IFNpZ25lZC1vZmYt Ynk6IEdlcmQgSG9mZm1hbm4gPGtyYXhlbEByZWRoYXQuY29tPgo+IC0tLQo+ICBpbmNsdWRlL2Ry bS9kcm1fZ2VtLmggICAgICAgICAgICAgICAgICB8IDQgKy0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v ZHJtX2dlbS5jICAgICAgICAgICAgICB8IDMgLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZ2Vt X3NobWVtX2hlbHBlci5jIHwgMyArKysKPiAgZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5jICAg ICAgICAgICAgfCAzICsrKwo+ICBkcml2ZXJzL2dwdS9kcm0vdHRtL3R0bV9ib192bS5jICAgICAg ICB8IDcgLS0tLS0tLQo+ICA1IGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMTMgZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9nZW0uaCBiL2luY2x1 ZGUvZHJtL2RybV9nZW0uaAo+IGluZGV4IDk3YTQ4MTY1NjQyYy4uMGIzNzUwNjljZDQ4IDEwMDY0 NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9nZW0uaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9n ZW0uaAo+IEBAIC0xNTksOSArMTU5LDcgQEAgc3RydWN0IGRybV9nZW1fb2JqZWN0X2Z1bmNzIHsK PiAgCSAqCj4gIAkgKiBUaGUgY2FsbGJhY2sgaXMgdXNlZCBieSBieSBib3RoIGRybV9nZW1fbW1h cF9vYmooKSBhbmQKPiAgCSAqIGRybV9nZW1fcHJpbWVfbW1hcCgpLiAgV2hlbiBAbW1hcCBpcyBw cmVzZW50IEB2bV9vcHMgaXMgbm90Cj4gLQkgKiB1c2VkLCB0aGUgQG1tYXAgY2FsbGJhY2sgbXVz dCBzZXQgdm1hLT52bV9vcHMgaW5zdGVhZC4gVGhlIEBtbWFwCj4gLQkgKiBjYWxsYmFjayBpcyBh bHdheXMgY2FsbGVkIHdpdGggYSAwIG9mZnNldC4gVGhlIGNhbGxlciB3aWxsIHJlbW92ZQo+IC0J ICogdGhlIGZha2Ugb2Zmc2V0IGFzIG5lY2Vzc2FyeS4KPiArCSAqIHVzZWQsIHRoZSBAbW1hcCBj YWxsYmFjayBtdXN0IHNldCB2bWEtPnZtX29wcyBpbnN0ZWFkLgo+ICAJICovCj4gIAlpbnQgKCpt bWFwKShzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaiwgc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2 bWEpOwo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9nZW0uYyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiBpbmRleCAyZjJiODg5MDk2YjAuLjU2ZjQyZTBmMjU4NCAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2RybV9nZW0uYwo+IEBAIC0xMTA2LDkgKzExMDYsNiBAQCBpbnQgZHJtX2dlbV9tbWFw X29iaihzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaiwgdW5zaWduZWQgbG9uZyBvYmpfc2l6ZSwK PiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCj4gIAlpZiAob2JqLT5mdW5jcyAmJiBvYmotPmZ1bmNz LT5tbWFwKSB7Cj4gLQkJLyogUmVtb3ZlIHRoZSBmYWtlIG9mZnNldCAqLwo+IC0JCXZtYS0+dm1f cGdvZmYgLT0gZHJtX3ZtYV9ub2RlX3N0YXJ0KCZvYmotPnZtYV9ub2RlKTsKPiAtCj4gIAkJcmV0 ID0gb2JqLT5mdW5jcy0+bW1hcChvYmosIHZtYSk7Cj4gIAkJaWYgKHJldCkKPiAgCQkJcmV0dXJu IHJldDsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fc2htZW1faGVscGVy LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV9zaG1lbV9oZWxwZXIuYwo+IGluZGV4IDA4MTBk M2VmNjk2MS4uYTQyMWEyZWVkNDhhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f Z2VtX3NobWVtX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fc2htZW1f aGVscGVyLmMKPiBAQCAtNTI4LDYgKzUyOCw5IEBAIGludCBkcm1fZ2VtX3NobWVtX21tYXAoc3Ry dWN0IGRybV9nZW1fb2JqZWN0ICpvYmosIHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hKQo+ICAJ c3RydWN0IGRybV9nZW1fc2htZW1fb2JqZWN0ICpzaG1lbTsKPiAgCWludCByZXQ7Cj4gIAo+ICsJ LyogUmVtb3ZlIHRoZSBmYWtlIG9mZnNldCAqLwo+ICsJdm1hLT52bV9wZ29mZiAtPSBkcm1fdm1h X25vZGVfc3RhcnQoJm9iai0+dm1hX25vZGUpOwo+ICsKPiAgCXNobWVtID0gdG9fZHJtX2dlbV9z aG1lbV9vYmoob2JqKTsKPiAgCj4gIAlyZXQgPSBkcm1fZ2VtX3NobWVtX2dldF9wYWdlcyhzaG1l bSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJpbWUuYyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fcHJpbWUuYwo+IGluZGV4IDA4MTQyMTFiMGYzZi4uYTk2MzNiZDI0MWJiIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJpbWUuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fcHJpbWUuYwo+IEBAIC03MTQsNiArNzE0LDkgQEAgaW50IGRybV9nZW1fcHJp bWVfbW1hcChzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaiwgc3RydWN0IHZtX2FyZWFfc3RydWN0 ICp2bWEpCj4gIAlpbnQgcmV0Owo+ICAKPiAgCWlmIChvYmotPmZ1bmNzICYmIG9iai0+ZnVuY3Mt Pm1tYXApIHsKPiArCQkvKiBBZGQgdGhlIGZha2Ugb2Zmc2V0ICovCj4gKwkJdm1hLT52bV9wZ29m ZiArPSBkcm1fdm1hX25vZGVfc3RhcnQoJm9iai0+dm1hX25vZGUpOwo+ICsKPiAgCQlyZXQgPSBv YmotPmZ1bmNzLT5tbWFwKG9iaiwgdm1hKTsKPiAgCQlpZiAocmV0KQo+ICAJCQlyZXR1cm4gcmV0 Owo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdHRtL3R0bV9ib192bS5jIGIvZHJpdmVy cy9ncHUvZHJtL3R0bS90dG1fYm9fdm0uYwo+IGluZGV4IGU2NDk1Y2EyNjMwYi4uM2U4YzNkZTkx YWU0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS90dG0vdHRtX2JvX3ZtLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vdHRtL3R0bV9ib192bS5jCj4gQEAgLTUxNCwxMyArNTE0LDYgQEAg RVhQT1JUX1NZTUJPTCh0dG1fYm9fbW1hcCk7Cj4gIGludCB0dG1fYm9fbW1hcF9vYmooc3RydWN0 IHZtX2FyZWFfc3RydWN0ICp2bWEsIHN0cnVjdCB0dG1fYnVmZmVyX29iamVjdCAqYm8pCj4gIHsK PiAgCXR0bV9ib19nZXQoYm8pOwo+IC0KPiAtCS8qCj4gLQkgKiBGSVhNRTogJmRybV9nZW1fb2Jq ZWN0X2Z1bmNzLm1tYXAgaXMgY2FsbGVkIHdpdGggdGhlIGZha2Ugb2Zmc2V0Cj4gLQkgKiByZW1v dmVkLiBBZGQgaXQgYmFjayBoZXJlIHVudGlsIHRoZSByZXN0IG9mIFRUTSB3b3JrcyB3aXRob3V0 IGl0Lgo+IC0JICovCj4gLQl2bWEtPnZtX3Bnb2ZmICs9IGRybV92bWFfbm9kZV9zdGFydCgmYm8t PmJhc2Uudm1hX25vZGUpOwo+IC0KPiAgCXR0bV9ib19tbWFwX3ZtYV9zZXR1cChibywgdm1hKTsK PiAgCXJldHVybiAwOwo+ICB9Cj4gLS0gCj4gMi4xOC4xCj4gCgotLSAKRGFuaWVsIFZldHRlcgpT b2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4