Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 158C9C432C0 for ; Thu, 21 Nov 2019 17:15:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7933206CC for ; Thu, 21 Nov 2019 17:15:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726765AbfKURPu (ORCPT ); Thu, 21 Nov 2019 12:15:50 -0500 Received: from mx2.suse.de ([195.135.220.15]:55688 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726546AbfKURPu (ORCPT ); Thu, 21 Nov 2019 12:15:50 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D5D85B15A; Thu, 21 Nov 2019 17:15:48 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 4DD471E484C; Thu, 21 Nov 2019 18:15:47 +0100 (CET) Date: Thu, 21 Nov 2019 18:15:47 +0100 From: Jan Kara To: "Darrick J. Wong" Cc: Jan Kara , linux-fsdevel@vger.kernel.org, Christoph Hellwig , Matthew Bobrowski , Eric Biggers Subject: Re: [PATCH 0/2] iomap: Fix leakage of pipe pages while splicing Message-ID: <20191121171547.GE18158@quack2.suse.cz> References: <20191121161144.30802-1-jack@suse.cz> <20191121165829.GK6211@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191121165829.GK6211@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu 21-11-19 08:58:29, Darrick J. Wong wrote: > On Thu, Nov 21, 2019 at 05:15:33PM +0100, Jan Kara wrote: > > Hello, > > > > here is a fix and a cleanup for iomap code. The first patch fixes a leakage > > of pipe pages when iomap_dio_rw() splices to a pipe, the second patch is > > a cleanup that removes strange copying of iter in iomap_dio_rw(). Patches > > have passed fstests for ext4 and xfs and fix the syzkaller reproducer for > > me. > > Will have a look, but in the meantime -- do you have quick reproducer > that can be packaged for fstests? Or is it just the syzbot reproducer? I have just the syzkaller reproducer but now that I understand the problem I might be able to write something more readable... I'll try. Honza -- Jan Kara SUSE Labs, CR