From: Al Viro Subject: Re: [PATCH v17 00/13] open: introduce openat2(2) syscall Date: Mon, 25 Nov 2019 00:39:09 +0000 Message-ID: <20191125003909.GH4203@ZenIV.linux.org.uk> References: <20191117011713.13032-1-cyphar@cyphar.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20191117011713.13032-1-cyphar@cyphar.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Aleksa Sarai Cc: Song Liu , linux-ia64@vger.kernel.org, linux-doc@vger.kernel.org, Peter Zijlstra , Rasmus Villemoes , Alexei Starovoitov , linux-kernel@vger.kernel.org, David Howells , linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, containers@lists.linux-foundation.org, linux-api@vger.kernel.org, Shuah Khan , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Tycho Andersen , Daniel Borkmann , Jonathan Corbet , Jiri Olsa , linux-sh@vger.kernel.org, Alexander Shishkin , Ingo Molnar , linux-arm-kernel@lists.infradead.org, Yonghong Song , linux-mips@vger.kernel.org, Andrii Nakryiko , bpf@vger.ke Generally I can live with that - the only serious issue is with that WARN_ON() and the logics of the check in it.