From: Thomas Zimmermann Subject: [PATCH v2] drm/ast: Fix potential NULL-pointer read during atomic mode setting Date: Wed, 27 Nov 2019 08:31:09 +0100 Message-ID: <20191127073109.9807-1-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8844E6E0E1 for ; Wed, 27 Nov 2019 07:31:15 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: kraxel@redhat.com, airlied@redhat.com, daniel.vetter@ffwll.ch, yc_chen@aspeedtech.com, sam@ravnborg.org Cc: Thomas Zimmermann , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org V2hlbiBlbmFibGluZyB0aGUgQ1JUQyBhZnRlciB3YWtpbmcgdXAgZnJvbSBhIHBvd2VyLXNhdmlu ZyBtb2RlLCB0aGUKcHJpbWFyeSBwbGFuZSdzIGZyYW1lYnVmZmVyIG1pZ2h0IGJlIE5VTEwsIHdo aWNoIGxlYWRzIHRvIGEgc3RhY2sgdHJhY2UKYXMgc2hvd24gYmVsb3cuCgogIFsgIDYzMi42MjQ2 MDhdIEJVRzoga2VybmVsIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSwgYWRkcmVzczogMDAwMDAw MDAwMDAwMDA0OAogIFsgIDYzMi42MjQ2MzFdICNQRjogc3VwZXJ2aXNvciByZWFkIGFjY2VzcyBp biBrZXJuZWwgbW9kZQogIFsgIDYzMi42MjQ2MzldICNQRjogZXJyb3JfY29kZSgweDAwMDApIC0g bm90LXByZXNlbnQgcGFnZQogIFsgIDYzMi42MjQ2NDddIFBHRCAwIFA0RCAwCiAgWyAgNjMyLjYy NDY1NF0gT29wczogMDAwMCBbIzFdIFNNUCBQVEkKICBbICA2MzIuNjI0NjYyXSBDUFU6IDAgUElE OiAyMDgyIENvbW06IGdub21lLXNoZWxsIFRhaW50ZWQ6IEcgICAgICAgICAgICBFICAgICA1LjQu MC1yYzctMS1kZWZhdWx0KyAjMTE0CiAgWyAgNjMyLjYyNDY3M10gSGFyZHdhcmUgbmFtZTogU3Vu IE1pY3Jvc3lzdGVtcyBTVU4gRklSRSBYMjI3MCBNMi9TVU4gRklSRSBYMjI3MCBNMiwgQklPUyAy LjA1ICAgIDA3LzAxLzIwMTAKICBbICA2MzIuNjI0Njg5XSBSSVA6IDAwMTA6YXN0X2NydGNfaGVs cGVyX2F0b21pY19lbmFibGUrMHg3ZC8weDY4MCBbYXN0XQogIFsgIDYzMi42MjQ2OThdIENvZGU6 IDQ4IDhiIDgwIGUwIDAyIDAwIDAwIDRjIDhiIDYwIDEwIDMxIGMwIGYzIDQ4IGFiIDQ4IDhiIDgz IDc4IDA0IDAwIDAwIDRjIDg5IGVmIDQ4IDhkIDcwIDE4IGU4IDlhIGU5IDU1IGNlIDQ4IDhiIDgz IDc4IDA0IDAwIDAwIDw0OT4gOGIgN2MgMjQgNDggNGMgODkgZWEgNGMgOGQgNDQgMjQgMjggNDgg OGQgNGMgMjQgMjAgNDggOGQgNzAgMTgKICBbICA2MzIuNjI0NzE4XSBSU1A6IDAwMTg6ZmZmZmJl OWVjMTIzZmE0MCBFRkxBR1M6IDAwMDEwMjQ2CiAgWyAgNjMyLjYyNDcyNl0gUkFYOiBmZmZmOTVh MTNjZmQzNDAwIFJCWDogZmZmZjk1YTEzY2YzMjAwMCBSQ1g6IDAwMDAwMDAwMDAwMDAwMDAKICBb ICA2MzIuNjI0NzM1XSBSRFg6IDAwMDAwMDAwMDAwMDAwMDAgUlNJOiBmZmZmOTVhMTNjZmQzNGU4 IFJESTogZmZmZmJlOWVjMTIzZmI0MAogIFsgIDYzMi42MjQ3NDRdIFJCUDogZmZmZmJlOWVjMTIz ZmI4MCBSMDg6IDAwMDAwMDAwMDAwMDAwMDAgUjA5OiAwMDAwMDAwMDAwMDAwMDAzCiAgWyAgNjMy LjYyNDc1M10gUjEwOiAwMDAwMDAwMDAwMDAwMDAwIFIxMTogMDAwMDAwMDAwMDAwMDAwMCBSMTI6 IDAwMDAwMDAwMDAwMDAwMDAKICBbICA2MzIuNjI0NzYyXSBSMTM6IGZmZmZiZTllYzEyM2ZhNzAg UjE0OiBmZmZmOTVhMTNiZWI3MDAwIFIxNTogZmZmZjk1YTEzY2YzMjgwMAogIFsgIDYzMi42MjQ3 NzJdIEZTOiAgMDAwMDdmNmQyNzYzZTE0MCgwMDAwKSBHUzpmZmZmOTVhMTM0MDAwMDAwKDAwMDAp IGtubEdTOjAwMDAwMDAwMDAwMDAwMDAKICBbICA2MzIuNjI0NzgyXSBDUzogIDAwMTAgRFM6IDAw MDAgRVM6IDAwMDAgQ1IwOiAwMDAwMDAwMDgwMDUwMDMzCiAgWyAgNjMyLjYyNDc5MF0gQ1IyOiAw MDAwMDAwMDAwMDAwMDQ4IENSMzogMDAwMDAwMDExOTJmODAwNCBDUjQ6IDAwMDAwMDAwMDAwMjA2 ZjAKICBbICA2MzIuNjI0ODAwXSBDYWxsIFRyYWNlOgogIFsgIDYzMi42MjQ4MTFdICA/IF9fbG9j a19hY3F1aXJlKzB4NDA5LzB4N2MwCiAgWyAgNjMyLjYyNDgzMF0gIGRybV9hdG9taWNfaGVscGVy X2NvbW1pdF9tb2Rlc2V0X2VuYWJsZXMrMHgxYWYvMHgyMDAKICBbICA2MzIuNjI0ODQwXSAgZHJt X2F0b21pY19oZWxwZXJfY29tbWl0X3RhaWwrMHgzMi8weDcwCiAgWyAgNjMyLjYyNDg0OV0gIGNv bW1pdF90YWlsKzB4YzcvMHgxMTAKICBbICA2MzIuNjI0ODU3XSAgZHJtX2F0b21pY19oZWxwZXJf Y29tbWl0KzB4MTIxLzB4MTMwCiAgWyAgNjMyLjYyNDg2N10gIGRybV9hdG9taWNfY29ubmVjdG9y X2NvbW1pdF9kcG1zKzB4ZDcvMHgxMDAKICBbICA2MzIuNjI0ODc4XSAgc2V0X3Byb3BlcnR5X2F0 b21pYysweGFmLzB4MTEwCiAgWyAgNjMyLjYyNDg5MF0gIGRybV9tb2RlX29ial9zZXRfcHJvcGVy dHlfaW9jdGwrMHhiYi8weDE5MAogIFsgIDYzMi42MjQ4OTldICA/IGRybV9tb2RlX29ial9maW5k X3Byb3BfaWQrMHg0MC8weDQwCiAgWyAgNjMyLjYyNDkwOV0gIGRybV9pb2N0bF9rZXJuZWwrMHg4 Ni8weGQwCiAgWyAgNjMyLjYyNDkxOF0gIGRybV9pb2N0bCsweDFlNC8weDM2YgogIFsgIDYzMi42 MjQ5MjVdICA/IGRybV9tb2RlX29ial9maW5kX3Byb3BfaWQrMHg0MC8weDQwCiAgWyAgNjMyLjYy NDkzOV0gIGRvX3Zmc19pb2N0bCsweDRiZC8weDZlMAogIFsgIDYzMi42MjQ5NDldICBrc3lzX2lv Y3RsKzB4NWUvMHg5MAogIFsgIDYzMi42MjQ5NTddICBfX3g2NF9zeXNfaW9jdGwrMHgxNi8weDIw CiAgWyAgNjMyLjYyNDk2Nl0gIGRvX3N5c2NhbGxfNjQrMHg1YS8weDIyMAogIFsgIDYzMi42MjQ5 NzZdICBlbnRyeV9TWVNDQUxMXzY0X2FmdGVyX2h3ZnJhbWUrMHg0OS8weGJlCiAgWyAgNjMyLjYy NDk4NF0gUklQOiAwMDMzOjB4N2Y2ZDJiMGRlMzg3CiAgWyAgNjMyLjYyNDk5MV0gQ29kZTogMDAg MDAgOTAgNDggOGIgMDUgZjkgOWEgMGMgMDAgNjQgYzcgMDAgMjYgMDAgMDAgMDAgNDggYzcgYzAg ZmYgZmYgZmYgZmYgYzMgNjYgMmUgMGYgMWYgODQgMDAgMDAgMDAgMDAgMDAgYjggMTAgMDAgMDAg MDAgMGYgMDUgPDQ4PiAzZCAwMSBmMCBmZiBmZiA3MyAwMSBjMyA0OCA4YiAwZCBjOSA5YSAwYyAw MCBmNyBkOCA2NCA4OSAwMSA0OAogIFsgIDYzMi42MjUwMTFdIFJTUDogMDAyYjowMDAwN2ZmZmI0 OWRlZjM4IEVGTEFHUzogMDAwMDAyNDYgT1JJR19SQVg6IDAwMDAwMDAwMDAwMDAwMTAKICBbICA2 MzIuNjI1MDIxXSBSQVg6IGZmZmZmZmZmZmZmZmZmZGEgUkJYOiAwMDAwN2ZmZmI0OWRlZjcwIFJD WDogMDAwMDdmNmQyYjBkZTM4NwogIFsgIDYzMi42MjUwMzBdIFJEWDogMDAwMDdmZmZiNDlkZWY3 MCBSU0k6IDAwMDAwMDAwYzAxODY0YmEgUkRJOiAwMDAwMDAwMDAwMDAwMDA5CiAgWyAgNjMyLjYy NTA0MF0gUkJQOiAwMDAwMDAwMGMwMTg2NGJhIFIwODogMDAwMDAwMDAwMDAwMDAwMCBSMDk6IDAw MDAwMDAwYzBjMGMwYzAKICBbICA2MzIuNjI1MDQ5XSBSMTA6IDAwMDAwMDAwMDAwMDAwMzAgUjEx OiAwMDAwMDAwMDAwMDAwMjQ2IFIxMjogMDAwMDU1YmMzNjdlYjkyMAogIFsgIDYzMi42MjUwNThd IFIxMzogMDAwMDAwMDAwMDAwMDAwOSBSMTQ6IDAwMDAwMDAwMDAwMDAwMDIgUjE1OiAwMDAwMDAw MDAwMDAwMDAwCiAgWyAgNjMyLjYyNTA3MV0gTW9kdWxlcyBsaW5rZWQgaW46IGVidGFibGVfZmls dGVyKEUpIGVidGFibGVzKEUpIGlwNnRhYmxlX2ZpbHRlcihFKSBpcDZfdGFibGVzKEUpIGlwdGFi bGVfZmlsdGVyKEUpIGlwX3RhYmxlcyhFKSB4X3RhYmxlcyhFKSBhZl9wYWNrZXQoRSkgc2NzaV90 cmFuc3BvcnRfaXNjc2koRSkgZG1pX3N5c2ZzKEUpIG1zcihFKSB4ZnMoRSkgaW50ZWxfcG93ZXJj bGFtcChFKSBjb3JldGVtcChFKSBrKQogIFsgIDYzMi42MjUxODVdIENSMjogMDAwMDAwMDAwMDAw MDA0OAoKVGhlIFNUUiBpcwoKICAqIHN0YXJ0IGdkbSBhbmQgd2FpdCBmb3IgaXQgdG8gc3dpdGNo IG9mZiB0aGUgZGlzcGxheQogICogd2FrZSB1cCB0aGUgZGlzcGxheSBieSBwcmVzc2luZyBhIGtl eQoKVGhlIGZpeCBpbXBsZW1lbnRzIGF0b21pY19jaGVjayBmb3IgcGxhbmVzIGFuZCByZWplY3Rz IGNvbmZpZ3VyYXRpb25zCndpdGggYW4gaW52aXNpYmxlIHByaW1hcnkgcGxhbmUuCgp2MjoKCSog ZG8gYW4gYXRvbWljIGNoZWNrIGZvciBwbGFuZQoJKiByZWplY3QgaW52aXNpYmxlIHByaW1hcnkg cGxhbmVzCgpTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgWmltbWVybWFubiA8dHppbW1lcm1hbm5Ac3Vz ZS5kZT4KU3VnZ2VzdGVkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNo PgpGaXhlczogYjQ4ZTFiNmZmZDI4ICgiZHJtL2FzdDogQWRkIENSVEMgaGVscGVycyBmb3IgYXRv bWljIG1vZGVzZXR0aW5nIikKQ2M6IEdlcmQgSG9mZm1hbm4gPGtyYXhlbEByZWRoYXQuY29tPgpD YzogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAcmVkaGF0LmNvbT4KQ2M6IERhbmllbCBWZXR0ZXIgPGRh bmllbC52ZXR0ZXJAZmZ3bGwuY2g+CkNjOiAiWS5DLiBDaGVuIiA8eWNfY2hlbkBhc3BlZWR0ZWNo LmNvbT4KQ2M6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KLS0tCiBkcml2ZXJzL2dw dS9kcm0vYXN0L2FzdF9tb2RlLmMgfCA1MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KystCiAxIGZpbGUgY2hhbmdlZCwgNDkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hc3QvYXN0X21vZGUuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9hc3QvYXN0X21vZGUuYwppbmRleCA0NzI1ZWM5MTFhNjYuLjhlN2JiOGNlODEzMCAxMDA2NDQK LS0tIGEvZHJpdmVycy9ncHUvZHJtL2FzdC9hc3RfbW9kZS5jCisrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9hc3QvYXN0X21vZGUuYwpAQCAtMzEsNiArMzEsNyBAQAogI2luY2x1ZGUgPGxpbnV4L2V4cG9y dC5oPgogI2luY2x1ZGUgPGxpbnV4L3BjaS5oPgoKKyNpbmNsdWRlIDxkcm0vZHJtX2F0b21pYy5o PgogI2luY2x1ZGUgPGRybS9kcm1fYXRvbWljX2hlbHBlci5oPgogI2luY2x1ZGUgPGRybS9kcm1f YXRvbWljX3N0YXRlX2hlbHBlci5oPgogI2luY2x1ZGUgPGRybS9kcm1fY3J0Yy5oPgpAQCAtNTU2 LDYgKzU1NywzMSBAQCBzdGF0aWMgY29uc3QgdWludDMyX3QgYXN0X3ByaW1hcnlfcGxhbmVfZm9y bWF0c1tdID0gewogaW50IGFzdF9wcmltYXJ5X3BsYW5lX2hlbHBlcl9hdG9taWNfY2hlY2soc3Ry dWN0IGRybV9wbGFuZSAqcGxhbmUsCiAJCQkJCSAgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqc3Rh dGUpCiB7CisJc3RydWN0IGRybV9jcnRjICpjcnRjOworCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAq Y3J0Y19zdGF0ZTsKKwlpbnQgcmV0OworCisJaWYgKHN0YXRlLT5jcnRjKQorCQljcnRjID0gc3Rh dGUtPmNydGM7CisJZWxzZSBpZiAocGxhbmUtPnN0YXRlICYmIHBsYW5lLT5zdGF0ZS0+Y3J0YykK KwkJY3J0YyA9IHBsYW5lLT5zdGF0ZS0+Y3J0YzsKKwllbHNlCisJCXJldHVybiAwOyAvKiBkaXNh YmxpbmcgYW4gYWxyZWFkeSBkaXNhYmxlZCBwbGFuZSAqLworCisJY3J0Y19zdGF0ZSA9IGRybV9h dG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKHN0YXRlLT5zdGF0ZSwgY3J0Yyk7CisJaWYgKFdBUk5f T05fT05DRSghY3J0Y19zdGF0ZSkpCisJCXJldHVybiAtRUlOVkFMOyAvKiBCVUc6IG5vIG5ldyBD UlRDIHN0YXRlIGFsbG9jYXRlZCAqLworCisJcmV0ID0gZHJtX2F0b21pY19oZWxwZXJfY2hlY2tf cGxhbmVfc3RhdGUoc3RhdGUsIGNydGNfc3RhdGUsCisJCQkJCQkgIERSTV9QTEFORV9IRUxQRVJf Tk9fU0NBTElORywKKwkJCQkJCSAgRFJNX1BMQU5FX0hFTFBFUl9OT19TQ0FMSU5HLAorCQkJCQkJ ICBmYWxzZSwgdHJ1ZSk7CisJaWYgKHJldCkKKwkJcmV0dXJuIHJldDsKKworCWlmICghc3RhdGUt PnZpc2libGUpCisJCXJldHVybiAtRUlOVkFMOyAvKiBwcmltYXJ5IHBsYW5lIG11c3QgYmUgdmlz aWJsZSAqLworCiAJcmV0dXJuIDA7CiB9CgpAQCAtNTY3LDcgKzU5Myw3IEBAIHZvaWQgYXN0X3By aW1hcnlfcGxhbmVfaGVscGVyX2F0b21pY191cGRhdGUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUs CiAJc3RydWN0IGRybV9nZW1fdnJhbV9vYmplY3QgKmdibzsKIAlzNjQgZ3B1X2FkZHI7CgotCWlm ICghY3J0YyB8fCAhc3RhdGUtPmZiKQorCWlmICghY3J0YyB8fCAhc3RhdGUtPmZiIHx8ICFzdGF0 ZS0+dmlzaWJsZSkKIAkJcmV0dXJuOwoKIAlnYm8gPSBkcm1fZ2VtX3ZyYW1fb2ZfZ2VtKHN0YXRl LT5mYi0+b2JqWzBdKTsKQEAgLTY2MCw2ICs2ODYsMjggQEAgYXN0X2N1cnNvcl9wbGFuZV9oZWxw ZXJfcHJlcGFyZV9mYihzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKIHN0YXRpYyBpbnQgYXN0X2N1 cnNvcl9wbGFuZV9oZWxwZXJfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAog CQkJCQkJc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqc3RhdGUpCiB7CisJc3RydWN0IGRybV9jcnRj ICpjcnRjOworCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKKwlpbnQgcmV0Owor CisJaWYgKHN0YXRlLT5jcnRjKQorCQljcnRjID0gc3RhdGUtPmNydGM7CisJZWxzZSBpZiAocGxh bmUtPnN0YXRlICYmIHBsYW5lLT5zdGF0ZS0+Y3J0YykKKwkJY3J0YyA9IHBsYW5lLT5zdGF0ZS0+ Y3J0YzsKKwllbHNlCisJCXJldHVybiAwOyAvKiBkaXNhYmxpbmcgYW4gYWxyZWFkeSBkaXNhYmxl ZCBwbGFuZSAqLworCisJY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRl KHN0YXRlLT5zdGF0ZSwgY3J0Yyk7CisJaWYgKFdBUk5fT05fT05DRSghY3J0Y19zdGF0ZSkpCisJ CXJldHVybiAtRUlOVkFMOyAvKiBCVUc6IG5vIG5ldyBDUlRDIHN0YXRlIGFsbG9jYXRlZCAqLwor CisJcmV0ID0gZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfcGxhbmVfc3RhdGUoc3RhdGUsIGNydGNf c3RhdGUsCisJCQkJCQkgIERSTV9QTEFORV9IRUxQRVJfTk9fU0NBTElORywKKwkJCQkJCSAgRFJN X1BMQU5FX0hFTFBFUl9OT19TQ0FMSU5HLAorCQkJCQkJICBmYWxzZSwgdHJ1ZSk7CisJaWYgKHJl dCkKKwkJcmV0dXJuIHJldDsKKwogCXJldHVybiAwOwogfQoKLS0KMi4yMy4wCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=