Content-Type: multipart/mixed; boundary="===============8191499396483462188==" MIME-Version: 1.0 From: kbuild test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH net-next v2] drivers: net: virtio_net: Implement a dev_watchdog handler Date: Fri, 29 Nov 2019 03:26:28 +0800 Message-ID: <201911290132.Nwm8mkbr%lkp@intel.com> In-Reply-To: <20191125033959-mutt-send-email-mst@kernel.org> List-Id: --===============8191499396483462188== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi "Michael, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] [cannot apply to net-next/master v5.4 next-20191128] [if your patch is applied to the wrong git tree, please drop us a note to h= elp improve the system. BTW, we also suggest to use '--base' option to specify = the base tree in git format-patch, please see https://stackoverflow.com/a/37406= 982] url: https://github.com/0day-ci/linux/commits/Michael-S-Tsirkin/Re-PATCH= -net-next-v2-drivers-net-virtio_net-Implement-a-dev_watchdog-handler/201911= 25-180545 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 31243= 4617cb16be5166316cf9d08ba760b1042a1 reproduce: # apt-get install sparse # sparse version: v0.6.1-39-gd06e1d2-dirty make ARCH=3Dx86_64 allmodconfig make C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) drivers/net/ethernet/realtek/8139too.c:2246:9: sparse: sparse: incorrect= type in argument 1 (different base types) @@ expected unsigned int [use= rtype] @@ got restrunsigned int [usertype] @@ drivers/net/ethernet/realtek/8139too.c:2246:9: sparse: expected unsig= ned int [usertype] drivers/net/ethernet/realtek/8139too.c:2246:9: sparse: got restricted= __le32 [usertype] drivers/net/ethernet/realtek/8139too.c:2247:9: sparse: sparse: incorrect= type in argument 1 (different base types) @@ expected unsigned int [use= rtype] @@ got restrunsigned int [usertype] @@ drivers/net/ethernet/realtek/8139too.c:2247:9: sparse: expected unsig= ned int [usertype] drivers/net/ethernet/realtek/8139too.c:2247:9: sparse: got restricted= __le32 [usertype] >> drivers/net/ethernet/realtek/8139too.c:936:35: sparse: sparse: incorrect= type in initializer (incompatible argument 2 (different signedness)) @@ = expected void ( *ndo_tx_timeout )( ... ) @@ got void ( *ndo_tx_timeout = )( ... ) @@ >> drivers/net/ethernet/realtek/8139too.c:936:35: sparse: expected void = ( *ndo_tx_timeout )( ... ) >> drivers/net/ethernet/realtek/8139too.c:936:35: sparse: got void ( * )= ( ... ) vim +936 drivers/net/ethernet/realtek/8139too.c d95089dc54ad07 drivers/net/ethernet/realtek/8139too.c Ben Greear 201= 2-02-10 926 = 48dfcde46ef23c drivers/net/8139too.c Stephen Hemminger 200= 8-11-19 927 static const struct net_device_ops rtl8139_netdev_ops =3D { 48dfcde46ef23c drivers/net/8139too.c Stephen Hemminger 200= 8-11-19 928 .ndo_open =3D rtl8139_open, 48dfcde46ef23c drivers/net/8139too.c Stephen Hemminger 200= 8-11-19 929 .ndo_stop =3D rtl8139_close, 9184a22701ed25 drivers/net/ethernet/realtek/8139too.c Junchang Wang 201= 2-03-05 930 .ndo_get_stats64 =3D rtl8139_get_stats64, 48dfcde46ef23c drivers/net/8139too.c Stephen Hemminger 200= 8-11-19 931 .ndo_validate_addr =3D eth_validate_addr, bda6a15a0d283d drivers/net/8139too.c Jiri Pirko 200= 9-03-13 932 .ndo_set_mac_address =3D rtl8139_set_mac_address, 008298231abbeb drivers/net/8139too.c Stephen Hemminger 200= 8-11-20 933 .ndo_start_xmit =3D rtl8139_start_xmit, afc4b13df14312 drivers/net/ethernet/realtek/8139too.c Jiri Pirko 201= 1-08-16 934 .ndo_set_rx_mode =3D rtl8139_set_rx_mode, 48dfcde46ef23c drivers/net/8139too.c Stephen Hemminger 200= 8-11-19 935 .ndo_do_ioctl =3D netdev_ioctl, 48dfcde46ef23c drivers/net/8139too.c Stephen Hemminger 200= 8-11-19 @936 .ndo_tx_timeout =3D rtl8139_tx_timeout, 48dfcde46ef23c drivers/net/8139too.c Stephen Hemminger 200= 8-11-19 937 #ifdef CONFIG_NET_POLL_CONTROLLER 48dfcde46ef23c drivers/net/8139too.c Stephen Hemminger 200= 8-11-19 938 .ndo_poll_controller =3D rtl8139_poll_controller, 48dfcde46ef23c drivers/net/8139too.c Stephen Hemminger 200= 8-11-19 939 #endif d95089dc54ad07 drivers/net/ethernet/realtek/8139too.c Ben Greear 201= 2-02-10 940 .ndo_set_features =3D rtl8139_set_features, 48dfcde46ef23c drivers/net/8139too.c Stephen Hemminger 200= 8-11-19 941 }; ^1da177e4c3f41 drivers/net/8139too.c Linus Torvalds 200= 5-04-16 942 = :::::: The code at line 936 was first introduced by commit :::::: 48dfcde46ef23cfad1e0c0f13d4eae15c7f46efc 8139: convert to net_device= _ops :::::: TO: Stephen Hemminger :::::: CC: David S. Miller --- 0-DAY kernel test infrastructure Open Source Technology Cen= ter https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corpor= ation --===============8191499396483462188==--