Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C224C432C0 for ; Mon, 2 Dec 2019 16:29:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3893820722 for ; Mon, 2 Dec 2019 16:29:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727431AbfLBQ3I (ORCPT ); Mon, 2 Dec 2019 11:29:08 -0500 Received: from verein.lst.de ([213.95.11.211]:39253 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727521AbfLBQ3H (ORCPT ); Mon, 2 Dec 2019 11:29:07 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 5AE5768BE1; Mon, 2 Dec 2019 17:29:05 +0100 (CET) Date: Mon, 2 Dec 2019 17:29:05 +0100 From: Christoph Hellwig To: "Nadolski, Edmund" Cc: Keith Busch , Christoph Hellwig , stable@vger.kernel.org, Ingo Brunberg , Sagi Grimberg , linux-nvme@lists.infradead.org Subject: Re: [PATCH] nvme: Namepace identification descriptor list is optional Message-ID: <20191202162905.GA7683@lst.de> References: <20191202155611.21549-1-kbusch@kernel.org> <20191202161545.GA7434@lst.de> <20191202162256.GA21631@redsun51.ssa.fujisawa.hgst.com> <10e6520d-bc8c-94ff-00c4-32a727131b89@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10e6520d-bc8c-94ff-00c4-32a727131b89@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Dec 02, 2019 at 09:27:14AM -0700, Nadolski, Edmund wrote: >> I don't have such a controller, but many apparently do. The regression >> was reported here: >> >> http://lists.infradead.org/pipermail/linux-nvme/2019-December/028223.html >> >> And of course it's the SMI controller ... > > Does 5.4 show the exact error code? Perhaps we should selectively allow > just for that case? They'll find other ways to f***ck up. Looks like at least the controller in the bug report also doesn't have an subnqn and the nguid/eui64 are bogus. I wonder if we actually do users a favour by allowing that..