Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FD0C2BC73 for ; Wed, 4 Dec 2019 18:02:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 598EF2081B for ; Wed, 4 Dec 2019 18:02:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482549; bh=cmKGOHgM7wHlc5kYMfA4o8dgcIF1tniR9eks2UIjlII=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tAgL70hOs+JzD/iZqnePsMrsmtDBquYUT9XUqZbCI9FjZJHk5yjXRZ/lh8L4FgDrX V+TzZq0gNtkZcyoFdXKXK4DAz+tWje4918plw33CiQ9HmGQHPJnll6loN8Vb62O31X 5nw8s1hZG+ppTvO8Uohfa0oQ0Gvk+q9YxKBRGcPk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728738AbfLDSC1 (ORCPT ); Wed, 4 Dec 2019 13:02:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:44416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729838AbfLDSC0 (ORCPT ); Wed, 4 Dec 2019 13:02:26 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9A67620659; Wed, 4 Dec 2019 18:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482546; bh=cmKGOHgM7wHlc5kYMfA4o8dgcIF1tniR9eks2UIjlII=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WUWtpkdCWGBRHVp76LG18vcHKm5kMugsxcmgYTsoKFzUkW85jNumL9NTTu+JKXTYb KZ6EKYeAHYmRZKvYYFnnYzyYuLSp5JDpFqsI47zPh7WgT7ViVBtcO3XGKl3imjqaFd K4gbkpss+/4dE+uu/onbzazhHjhynwixz9tMzV5o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Steve Capper , Will Deacon , Suzuki K Poulose , Sasha Levin Subject: [PATCH 4.14 038/209] arm64: smp: Handle errors reported by the firmware Date: Wed, 4 Dec 2019 18:54:10 +0100 Message-Id: <20191204175324.047182044@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175321.609072813@linuxfoundation.org> References: <20191204175321.609072813@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Suzuki K Poulose [ Upstream commit f357b3a7e17af7736d67d8267edc1ed3d1dd9391 ] The __cpu_up() routine ignores the errors reported by the firmware for a CPU bringup operation and looks for the error status set by the booting CPU. If the CPU never entered the kernel, we could end up in assuming stale error status, which otherwise would have been set/cleared appropriately by the booting CPU. Reported-by: Steve Capper Cc: Will Deacon Signed-off-by: Suzuki K Poulose Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- arch/arm64/kernel/smp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index 0881dfab10f8f..909bf3926fd23 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -144,6 +144,7 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle) } } else { pr_err("CPU%u: failed to boot: %d\n", cpu, ret); + return ret; } secondary_data.task = NULL; -- 2.20.1