Date: Wed, 4 Dec 2019 19:42:50 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20191204194250.GN3325@work-vm> References: <20191204190836.31324-1-vgoyal@redhat.com> <20191204190836.31324-2-vgoyal@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191204190836.31324-2-vgoyal@redhat.com> Subject: Re: [Virtio-fs] [PATCH v2 1/5] virtiofsd: Get rid of unused fields in fv_QueueInfo List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vivek Goyal Cc: virtio-fs@redhat.com, mszeredi@redhat.com, qemu-devel@nongnu.org * Vivek Goyal (vgoyal@redhat.com) wrote: > There are some unused fields in "struct fv_QueueInfo". Get rid of these fields. > > Signed-off-by: Vivek Goyal > --- > contrib/virtiofsd/fuse_virtio.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c > index 31c8542b6c..2a9cd60a01 100644 > --- a/contrib/virtiofsd/fuse_virtio.c > +++ b/contrib/virtiofsd/fuse_virtio.c > @@ -50,12 +50,6 @@ struct fv_QueueInfo { > int qidx; > int kick_fd; > int kill_fd; /* For killing the thread */ > - > - /* The element for the command currently being processed */ > - VuVirtqElement *qe; > - /* If any of the qe vec elements (towards vmm) are unmappable */ > - unsigned int elem_bad_in; > - bool reply_sent; Yep, those last two got moved into FVRequest as part of the thread pool stuff. Reviewed-by: Dr. David Alan Gilbert > }; > > /* A FUSE request */ > -- > 2.20.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK