From: Tom Rini Date: Thu, 5 Dec 2019 08:47:29 -0500 Subject: [U-Boot] [PATCH v2 1/1] net: avoid address-of-packed-member error In-Reply-To: <8e974e82-a1f2-1c74-5a57-2734711da4ca@gmx.de> References: <20191105114819.11727-1-xypron.glpk@gmx.de> <8e974e82-a1f2-1c74-5a57-2734711da4ca@gmx.de> Message-ID: <20191205134729.GK9549@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Thu, Dec 05, 2019 at 08:16:15AM +0100, Heinrich Schuchardt wrote: > On 11/6/19 12:07 AM, Joe Hershberger wrote: > > On Tue, Nov 5, 2019 at 5:49 AM Heinrich Schuchardt wrote: > > > > > > sandbox_defconfig does not compile using GCC 9.2.1: > > > > > > net/net.c: In function ‘net_process_received_packet’: > > > net/net.c:1288:23: error: taking address of packed member of ‘struct > > > ip_udp_hdr’ may result in an unaligned pointer value > > > [-Werror=address-of-packed-member] > > > 1288 | sumptr = (ushort *)&(ip->udp_src); > > > | ^~~~~~~~~~~~~~ > > > > > > Avoid the error by using a u8 pointer instead of an u16 pointer and > > > in-lining ntohs(). > > > > Seems reasonable. > > > > > Simplify the checksumming of the last message byte. > > > > > > Signed-off-by: Heinrich Schuchardt > > > > Acked-by: Joe Hershberger > > > > Hello Joe, > > this patch did not yet make it into > https://gitlab.denx.de/u-boot/custodians/u-boot-net/commits/master > > Is there something that needs to be changed? And perhaps we need to split the net PR in to bug fixes to get now and stuff to put in to -next, for the next window? Or is this one of the changes that causes size overflow? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: