From: Tom Rini Date: Fri, 6 Dec 2019 10:13:56 -0500 Subject: [U-Boot] [PATCH] Add -pthread to HOSTLOADLIBES_mkimage In-Reply-To: References: Message-ID: <20191206151356.GL9549@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de On Tue, Dec 03, 2019 at 09:06:39AM +0000, Benedikt-Alexander Mokro=C3=9F wr= ote: > On some unix distributions, pthread is not automatically linked. > This results in unresolved symbols when e.g. building u-boot via OpenWRT = (using LibreSSL) in dumpimage and other host tools when i.E. CONFIG_FIT_SIG= NATURE is set. > Using -pthread to link pthread should be portable across all distribution= s and OS X. >=20 > CHANGELOG: > * Added -pthread to HOSTLOADLIBES_mkimage > --- > tools/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/tools/Makefile b/tools/Makefile > index 24581adccd..2f122bed8e 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -150,7 +150,8 @@ ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_ARMADA_38= X)$(CONFIG_ARMADA_39X)$(CON > HOSTCFLAGS_kwbimage.o +=3D \ > $(shell pkg-config --cflags libssl libcrypto 2> /dev/null || echo "") > HOSTLOADLIBES_mkimage +=3D \ > -$(shell pkg-config --libs libssl libcrypto 2> /dev/null || echo "-lssl -= lcrypto") > +$(shell pkg-config --libs libssl libcrypto 2> /dev/null || echo "-lssl -= lcrypto") \ > +-pthread >=20 > # OS X deprecate openssl in favour of CommonCrypto, supress deprecation > # warnings on those systems My first reaction is that it's a bug within openwrt pkg-config files to not say that -pthread is required. Would that not be the normal case? Thanks! --=20 Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: