Content-Type: multipart/mixed; boundary="===============7395120895109619482==" MIME-Version: 1.0 From: Takashi Sakamoto To: kbuild-all@lists.01.org Subject: Re: sound/firewire/motu/motu-pcm.c:191 pcm_open() error: double unlocked 'motu->mutex' (orig line 179) Date: Mon, 09 Dec 2019 08:24:38 +0900 Message-ID: <20191208232437.GA6741@workstation> In-Reply-To: <20191208084034.GU1787@kadam> List-Id: --===============7395120895109619482== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Dan, On Sun, Dec 08, 2019 at 11:40:34AM +0300, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi= t master > head: 94e89b40235476a83a53a47b9ffb0cb91a4c335e > commit: 3fd80b2003882b6a328caff9e6b3a14bed61f27c ALSA: firewire-motu: use= the same size of period for PCM substream in AMDTP streams > = > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > Reported-by: Dan Carpenter > = > smatch warnings: > sound/firewire/motu/motu-pcm.c:191 pcm_open() error: double unlocked 'mot= u->mutex' (orig line 179) Indeed, it's a bug introduced in v5.5 kernel. I posted a patch to fix this just now: https://mailman.alsa-project.org/pipermail/alsa-devel/2019-December/159552.= html > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/comm= it/?id=3D3fd80b2003882b6a328caff9e6b3a14bed61f27c > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torv= alds/linux.git > git remote update linus > git checkout 3fd80b2003882b6a328caff9e6b3a14bed61f27c > vim +191 sound/firewire/motu/motu-pcm.c > = > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 133 static int pcm_open(stru= ct snd_pcm_substream *substream) > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 134 { > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 135 struct snd_motu *motu = =3D substream->private_data; > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 136 const struct snd_motu_p= rotocol *const protocol =3D motu->spec->protocol; > 3fd80b2003882b Takashi Sakamoto 2019-10-07 137 struct amdtp_domain *d = =3D &motu->domain; > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 138 enum snd_motu_clock_sou= rce src; > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 139 int err; > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 140 = > 71c3797779d3cd Takashi Sakamoto 2017-03-22 141 err =3D snd_motu_stream= _lock_try(motu); > 71c3797779d3cd Takashi Sakamoto 2017-03-22 142 if (err < 0) > 71c3797779d3cd Takashi Sakamoto 2017-03-22 143 return err; > 71c3797779d3cd Takashi Sakamoto 2017-03-22 144 = > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 145 mutex_lock(&motu->mutex= ); > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 146 = > 8b460c76bd1712 Takashi Sakamoto 2017-08-20 147 err =3D snd_motu_stream= _cache_packet_formats(motu); > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 148 if (err < 0) > 71c3797779d3cd Takashi Sakamoto 2017-03-22 149 goto err_locked; > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 150 = > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 151 err =3D init_hw_info(mo= tu, substream); > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 152 if (err < 0) > 71c3797779d3cd Takashi Sakamoto 2017-03-22 153 goto err_locked; > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 154 = > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 155 err =3D protocol->get_c= lock_source(motu, &src); > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 156 if (err < 0) > 71c3797779d3cd Takashi Sakamoto 2017-03-22 157 goto err_locked; > 3fd80b2003882b Takashi Sakamoto 2019-10-07 158 = > 3fd80b2003882b Takashi Sakamoto 2019-10-07 159 // When source of clock= is not internal or any stream is reserved for > 3fd80b2003882b Takashi Sakamoto 2019-10-07 160 // transmission of PCM = frames, the available sampling rate is limited > 3fd80b2003882b Takashi Sakamoto 2019-10-07 161 // at current one. > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 162 if (src !=3D SND_MOTU_C= LOCK_SOURCE_INTERNAL || > 3fd80b2003882b Takashi Sakamoto 2019-10-07 163 (motu->substreams_c= ounter > 0 && d->events_per_period > 0)) { > 3fd80b2003882b Takashi Sakamoto 2019-10-07 164 unsigned int frames_pe= r_period =3D d->events_per_period; > 3fd80b2003882b Takashi Sakamoto 2019-10-07 165 unsigned int rate; > 3fd80b2003882b Takashi Sakamoto 2019-10-07 166 = > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 167 err =3D protocol->get_= clock_rate(motu, &rate); > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 168 if (err < 0) > 71c3797779d3cd Takashi Sakamoto 2017-03-22 169 goto err_locked; > 3fd80b2003882b Takashi Sakamoto 2019-10-07 170 = > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 171 substream->runtime->hw= .rate_min =3D rate; > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 172 substream->runtime->hw= .rate_max =3D rate; > 3fd80b2003882b Takashi Sakamoto 2019-10-07 173 = > 3fd80b2003882b Takashi Sakamoto 2019-10-07 174 if (frames_per_period = > 0) { > 3fd80b2003882b Takashi Sakamoto 2019-10-07 175 err =3D snd_pcm_hw_co= nstraint_minmax(substream->runtime, > 3fd80b2003882b Takashi Sakamoto 2019-10-07 176 SNDRV_PCM_HW_PARAM_= PERIOD_SIZE, > 3fd80b2003882b Takashi Sakamoto 2019-10-07 177 frames_per_period, = frames_per_period); > 3fd80b2003882b Takashi Sakamoto 2019-10-07 178 if (err < 0) { > 3fd80b2003882b Takashi Sakamoto 2019-10-07 @179 mutex_unlock(&motu->= mutex); > = ^^^^^^^^^^^^^^^^^^^^^^^^^^ > Delete this. > = > 3fd80b2003882b Takashi Sakamoto 2019-10-07 180 goto err_locked; > 3fd80b2003882b Takashi Sakamoto 2019-10-07 181 } > 3fd80b2003882b Takashi Sakamoto 2019-10-07 182 } > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 183 } > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 184 = > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 185 snd_pcm_set_sync(substr= eam); > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 186 = > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 187 mutex_unlock(&motu->mut= ex); > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 188 = > 3fd80b2003882b Takashi Sakamoto 2019-10-07 189 return 0; > 71c3797779d3cd Takashi Sakamoto 2017-03-22 190 err_locked: > 71c3797779d3cd Takashi Sakamoto 2017-03-22 @191 mutex_unlock(&motu->mut= ex); > 71c3797779d3cd Takashi Sakamoto 2017-03-22 192 snd_motu_stream_lock_re= lease(motu); > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 193 return err; > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 194 } > dd49b2d1f04af9 Takashi Sakamoto 2017-03-22 195 = > = > --- > 0-DAY kernel test infrastructure Open Source Technology C= enter > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corp= oration Thanks Takashi Sakamoto --===============7395120895109619482==--