Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F49CC43603 for ; Tue, 10 Dec 2019 16:59:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 297042073D for ; Tue, 10 Dec 2019 16:59:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="O/hAO5hy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727629AbfLJQ7X (ORCPT ); Tue, 10 Dec 2019 11:59:23 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:45204 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727562AbfLJQ7X (ORCPT ); Tue, 10 Dec 2019 11:59:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XCnrvfK/6ZSwWtUa4WnRzsawMPuUS+/ZEAOjeYKVcR0=; b=O/hAO5hyNVYYkbZIrFj71Q0agz 0h95UxPKyiYVAssw4hFPOYfFhP6hVrga3KIAw/q0Ro4uqG40jMo6qGo55gmNl6XIU32cEfXyYwWYN EA65GtC5Tvr9M7atPedyeStBSK+/TofX7ng98+s0fGv/0AknFsrtc+ttQW/5y9xxv5Eo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1ieir1-0005Vr-69; Tue, 10 Dec 2019 17:59:19 +0100 Date: Tue, 10 Dec 2019 17:59:19 +0100 From: Andrew Lunn To: Russell King Cc: Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 04/14] net: sfp: add module start/stop upstream notifications Message-ID: <20191210165919.GJ27714@lunn.ch> References: <20191209151553.GP25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Dec 09, 2019 at 03:18:44PM +0000, Russell King wrote: > When dealing with some copper modules, we can't positively know the > module capabilities are until we have probed the PHY. Without the full > capabilities, we may end up failing a module that we could otherwise > drive with a restricted set of capabilities. > > An example of this would be a module with a NBASE-T PHY plugged into > a host that supports phy interface modes 2500BASE-X and SGMII. The > PHY supports 10GBASE-R, 5000BASE-X, 2500BASE-X, SGMII interface modes, > which means a subset of the capabilities are compatible with the host. > > However, reading the module EEPROM leads us to believe that the module > only supports ethtool link mode 10GBASE-T, which is incompatible with > the host - and thus results in the module being rejected. > > This patch adds an extra notification which are triggered after the > SFP module's PHY probe, and a corresponding notification just before > the PHY is removed. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew