Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20ECBC43603 for ; Tue, 10 Dec 2019 21:43:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DAF92205C9 for ; Tue, 10 Dec 2019 21:43:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576014237; bh=lWnVGF3El/SbpEqfrza9Xl4247t0but3w9KlA8qFZR0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hknfG2A6C1S0PmunBqv8QZiwhAjCUPoyzcQJPLHDvxoqnaxTteWB+tJxTfORc9lK+ iRGcCpccHpIbK0PkWm7rrG5sE+ZVXL2cmg6e54rV1zAdztCQ+E1ZPVuHWHIT5qenAl VDGkt3ZrbFeC3I/aofYqze8ZffSTs74nO/66mTng= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728563AbfLJVnz (ORCPT ); Tue, 10 Dec 2019 16:43:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:37888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729739AbfLJVdb (ORCPT ); Tue, 10 Dec 2019 16:33:31 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 814F82465A; Tue, 10 Dec 2019 21:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576013610; bh=lWnVGF3El/SbpEqfrza9Xl4247t0but3w9KlA8qFZR0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hkY4xzNull6uIVLK80YlsPh8JGLHaedmhmXDF/HTFb3aNnlwPmwpupymmyHoz2BcB E9PkOFjKxrmNFp18LrQN+VQ0WA9H2kL3bOZmJabg3Tg4HAhuCAZPt1oh0k2KS+PiJa zY4zU22lEnVhi2PJJIX2K192xq0570l8ghbacjmk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Leo Yan , Alexander Shishkin , Jiri Olsa , Mark Rutland , Namhyung Kim , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH AUTOSEL 4.19 056/177] perf test: Report failure for mmap events Date: Tue, 10 Dec 2019 16:30:20 -0500 Message-Id: <20191210213221.11921-56-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191210213221.11921-1-sashal@kernel.org> References: <20191210213221.11921-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Leo Yan [ Upstream commit 6add129c5d9210ada25217abc130df0b7096ee02 ] When fail to mmap events in task exit case, it misses to set 'err' to -1; thus the testing will not report failure for it. This patch sets 'err' to -1 when fails to mmap events, thus Perf tool can report correct result. Fixes: d723a55096b8 ("perf test: Add test case for checking number of EXIT events") Signed-off-by: Leo Yan Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Mark Rutland Cc: Namhyung Kim Link: http://lore.kernel.org/lkml/20191011091942.29841-1-leo.yan@linaro.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/tests/task-exit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/tests/task-exit.c b/tools/perf/tests/task-exit.c index e92fa6029ac77..788b0805d2f1e 100644 --- a/tools/perf/tests/task-exit.c +++ b/tools/perf/tests/task-exit.c @@ -105,6 +105,7 @@ int test__task_exit(struct test *test __maybe_unused, int subtest __maybe_unused if (perf_evlist__mmap(evlist, 128) < 0) { pr_debug("failed to mmap events: %d (%s)\n", errno, str_error_r(errno, sbuf, sizeof(sbuf))); + err = -1; goto out_delete_evlist; } -- 2.20.1