Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A79E6C43603 for ; Fri, 13 Dec 2019 10:40:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76D47206B7 for ; Fri, 13 Dec 2019 10:40:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725928AbfLMKkG (ORCPT ); Fri, 13 Dec 2019 05:40:06 -0500 Received: from mx2.suse.de ([195.135.220.15]:51494 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725890AbfLMKkF (ORCPT ); Fri, 13 Dec 2019 05:40:05 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 28312B0B6; Fri, 13 Dec 2019 10:40:04 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id BAC151E0CAF; Fri, 13 Dec 2019 11:40:03 +0100 (CET) Date: Fri, 13 Dec 2019 11:40:03 +0100 From: Jan Kara To: Eric Biggers Cc: Andrew Morton , Alexander Viro , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fs/direct-io.c: include fs/internal.h for missing prototype Message-ID: <20191213104003.GA15474@quack2.suse.cz> References: <20191209234544.128302-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191209234544.128302-1-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon 09-12-19 15:45:44, Eric Biggers wrote: > From: Eric Biggers > > Include fs/internal.h to address the following 'sparse' warning: > > fs/direct-io.c:591:5: warning: symbol 'sb_init_dio_done_wq' was not declared. Should it be static? > > Signed-off-by: Eric Biggers Makes sense. You can add: Reviewed-by: Jan Kara Honza > --- > > Hi Andrew, please consider applying this straightforward cleanup. > This has been sent to Al four times with no response. > > fs/direct-io.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/direct-io.c b/fs/direct-io.c > index 0ec4f270139f6..00b4d15bb811a 100644 > --- a/fs/direct-io.c > +++ b/fs/direct-io.c > @@ -39,6 +39,8 @@ > #include > #include > > +#include "internal.h" > + > /* > * How many user pages to map in one call to get_user_pages(). This determines > * the size of a structure in the slab cache > -- > 2.24.0.393.g34dc348eaf-goog > -- Jan Kara SUSE Labs, CR