Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 175D8C3F68F for ; Fri, 13 Dec 2019 20:37:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 567B324788 for ; Fri, 13 Dec 2019 20:37:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727741AbfLMOof (ORCPT ); Fri, 13 Dec 2019 09:44:35 -0500 Received: from mga18.intel.com ([134.134.136.126]:12100 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727619AbfLMOoe (ORCPT ); Fri, 13 Dec 2019 09:44:34 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2019 06:44:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,309,1571727600"; d="scan'208";a="415655861" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006.fm.intel.com with ESMTP; 13 Dec 2019 06:44:31 -0800 Received: from andy by smile with local (Exim 4.93-RC7) (envelope-from ) id 1ifmBD-0004Dl-I4; Fri, 13 Dec 2019 16:44:31 +0200 Date: Fri, 13 Dec 2019 16:44:31 +0200 From: Andy Shevchenko To: Linus Walleij Cc: Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , Mika Westerberg Subject: Re: [PATCH v2 00/24] pinctrl: intel: Move Lynxpoint to pin control umbrella Message-ID: <20191213144431.GV32742@smile.fi.intel.com> References: <20191209130926.86483-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Dec 13, 2019 at 02:36:36PM +0100, Linus Walleij wrote: > On Mon, Dec 9, 2019 at 2:09 PM Andy Shevchenko > wrote: > > > Intel Lynxpoint GPIO is actually half way to the Chassis specification > > that has been established starting from Intel Skylake. It has some pin control > > properties we may utilize. To achieve this, move the driver under pin control > > umbrella and do a bunch of clean ups. > > > > The series has been tested on Broadwell Ultrabook where Lynxpoint GPIO > > is exposed to the OS. > > > > It has a dependency to patches in my review branch [1]. That dependency patch > > is supposed to be submitted soon as a part of Baytrail clean up. In the > > mentioned branch the patches are represented in the correct order. > > > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/intel.git/log/?h=review-andy > > > > Changes v2: > > - fixed ordering in Kconfig and Makefile (Mika) > > - finished conversion to pin control > > This is some really nice development and just go ahead: > Reviewed-by: Linus Walleij > > If you want to make my life simple could you do this: I want, though I think above makes it harder. I'll not expecting any patches against gpio-lynxpoint.c (and if they will be an author should Cc me anyway). Besides the series nicely grouped on top of prerequisites which are solely Intel pin control (no need for GPIO). Thus I prefer to send simple 1 PR during this cycle to pin control subsystem and that's it. Tell me if you think it won't work. > - One pull request just moving the driver to the pin control > subsystem. I will pull this into both the pinctrl and the GPIO > tree. > > - One pull request based on top of the last commit in the first > pull request with just the rest of refactorings and improvements. > I will just pull this into the pinctrl tree on top of the moved driver. -- With Best Regards, Andy Shevchenko