Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98A02C2D0DF for ; Fri, 13 Dec 2019 20:44:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D05F824689 for ; Fri, 13 Dec 2019 20:44:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="SPBUHi28" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D05F824689 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1F906EC1A; Fri, 13 Dec 2019 18:49:28 +0000 (UTC) Received: from mail-yw1-xc44.google.com (mail-yw1-xc44.google.com [IPv6:2607:f8b0:4864:20::c44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 499A06EC1A for ; Fri, 13 Dec 2019 18:49:27 +0000 (UTC) Received: by mail-yw1-xc44.google.com with SMTP id t141so232121ywc.11 for ; Fri, 13 Dec 2019 10:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=N+Z6VHAKomhoL8I7KJYIHhWG6r2PIQkCrCHBBFVk3M8=; b=SPBUHi28hjvGvu+WPccLyHNCxisOv1l+XMAr6IP/rYkxfyjDnN9BP3KmFrPfwjSUZ3 zEcP606qD0U2PHurLvJAtaGCc2IrZ7xelv5NmoMt4GvK8bQ6o6DUMiMDTQz5+kfrNvPD xERlF8dVCxakb1Kom5KFMqgLPMzyvwXOUmOof8i5InAwplGHIG3CLoSKzDtjstTM8YvL wj94aS5Dk/5cTpJRnPA/reJ6w99iJElNkbBd+evdYi8x5uB7y9sTb+uYezFfAD1VFpHX ObY0X2btpQ3glWVAzhYKloq79H1ZlIdTUdOnAmk3cUeBFSDjBcsi+VI/7MQAQ88Y/6WB QlAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=N+Z6VHAKomhoL8I7KJYIHhWG6r2PIQkCrCHBBFVk3M8=; b=HH6n2ez3QqflWE1MjyUTRGODZ07Qv8j+yyQookte6zmI+wYiHAdEuooQlEHkYW/GKR Wr9od2QNsVWL8UwhnxqYrqHrvX+IUwmzGcpTBc7NYczbRAoa4jwGi3FByFKvAHD3dGIH iMihLHd6Ev44EA8wgy934cgffWJFL58PtUfY3VAaUbzlKmzliAgXmdjSEfol4gb6Jx3i tJlacsXu6B33quA5ByJccK3W3YDK2CMIldNx7nBhd/IZwCp9APApb212VRoE0MVB6yLH hfr/YaHsc9gJiRnA05zTtX5fXV0ZRzzn4/xUbE3xs4Aj+S/fzjZqge6FfwiCj0dmQFv7 1SUg== X-Gm-Message-State: APjAAAWa3ZZtmWXwcLgYM1YXjVr68Ws8hEotVvufkA/UKNJjyacj6weG kO1VNNnbCKcfccrlcTXE5HCYUg== X-Google-Smtp-Source: APXvYqwjXbq84BVcdIMwj4ac7ii7guW7dD5pve73cpiJVImeRftGtrrDfATHuX743XImJxP3EPQ+Rw== X-Received: by 2002:a81:990e:: with SMTP id q14mr9484672ywg.66.1576262966487; Fri, 13 Dec 2019 10:49:26 -0800 (PST) Received: from localhost ([2620:0:1013:11:1e1:4760:6ce4:fc64]) by smtp.gmail.com with ESMTPSA id g29sm4546203ywk.31.2019.12.13.10.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2019 10:49:25 -0800 (PST) Date: Fri, 13 Dec 2019 13:49:25 -0500 From: Sean Paul To: Steven Rostedt Subject: Re: [PATCH v3] drm: Funnel drm logs to tracepoints Message-ID: <20191213184925.GD41609@art_vandelay> References: <20191212203301.142437-1-sean@poorly.run> <20191212222050.0bdddc13@rorschach.local.home> <20191213164652.GB41609@art_vandelay> <20191213115436.4e14a8ae@gandalf.local.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191213115436.4e14a8ae@gandalf.local.home> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Sean Paul , dri-devel@lists.freedesktop.org, Ingo Molnar , Sean Paul , Thomas Zimmermann , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Dec 13, 2019 at 11:54:36AM -0500, Steven Rostedt wrote: > On Fri, 13 Dec 2019 11:47:03 -0500 > Sean Paul wrote: > > > > Why is there a separate trace event for each of these? > > > > > > > To make it easier on userspace to enable just a single drm category. > > > > But trace events can easily be filtered. Say you have a field called > category, you could then just set in the trace event filter: > > echo 'category == 1 || category == 5 || (category > 8 && category < 12)' > /sys/kernel/tracing/drm_print/drm_category_log/filter > echo 1 > /sys/kernel/tracing/drm_print/drm_category_log/enable Hmm, true. I suppose the only downside would be that this would cause all logs to be processed/assigned as trace events before the filter is applied. That's a lot of extra work each frame. Sean > > -- Steve -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel