Received: by 2002:a19:c345:0:0:0:0:0 with SMTP id t66csp6254623lff; Tue, 17 Dec 2019 08:38:47 -0800 (PST) X-Google-Smtp-Source: APXvYqxO3Cnv5kKCHR7dr+hhlMF9ZEYqB4EonDuneNDMcCow1V7YsdBabrgl/fTCirrrqcPV+XFz X-Received: by 2002:a05:620a:1265:: with SMTP id b5mr6044495qkl.172.1576600726948; Tue, 17 Dec 2019 08:38:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576600726; cv=none; d=google.com; s=arc-20160816; b=KRZRTLnx1Nai9ZQrngLGL+GejcGbFvN6lyBUmHKiwGzSkVq8AMO93SA4dZfeEconQi xm13YCKDfgdBMtaDER4BMbrnB2J8RU3zg+6f//jr/gB/cKI8t5t0/m1R7BwjIm5We0Am Q5wI+WC3fcx5I2OmmZmwLhUxSaSb3By2HV8dstPpfXVjpATO5f+x9GT+IJ7Q+G1s/9Kc FO0e/VHFKj19d1LfkzyymA1N0dOMSMrvwPdEq7iGXtYctcvOICxHfIiu8+qYnjua0LMS C42ui0DSaj3uHsXBoWFkRNUmySpl/+98SwjCj/bh254FrYcox3TsDmm/587grSrOHHdn aYFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=6a8mxHo3cySJx2vpicwTxKmGILKeHDrQeQCRS52voSg=; b=tEBPeJFTawsND/l/cUmx1p8n2n1/qVZpW2uejIqs4A0AIadaQJfHnD/RAebNASRxkf VeQqhEWRpx+AKD9TiBg1z/g5eqp5t0GAt0Xfg/E+u5d8QIzxXQveT2wDvlIkIyV4nsKC /6nBMnw+Wn0vuP5CABypaCXcnjk0fQ75REyNDKIJZypMNHor+YeGc+QOiYs4CPUGtdvN Qwf397WGeuUsgZ1aMNYCx9Lm0wKdplevfJIjx/MCu584bY/44xCCmhgNeuAiz6HqHIRH zcOpaCFmwM2V3i11tRhTMNGIa0dunwCd0aqeg02n1sKyc1SBgU6xHS+yOn5piWcY9eOX l1/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=g6xCKi38; spf=pass (google.com: domain of philmd@redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com. [205.139.110.61]) by mx.google.com with ESMTPS id f51si12013470qta.375.2019.12.17.08.38.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Dec 2019 08:38:46 -0800 (PST) Received-SPF: pass (google.com: domain of philmd@redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=g6xCKi38; spf=pass (google.com: domain of philmd@redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576600726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6a8mxHo3cySJx2vpicwTxKmGILKeHDrQeQCRS52voSg=; b=g6xCKi38tPOVUmOBnb9RND0bedDBQKsv4DAr0C1laBvbIHub1Y554yFpxGRoZerHRLiImi lD4F2Zcc6zUOIusz1kqnzq+PtCfhakw7Cx/vIgvXMCGH3KsjFzfxpcGiA4Io58jItekm5I jj62X/QZ9EOEN9VM1U+fXuLVfCE+yKs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-424-rojm5KUGNQak6JPZ_E3JYA-1; Tue, 17 Dec 2019 11:38:44 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C9102DBA5; Tue, 17 Dec 2019 16:38:39 +0000 (UTC) Received: from x1w.redhat.com (ovpn-205-147.brq.redhat.com [10.40.205.147]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4C22D675BF; Tue, 17 Dec 2019 16:38:11 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Cornelia Huck , Zhang Chen , "Michael S. Tsirkin" , Fabien Chouteau , Paul Burton , Peter Maydell , KONRAD Frederic , Aurelien Jarno , Jason Wang , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Corey Minyard , Max Reitz , Li Zhijian , Gerd Hoffmann , Michael Walle , Markus Armbruster , Laurent Vivier , Igor Mitsyanko , Joel Stanley , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bastian Koppelmann , Alberto Garcia , Peter Chubb , "Edgar E. Iglesias" , "Dr. David Alan Gilbert" , Christian Borntraeger , Andrzej Zaborowski , Aleksandar Rikalo , Aleksandar Markovic , Sagar Karandikar , Antony Pavlov , qemu-arm@nongnu.org, Alistair Francis , Kevin Wolf , qemu-s390x@nongnu.org, "Gonglei (Arei)" , Palmer Dabbelt , Samuel Thibault , Amit Shah , qemu-riscv@nongnu.org, Halil Pasic , Thomas Huth Subject: [PATCH 00/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef Date: Tue, 17 Dec 2019 17:37:54 +0100 Message-Id: <20191217163808.20068-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: rojm5KUGNQak6JPZ_E3JYA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TUID: QvQnVtTNWRUa Hi, After this chat on #qemu IRC: 13:20 so what is the difference between a IOReadHandler and IOEve= ntHandler? 13:25 stsquad: one is in-band and the other out-of-band? 13:26 f4bug: ahh yes it seems so - connect/disconnect etc... 13:27 see QEMUChrEvent for IOEventHandler I thought it might be a good opportunity to make the IOEventHandler typedef meaning more obvious, by using the QEMUChrEvent enum. To be able to build I had to explicit a 'default' case when frontends use a switch(event) case and do not handle all events. Then I used a coccinelle spatch to change the various IOEventHandler. I don't think the last patch can be split, but suggestions are welcome! Regards, Phil. PD: I use git-publish. To avoid spamming too much, I'm using per-patch Cc tag, after the '---' separator. This way each recipient should get the cover and the specific patches of interests, + the last one. Sent with: 'git publish --suppress-cc=3Dcccmd' Cc: "Gonglei (Arei)" Cc: "Marc-Andr=C3=A9 Lureau" Cc: Paolo Bonzini Cc: "Alex Benn=C3=A9e" Cc: "Philippe Mathieu-Daud=C3=A9" Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Kevin Wolf Cc: Max Reitz Cc: "Edgar E. Iglesias" Cc: Alistair Francis Cc: Antony Pavlov Cc: Igor Mitsyanko Cc: Fabien Chouteau Cc: KONRAD Frederic Cc: Peter Chubb Cc: Alberto Garcia Cc: Michael Walle Cc: Thomas Huth Cc: Joel Stanley Cc: Cornelia Huck Cc: Halil Pasic Cc: Christian Borntraeger Cc: Laurent Vivier Cc: Amit Shah Cc: Corey Minyard Cc: Paul Burton Cc: Aleksandar Rikalo Cc: Aurelien Jarno Cc: Aleksandar Markovic Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Gerd Hoffmann Cc: Samuel Thibault Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Cc: Zhang Chen Cc: Li Zhijian Cc: Jason Wang Cc: qemu-arm@nongnu.org Cc: qemu-block@nongnu.org Cc: qemu-s390x@nongnu.org Cc: qemu-riscv@nongnu.org Philippe Mathieu-Daud=C3=A9 (14): hw/ipmi: Remove unnecessary declarations chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler vhost-user: Explicit we ignore some QEMUChrEvent in IOEventHandler virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler hw/ipmi: Explicit we ignore some QEMUChrEvent in IOEventHandler hw/usb/dev-serial: Explicit we ignore few QEMUChrEvent in IOEventHandler ccid-card-passthru: Explicit we ignore QEMUChrEvent in IOEventHandler hw/usb/redirect: Explicit we ignore few QEMUChrEvent in IOEventHandler monitor/qmp: Explicit we ignore few QEMUChrEvent in IOEventHandler monitor/hmp: Explicit we ignore a QEMUChrEvent in IOEventHandler net/vhost-user: Explicit we ignore few QEMUChrEvent in IOEventHandler vhost-user-blk: Explicit we ignore few QEMUChrEvent in IOEventHandler hw/char/terminal3270: Explicit ignored QEMUChrEvent in IOEventHandler chardev: Use QEMUChrEvent enum in IOEventHandler typedef include/chardev/char-fe.h | 2 +- include/chardev/char-mux.h | 2 +- include/chardev/char.h | 4 ++-- backends/cryptodev-vhost-user.c | 5 ++++- chardev/char-mux.c | 8 ++++---- chardev/char.c | 7 +++++-- gdbstub.c | 2 +- hw/arm/pxa2xx.c | 2 +- hw/arm/strongarm.c | 2 +- hw/block/vhost-user-blk.c | 5 ++++- hw/char/cadence_uart.c | 2 +- hw/char/digic-uart.c | 2 +- hw/char/escc.c | 2 +- hw/char/etraxfs_ser.c | 2 +- hw/char/exynos4210_uart.c | 2 +- hw/char/grlib_apbuart.c | 2 +- hw/char/imx_serial.c | 2 +- hw/char/ipoctal232.c | 2 +- hw/char/lm32_juart.c | 2 +- hw/char/lm32_uart.c | 2 +- hw/char/mcf_uart.c | 2 +- hw/char/milkymist-uart.c | 2 +- hw/char/nrf51_uart.c | 2 +- hw/char/pl011.c | 2 +- hw/char/serial.c | 2 +- hw/char/sh_serial.c | 2 +- hw/char/terminal3270.c | 5 ++++- hw/char/virtio-console.c | 5 ++++- hw/char/xilinx_uartlite.c | 2 +- hw/ipmi/ipmi_bmc_extern.c | 10 +++++----- hw/mips/boston.c | 2 +- hw/mips/mips_malta.c | 2 +- hw/riscv/riscv_htif.c | 2 +- hw/riscv/sifive_uart.c | 2 +- hw/usb/ccid-card-passthru.c | 5 ++++- hw/usb/dev-serial.c | 5 ++++- hw/usb/redirect.c | 5 ++++- monitor/hmp.c | 6 +++++- monitor/qmp.c | 5 ++++- net/filter-mirror.c | 2 +- net/vhost-user.c | 7 +++++-- qtest.c | 2 +- tests/test-char.c | 6 +++--- tests/vhost-user-test.c | 2 +- 44 files changed, 90 insertions(+), 56 deletions(-) --=20 2.21.0