Received: by 2002:a19:c345:0:0:0:0:0 with SMTP id t66csp6261807lff; Tue, 17 Dec 2019 08:44:50 -0800 (PST) X-Google-Smtp-Source: APXvYqwpJ4Ho6BxnE7fEOnIhGQTK65ysILjbDadTfpMIZIJefVpYaYirAQlag/B9Dd7PHCIkxOVq X-Received: by 2002:a17:907:10da:: with SMTP id rv26mr6036823ejb.242.1576601090853; Tue, 17 Dec 2019 08:44:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576601090; cv=none; d=google.com; s=arc-20160816; b=ds2LaLEXKtm+YVhdwPJjrobt3JYEtw/lbslfexrmZcS06dKnUqdMD6XZOB2sXH29XF 7JOxzc9QpfId/dE2domMszbXsNqbsk6Ai64jEJtFipNr+Rpu+gBEb3xED4IXtZrKlJCM 72Fhsx2/GAOFQOit0MbbFQNA0mgt6zntGzZMOAVvEB719pdkphdK3I6oU++vL2udSZT+ 3BcU/IJtgqxz3fhkhjcmrEhbqHW4Z78Z9Fzq3+id4bArT2AvEgH5INjzQfyJHdO/ERmi QNvK/rbdPiLdg4P917Zqxznze2OOuKwzcTfzprSXeXTpBC1cRQkU/kiobC0JIfA82dyG OL5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=cgmzu31Rt2ux67Lpas/rsmhkVxbL3amuZtxQ77YbDhM=; b=q8faFKK2vo3kCkrgjA+VU4O+FyoIiQHl1szhfWfYMMUgmrAdSK/VnULcACUFjRcYy2 gg9vWWAvLv/M8HlRmvqa5IJTlnsotL1elD5rPVLrNM5sNV/dq1f5mFhecQXMd32WEwhk 0AptWmOzMLakwF2B/o2kNrlwgpDxX8yBAzLlZ3cnGIhwmKU5KtZOELjpznt3m0JXB+ic OGBhDJGkDm5apmErCViIiF7r3jmVkxVpP23mAba+gkC+zw/mUx3UHgi3I9bkcY4L+d3z xwvjGWpC3WL+YQ5d3ytGJJvq+BSPDYlW/opIHw1rdoN/sC5+X9ScrGQBB/6A9YgHgde7 xaPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=A3ynwGsw; spf=pass (google.com: domain of philmd@redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com. [207.211.31.81]) by mx.google.com with ESMTPS id b4si3227098edf.125.2019.12.17.08.44.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Dec 2019 08:44:50 -0800 (PST) Received-SPF: pass (google.com: domain of philmd@redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=A3ynwGsw; spf=pass (google.com: domain of philmd@redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576601089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cgmzu31Rt2ux67Lpas/rsmhkVxbL3amuZtxQ77YbDhM=; b=A3ynwGswjViAkFb7MBzdTpRJHjBvjoEn/64MlPl7XdH3ckSyUSUEE8644+j0+Qn3Q+E4IU 6WuH6aQLtvYjKxo0P82lfGIj8Epx4PFT43YvdbtsbLp4XRCZK8QKV50Zuc0//EZKL4OvFm 67SAAwUE/29Z+0Fm4uOexvKOZhmvQGk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-189-K55-sau0PYefSDfGkLWuzg-1; Tue, 17 Dec 2019 11:44:46 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0F0631183E1A; Tue, 17 Dec 2019 16:44:41 +0000 (UTC) Received: from x1w.redhat.com (ovpn-205-147.brq.redhat.com [10.40.205.147]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB86F68894; Tue, 17 Dec 2019 16:44:15 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Cornelia Huck , Zhang Chen , "Michael S. Tsirkin" , Fabien Chouteau , Paul Burton , Peter Maydell , KONRAD Frederic , Aurelien Jarno , Jason Wang , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Corey Minyard , Max Reitz , Li Zhijian , Gerd Hoffmann , Michael Walle , Markus Armbruster , Laurent Vivier , Igor Mitsyanko , Joel Stanley , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bastian Koppelmann , Alberto Garcia , Peter Chubb , "Edgar E. Iglesias" , "Dr. David Alan Gilbert" , Christian Borntraeger , Andrzej Zaborowski , Aleksandar Rikalo , Aleksandar Markovic , Sagar Karandikar , Antony Pavlov , qemu-arm@nongnu.org, Alistair Francis , Kevin Wolf , qemu-s390x@nongnu.org, "Gonglei (Arei)" , Palmer Dabbelt , Samuel Thibault , Amit Shah , qemu-riscv@nongnu.org, Halil Pasic , Thomas Huth Subject: [RFC PATCH 13/14] hw/char/terminal3270: Explicit ignored QEMUChrEvent in IOEventHandler Date: Tue, 17 Dec 2019 17:38:07 +0100 Message-Id: <20191217163808.20068-14-philmd@redhat.com> In-Reply-To: <20191217163808.20068-1-philmd@redhat.com> References: <20191217163808.20068-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: K55-sau0PYefSDfGkLWuzg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TUID: s6t5JxTV9aN+ The Chardev events are listed in the QEMUChrEvent enum. To be able to use this enum in the IOEventHandler typedef, we need to explicit when frontends ignore some events, to silent GCC the following warnings: CC s390x-softmmu/hw/char/terminal3270.o hw/char/terminal3270.c: In function =E2=80=98chr_event=E2=80=99: hw/char/terminal3270.c:156:5: error: enumeration value =E2=80=98CHR_EVENT= _BREAK=E2=80=99 not handled in switch [-Werror=3Dswitch] 156 | switch (event) { | ^~~~~~ hw/char/terminal3270.c:156:5: error: enumeration value =E2=80=98CHR_EVENT= _MUX_IN=E2=80=99 not handled in switch [-Werror=3Dswitch] hw/char/terminal3270.c:156:5: error: enumeration value =E2=80=98CHR_EVENT= _MUX_OUT=E2=80=99 not handled in switch [-Werror=3Dswitch] cc1: all warnings being treated as errors Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Cornelia Huck Cc: Halil Pasic Cc: Christian Borntraeger Cc: "Marc-Andr=C3=A9 Lureau" Cc: Paolo Bonzini Cc: qemu-s390x@nongnu.org --- hw/char/terminal3270.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/char/terminal3270.c b/hw/char/terminal3270.c index 6859c1bcb2..9e59a2d92b 100644 --- a/hw/char/terminal3270.c +++ b/hw/char/terminal3270.c @@ -166,6 +166,9 @@ static void chr_event(void *opaque, int event) sch->curr_status.scsw.dstat =3D SCSW_DSTAT_DEVICE_END; css_conditional_io_interrupt(sch); break; + default: + /* Ignore */ + break; } } =20 --=20 2.21.0