Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1ihGkO-0001ek-Hg for mharc-qemu-trivial@gnu.org; Tue, 17 Dec 2019 12:35:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46102) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihGkL-0001YJ-5c for qemu-trivial@nongnu.org; Tue, 17 Dec 2019 12:34:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihGkK-0008EB-02 for qemu-trivial@nongnu.org; Tue, 17 Dec 2019 12:34:57 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:50958 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihGkJ-0008DY-Sc for qemu-trivial@nongnu.org; Tue, 17 Dec 2019 12:34:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576604095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=024EQHq67Rd7USQOwAS6CFKa3pM0k1rzZuTHwHmHWb8=; b=THpmWLF5SfjTrWZWAgi/Z+DG+xX9u4wLIa9BIGWdaaVI34jx54DvfNKdAoUq4XUQlXkw4n Rlu+oqzd6nGtYGY1xk5dbxH/nVmdKc77T8orSXgO+eYY7CS0HMCkDdAki9wMBG2IV0EQHc WJbYwNN9U6Qy+d/Buy0lOC/ghpBWdJE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-Q2qQ9ZUJNjKv8sUJ0YPWfA-1; Tue, 17 Dec 2019 12:34:54 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB0F18024E9; Tue, 17 Dec 2019 17:34:52 +0000 (UTC) Received: from x1w.redhat.com (ovpn-205-147.brq.redhat.com [10.40.205.147]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 00CC719C4F; Tue, 17 Dec 2019 17:34:49 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Olivier Danet , Mark Cave-Ayland Subject: [PATCH 2/6] hw/display/tcx: Add missing fall through comments Date: Tue, 17 Dec 2019 18:34:21 +0100 Message-Id: <20191217173425.5082-3-philmd@redhat.com> In-Reply-To: <20191217173425.5082-1-philmd@redhat.com> References: <20191217173425.5082-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: Q2qQ9ZUJNjKv8sUJ0YPWfA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Dec 2019 17:34:59 -0000 GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=3D2: hw/display/tcx.c: In function =E2=80=98tcx_dac_writel=E2=80=99: hw/display/tcx.c:453:26: error: this statement may fall through [-Werror= =3Dimplicit-fallthrough=3D] 453 | s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index = autoincrement */ | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/display/tcx.c:454:9: note: here 454 | default: | ^~~~~~~ hw/display/tcx.c: In function =E2=80=98tcx_dac_readl=E2=80=99: hw/display/tcx.c:412:22: error: this statement may fall through [-Werror= =3Dimplicit-fallthrough=3D] 412 | s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index auto= increment */ | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/display/tcx.c:413:5: note: here 413 | default: | ^~~~~~~ cc1: all warnings being treated as errors Add the missing fall through comments. Fixes: 55d7bfe22 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Olivier Danet Cc: Mark Cave-Ayland --- hw/display/tcx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 14e829d3fa..abbeb30284 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -410,6 +410,7 @@ static uint64_t tcx_dac_readl(void *opaque, hwaddr addr= , case 2: val =3D s->b[s->dac_index] << 24; s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index autoincrement= */ + /* fall through */ default: s->dac_state =3D 0; break; @@ -451,6 +452,7 @@ static void tcx_dac_writel(void *opaque, hwaddr addr, u= int64_t val, s->b[index] =3D val >> 24; update_palette_entries(s, index, index + 1); s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index autoincre= ment */ + /* fall through */ default: s->dac_state =3D 0; break; --=20 2.21.0