Received: by 2002:a19:c345:0:0:0:0:0 with SMTP id t66csp1076758lff; Wed, 18 Dec 2019 09:20:49 -0800 (PST) X-Google-Smtp-Source: APXvYqy79uK70Q6YFwxjhlisoo++MKI9iXHGmuIMppkheTWhIvSCNbP3vCk35+r4+16silq1n4wg X-Received: by 2002:a37:8e45:: with SMTP id q66mr3716266qkd.129.1576689649254; Wed, 18 Dec 2019 09:20:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576689649; cv=none; d=google.com; s=arc-20160816; b=XRjKe6WflO1O2ZMr704EnWC+f3+ICDqYFGlQ84i3WOCxPvHdAJ2kHhHwtwsmICsdPQ PAA1m+l7DyC0kSp2L/gO15Tjalf69elnnHCSNY1JZzqWViEnBulU1SWDtwIu74tJwtF8 JgUbGNr8DY4Nu3mVfoOmpl+Rzw5QEOL0638o3CItoof//mG4nw3dAIculcfILGxeHaQD Fhuyj14J7VqhH5jq7BAuajPW+ekbZuSsmOgvOtSFSrHhCmgY++2GzI5Z8MgykaOZIYto opf0i3icZ+HpvQJq4qCW/oeSQhbhapT3C3lIBhAWpNOYZ+tNEgPo0tyHeZMXV+KpAAqq 9p8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=D0xFFDti/vGXy58bqKD5OhN2HcF80Gcn3Awn01okJwQ=; b=r2ihrzq9TdNkjGVjloxYXEmygbL05D0LWxdlNfgxv5YwtAb6gzJGeYMhEdLZLMdJ4I THGYgh9/aoVhLCc6SViW35lmfpaNRlKZvWot9Dw40Q6GBxguCjmeuYvQCBOBqeTbyy7C y+OnO1fR8+6DOADkZPx4j9dDkLsUIHbWz9rAsyoluicIBUOGLIDxjlMVY8Q6GsKpnt44 a9rx/BCYUDc0iJO2TdRbSAIcrgJcGntnvS7X9XdpVNDZTkN/8QYqXkzuLP0+0w4FjWKi 8+iDbxlj+qE3MTzNCPRD3xIdCv7udxT+pw6RmEM/OBFoC+jgfpHXwkgP7h9RlTD+yyQA 9jhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h0pbIGqT; spf=pass (google.com: domain of philmd@redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com. [205.139.110.61]) by mx.google.com with ESMTPS id l8si1382909qtr.283.2019.12.18.09.20.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Dec 2019 09:20:49 -0800 (PST) Received-SPF: pass (google.com: domain of philmd@redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h0pbIGqT; spf=pass (google.com: domain of philmd@redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576689648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D0xFFDti/vGXy58bqKD5OhN2HcF80Gcn3Awn01okJwQ=; b=h0pbIGqTxGsgtmt4ecsrpd1B8OMbBMqREV9c3HlIn36nVrOKEZ3MNxtBGGFr9zROA0jAZr 2/rUtolHRGpoNWhHOVyEku+HeccAj3p2pVOl904ImSyoqUmM8QK8Jl7IWBaScpIRSz4yOr 7roWaRqUHC9543GyW9GUjcDnyc9zpP0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-310-t7rIPLpnM5O-B_mxO9_VMA-1; Wed, 18 Dec 2019 12:20:46 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F06DDC21; Wed, 18 Dec 2019 17:20:42 +0000 (UTC) Received: from x1w.redhat.com (ovpn-116-235.ams2.redhat.com [10.36.116.235]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B7F94100EBA4; Wed, 18 Dec 2019 17:20:15 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Gonglei (Arei)" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Andrzej Zaborowski , Peter Maydell , "Michael S. Tsirkin" , Kevin Wolf , Max Reitz , "Edgar E. Iglesias" , Alistair Francis , Antony Pavlov , Igor Mitsyanko , Fabien Chouteau , KONRAD Frederic , Peter Chubb , Alberto Garcia , Michael Walle , Thomas Huth , Joel Stanley , Cornelia Huck , Halil Pasic , Christian Borntraeger , Laurent Vivier , Amit Shah , Corey Minyard , Paul Burton , Aleksandar Rikalo , Aurelien Jarno , Aleksandar Markovic , Palmer Dabbelt , Sagar Karandikar , Bastian Koppelmann , Gerd Hoffmann , Samuel Thibault , "Dr. David Alan Gilbert" , Markus Armbruster , Zhang Chen , Li Zhijian , Jason Wang , qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org Subject: [PATCH v2 00/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef Date: Wed, 18 Dec 2019 18:19:55 +0100 Message-Id: <20191218172009.8868-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: t7rIPLpnM5O-B_mxO9_VMA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TUID: QhiIXVI+GOio Hi, After this chat on #qemu IRC: 13:20 so what is the difference between a IOReadHandler and IOEve= ntHandler? 13:25 stsquad: one is in-band and the other out-of-band? 13:26 f4bug: ahh yes it seems so - connect/disconnect etc... 13:27 see QEMUChrEvent for IOEventHandler I thought it might be a good opportunity to make the IOEventHandler typedef meaning more obvious, by using the QEMUChrEvent enum. To be able to build I had to explicit all enums ignored in the switch(event) statement by these frontends. Then I used a coccinelle spatch to change the various IOEventHandler. I don't think the last patch can be split, but suggestions are welcome! Regards, Phil. v2: - do blindly ignore all events using a 'default' case. Philippe Mathieu-Daud=C3=A9 (14): hw/ipmi: Remove unnecessary declarations hw/ipmi: Explicit we ignore some QEMUChrEvent in IOEventHandler hw/char/terminal3270: Explicit ignored QEMUChrEvent in IOEventHandler hw/usb/dev-serial: Explicit we ignore few QEMUChrEvent in IOEventHandler hw/usb/redirect: Explicit we ignore few QEMUChrEvent in IOEventHandler ccid-card-passthru: Explicit we ignore QEMUChrEvent in IOEventHandler vhost-user-crypto: Explicit we ignore some QEMUChrEvent in IOEventHandler vhost-user-net: Explicit we ignore few QEMUChrEvent in IOEventHandler vhost-user-blk: Explicit we ignore few QEMUChrEvent in IOEventHandler virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler monitor/qmp: Explicit we ignore few QEMUChrEvent in IOEventHandler monitor/hmp: Explicit we ignore a QEMUChrEvent in IOEventHandler chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler chardev: Use QEMUChrEvent enum in IOEventHandler typedef include/chardev/char-fe.h | 2 +- include/chardev/char-mux.h | 2 +- include/chardev/char.h | 4 ++-- backends/cryptodev-vhost-user.c | 7 ++++++- chardev/char-mux.c | 8 ++++---- chardev/char.c | 9 +++++++-- gdbstub.c | 2 +- hw/arm/pxa2xx.c | 2 +- hw/arm/strongarm.c | 2 +- hw/block/vhost-user-blk.c | 7 ++++++- hw/char/cadence_uart.c | 2 +- hw/char/digic-uart.c | 2 +- hw/char/escc.c | 2 +- hw/char/etraxfs_ser.c | 2 +- hw/char/exynos4210_uart.c | 2 +- hw/char/grlib_apbuart.c | 2 +- hw/char/imx_serial.c | 2 +- hw/char/ipoctal232.c | 2 +- hw/char/lm32_juart.c | 2 +- hw/char/lm32_uart.c | 2 +- hw/char/mcf_uart.c | 2 +- hw/char/milkymist-uart.c | 2 +- hw/char/nrf51_uart.c | 2 +- hw/char/pl011.c | 2 +- hw/char/serial.c | 2 +- hw/char/sh_serial.c | 2 +- hw/char/terminal3270.c | 7 ++++++- hw/char/virtio-console.c | 7 ++++++- hw/char/xilinx_uartlite.c | 2 +- hw/ipmi/ipmi_bmc_extern.c | 12 +++++++----- hw/mips/boston.c | 2 +- hw/mips/mips_malta.c | 2 +- hw/riscv/riscv_htif.c | 2 +- hw/riscv/sifive_uart.c | 2 +- hw/usb/ccid-card-passthru.c | 7 ++++++- hw/usb/dev-serial.c | 6 +++++- hw/usb/redirect.c | 7 ++++++- monitor/hmp.c | 6 +++++- monitor/qmp.c | 7 ++++++- net/filter-mirror.c | 2 +- net/vhost-user.c | 9 +++++++-- qtest.c | 2 +- tests/test-char.c | 6 +++--- tests/vhost-user-test.c | 2 +- 44 files changed, 111 insertions(+), 56 deletions(-) Cc: "Gonglei (Arei)" Cc: "Marc-Andr=C3=A9 Lureau" Cc: Paolo Bonzini Cc: "Alex Benn=C3=A9e" Cc: "Philippe Mathieu-Daud=C3=A9" Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Kevin Wolf Cc: Max Reitz Cc: "Edgar E. Iglesias" Cc: Alistair Francis Cc: Antony Pavlov Cc: Igor Mitsyanko Cc: Fabien Chouteau Cc: KONRAD Frederic Cc: Peter Chubb Cc: Alberto Garcia Cc: Michael Walle Cc: Thomas Huth Cc: Joel Stanley Cc: Cornelia Huck Cc: Halil Pasic Cc: Christian Borntraeger Cc: Laurent Vivier Cc: Amit Shah Cc: Corey Minyard Cc: Paul Burton Cc: Aleksandar Rikalo Cc: Aurelien Jarno Cc: Aleksandar Markovic Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Gerd Hoffmann Cc: Samuel Thibault Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Cc: Zhang Chen Cc: Li Zhijian Cc: Jason Wang Cc: qemu-arm@nongnu.org Cc: qemu-block@nongnu.org Cc: qemu-s390x@nongnu.org Cc: qemu-riscv@nongnu.org --=20 2.21.0