Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C4FFC2D0CE for ; Fri, 27 Dec 2019 18:19:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4E2E20722 for ; Fri, 27 Dec 2019 18:19:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577470741; bh=YakL7Z5jZvtAm2DDPTCZLaiFry5jg5EXIsKrVuUci3M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=n57fNgR7X626m7UutsbCpJbCJoT7WYuo1P2+r7kVmMZ+4jWGHdPFwproVQhvKUcjw lAa7QvPve66zDiQBxL5MmZX1mw+PDU6OBR5ezL++hEh8IzDfFmU4GBTkWU+GCD0GNL MbUphxiNbuS80ECOJx/sLaNgholQcfeBY4csT7jU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727654AbfL0STA (ORCPT ); Fri, 27 Dec 2019 13:19:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:39518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727584AbfL0SO6 (ORCPT ); Fri, 27 Dec 2019 13:14:58 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EB5DD22B48; Fri, 27 Dec 2019 18:14:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577470497; bh=YakL7Z5jZvtAm2DDPTCZLaiFry5jg5EXIsKrVuUci3M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s+WC6FWjTXwbmgaBJfqL3DTn7d1MPoj5598ugd4G5T6F3xwyJhz+xEXnJjgMifBN8 +LyJvwlvN414Ha12JKYzgR4EilXY9cL7OScR17IkBXqdUm3nrxJOT3qNiVoJKmuDFk wK5KiKnsLNH1DAGbEEc6EUS/o7fJ9tRZV4QegEC4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Cristian Birsan , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 17/38] net: usb: lan78xx: Fix suspend/resume PHY register access error Date: Fri, 27 Dec 2019 13:14:14 -0500 Message-Id: <20191227181435.7644-17-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191227181435.7644-1-sashal@kernel.org> References: <20191227181435.7644-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Cristian Birsan [ Upstream commit 20032b63586ac6c28c936dff696981159913a13f ] Lan78xx driver accesses the PHY registers through MDIO bus over USB connection. When performing a suspend/resume, the PHY registers can be accessed before the USB connection is resumed. This will generate an error and will prevent the device to resume correctly. This patch adds the dependency between the MDIO bus and USB device to allow correct handling of suspend/resume. Fixes: ce85e13ad6ef ("lan78xx: Update to use phylib instead of mii_if_info.") Signed-off-by: Cristian Birsan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/lan78xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index a3f9d8f05db4..96258e6a1920 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1763,6 +1763,7 @@ static int lan78xx_mdio_init(struct lan78xx_net *dev) dev->mdiobus->read = lan78xx_mdiobus_read; dev->mdiobus->write = lan78xx_mdiobus_write; dev->mdiobus->name = "lan78xx-mdiobus"; + dev->mdiobus->parent = &dev->udev->dev; snprintf(dev->mdiobus->id, MII_BUS_ID_SIZE, "usb-%03d:%03d", dev->udev->bus->busnum, dev->udev->devnum); -- 2.20.1