From: "Michael S. Tsirkin" Subject: Re: [PATCH v2] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ Date: Tue, 7 Jan 2020 02:06:13 -0500 Message-ID: <20200107020303-mutt-send-email-mst@kernel.org> References: <20200105132120.92370-1-mst@redhat.com> <2d7053b5-295c-4051-a722-7656350bdb74@redhat.com> <20200106074426-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: Jason Wang Cc: Alistair Delva , Willem de Bruijn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, "David S. Miller" List-Id: virtualization@lists.linuxfoundation.org T24gVHVlLCBKYW4gMDcsIDIwMjAgYXQgMTA6Mjk6MDhBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDIwLzEvNiDkuIvljYg4OjU0LCBNaWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6 Cj4gPiBPbiBNb24sIEphbiAwNiwgMjAyMCBhdCAxMDo0NzozNUFNICswODAwLCBKYXNvbiBXYW5n IHdyb3RlOgo+ID4gPiBPbiAyMDIwLzEvNSDkuIvljYg5OjIyLCBNaWNoYWVsIFMuIFRzaXJraW4g d3JvdGU6Cj4gPiA+ID4gVGhlIG9ubHkgd2F5IGZvciBndWVzdCB0byBjb250cm9sIG9mZmxvYWRz IChhcyBlbmFibGVkIGJ5Cj4gPiA+ID4gVklSVElPX05FVF9GX0NUUkxfR1VFU1RfT0ZGTE9BRFMp IGlzIGJ5IHNlbmRpbmcgY29tbWFuZHMKPiA+ID4gPiB0aHJvdWdoIENUUkxfVlEuIFNvIGl0IGRv ZXMgbm90IG1ha2Ugc2Vuc2UgdG8KPiA+ID4gPiBhY2tub3dsZWRnZSBWSVJUSU9fTkVUX0ZfQ1RS TF9HVUVTVF9PRkZMT0FEUyB3aXRob3V0Cj4gPiA+ID4gVklSVElPX05FVF9GX0NUUkxfVlEuCj4g PiA+ID4gCj4gPiA+ID4gVGhlIHNwZWMgZG9lcyBub3Qgb3V0bGF3IGRldmljZXMgd2l0aCBzdWNo IGEgY29uZmlndXJhdGlvbiwgc28gd2UgaGF2ZQo+ID4gPiA+IHRvIHN1cHBvcnQgaXQuIFNpbXBs eSBjbGVhciBWSVJUSU9fTkVUX0ZfQ1RSTF9HVUVTVF9PRkZMT0FEUy4KPiA+ID4gPiBOb3RlIHRo YXQgTGludXggaXMgc3RpbGwgY3Jhc2hpbmcgaWYgaXQgdHJpZXMgdG8KPiA+ID4gPiBjaGFuZ2Ug dGhlIG9mZmxvYWRzIHdoZW4gdGhlcmUncyBubyBjb250cm9sIHZxLgo+ID4gPiA+IFRoYXQgbmVl ZHMgdG8gYmUgZml4ZWQgYnkgYW5vdGhlciBwYXRjaC4KPiA+ID4gPiAKPiA+ID4gPiBSZXBvcnRl ZC1ieTogQWxpc3RhaXIgRGVsdmEgPGFkZWx2YUBnb29nbGUuY29tPgo+ID4gPiA+IFJlcG9ydGVk LWJ5OiBXaWxsZW0gZGUgQnJ1aWpuIDx3aWxsZW1kZWJydWlqbi5rZXJuZWxAZ21haWwuY29tPgo+ ID4gPiA+IEZpeGVzOiAzZjkzNTIyZmZhYjIgKCJ2aXJ0aW8tbmV0OiBzd2l0Y2ggb2ZmIG9mZmxv YWRzIG9uIGRlbWFuZCBpZiBwb3NzaWJsZSBvbiBYRFAgc2V0IikKPiA+ID4gPiBTaWduZWQtb2Zm LWJ5OiBNaWNoYWVsIFMuIFRzaXJraW4gPG1zdEByZWRoYXQuY29tPgo+ID4gPiA+IC0tLQo+ID4g PiA+IAo+ID4gPiA+IFNhbWUgcGF0Y2ggYXMgdjEgYnV0IHVwZGF0ZSBkb2N1bWVudGF0aW9uIHNv IGl0J3MgY2xlYXIgaXQncyBub3QKPiA+ID4gPiBlbm91Z2ggdG8gZml4IHRoZSBjcmFzaC4KPiA+ ID4gPiAKPiA+ID4gPiAgICBkcml2ZXJzL25ldC92aXJ0aW9fbmV0LmMgfCA5ICsrKysrKysrKwo+ ID4gPiA+ICAgIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKykKPiA+ID4gPiAKPiA+ID4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jIGIvZHJpdmVycy9uZXQvdmly dGlvX25ldC5jCj4gPiA+ID4gaW5kZXggNGQ3ZDU0MzRjYzVkLi43Yjg4MDViNDdmMGQgMTAwNjQ0 Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jCj4gPiA+ID4gKysrIGIvZHJp dmVycy9uZXQvdmlydGlvX25ldC5jCj4gPiA+ID4gQEAgLTI5NzEsNiArMjk3MSwxNSBAQCBzdGF0 aWMgaW50IHZpcnRuZXRfdmFsaWRhdGUoc3RydWN0IHZpcnRpb19kZXZpY2UgKnZkZXYpCj4gPiA+ ID4gICAgCWlmICghdmlydG5ldF92YWxpZGF0ZV9mZWF0dXJlcyh2ZGV2KSkKPiA+ID4gPiAgICAJ CXJldHVybiAtRUlOVkFMOwo+ID4gPiA+ICsJLyogVklSVElPX05FVF9GX0NUUkxfR1VFU1RfT0ZG TE9BRFMgZG9lcyBub3Qgd29yayB3aXRob3V0Cj4gPiA+ID4gKwkgKiBWSVJUSU9fTkVUX0ZfQ1RS TF9WUS4gVW5mb3J0dW5hdGVseSBzcGVjIGZvcmdvdCB0bwo+ID4gPiA+ICsJICogc3BlY2lmeSB0 aGF0IFZJUlRJT19ORVRfRl9DVFJMX0dVRVNUX09GRkxPQURTIGRlcGVuZHMKPiA+ID4gPiArCSAq IG9uIFZJUlRJT19ORVRfRl9DVFJMX1ZRIHNvIGRldmljZXMgY2FuIHNldCB0aGUgbGF0ZXIgYnV0 Cj4gPiA+ID4gKwkgKiBub3QgdGhlIGZvcm1lci4KPiA+ID4gPiArCSAqLwo+ID4gPiA+ICsJaWYg KCF2aXJ0aW9faGFzX2ZlYXR1cmUodmRldiwgVklSVElPX05FVF9GX0NUUkxfVlEpKQo+ID4gPiA+ ICsJCQlfX3ZpcnRpb19jbGVhcl9iaXQodmRldiwgVklSVElPX05FVF9GX0NUUkxfR1VFU1RfT0ZG TE9BRFMpOwo+ID4gPiAKPiA+ID4gSWYgaXQncyBqdXN0IGJlY2F1c2UgYSBidWcgb2Ygc3BlYywg c2hvdWxkIHdlIHNpbXBseSBmaXggdGhlIGJ1ZyBhbmQgZmFpbAo+ID4gPiB0aGUgbmVnb3RpYXRp b24gaW4gdmlydG5ldF92YWxpZGF0ZV9mZWF0dXJlKCk/Cj4gPiBPbmUgbWFuJ3MgYnVnIGlzIGFu b3RoZXIgbWFuJ3MgZmVhdHVyZTogYXJndWFibHkgbGVhdmluZyB0aGUgZmVhdHVyZXMKPiA+IGlu ZGVwZW5kZW50IGluIHRoZSBzcGVjIG1pZ2h0IGFsbG93IHJldXNlIG9mIHRoZSBmZWF0dXJlIGJp dCB3aXRob3V0Cj4gPiBicmVha2luZyBndWVzdHMuCj4gPiAKPiA+IEFuZCBldmVuIGlmIHdlIHNh eSBpdCdzIGEgYnVnIHdlIGNhbid0IHNpbXBseSBmaXggdGhlIGJ1ZyBpbiB0aGUKPiA+IHNwZWM6 IGNoYW5naW5nIHRoZSB0ZXh0IGZvciBhIGZ1dHVyZSB2ZXJzaW9uIGRvZXMgbm90IGNoYW5nZSB0 aGUgZmFjdAo+ID4gdGhhdCBkZXZpY2VzIGJlaGF2aW5nIGFjY29yZGluZyB0byB0aGUgc3BlYyBl eGlzdC4KPiA+IAo+ID4gPiBPdGhlcndpc2UgdGhlcmUgd291bGQgYmUgaW5jb25zaXN0ZW5jeSBp biBoYW5kbGluZyBmZWF0dXJlIGRlcGVuZGVuY2llcyBmb3IKPiA+ID4gY3RybCB2cS4KPiA+ID4g Cj4gPiA+IFRoYW5rcwo+ID4gVGhhdCdzIGEgY29zbWV0aWMgcHJvYmxlbSBBVE0uIEl0IG1pZ2h0 IGJlIGEgZ29vZCBpZGVhIHRvIGdlbmVyYWxseQo+ID4gY2hhbmdlIG91ciBoYW5kbGluZyBvZiBk ZXBlbmRlbmNpZXMsIGFuZCBjbGVhciBmZWF0dXJlIGJpdHMgaW5zdGVhZCBvZgo+ID4gZmFpbGlu ZyBwcm9iZSBvbiBhIG1pc21hdGNoLgo+IAo+IAo+IFNvbWV0aGluZyBsaWtlIEkgcHJvcG9zZWQg aW4gdGhlIHBhc3QgPyBbMV0KPiAKPiBbMV0gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvcGF0Y2h3 b3JrL3BhdGNoLzUxOTA3NC8KCgpObyB0aGF0IHN0aWxsIGZhaWxzIHByb2JlLgoKSSBhbSBhc2tp bmcgd2hldGhlciBpdCdzIG1vcmUgZnV0dXJlIHByb29mIHRvIGZhaWwgcHJvYmUKb24gZmVhdHVy ZSBjb21iaW5hdGlvbnMgZGlzYWxsb3dlZCBieSBzcGVjLCBvciB0byBjbGVhciBiaXRzCnRvIGdl dCB0byBhbiBleHBlY3RlZCBjb21iaW5hdGlvbi4KCkluIGFueSBjYXNlLCB3ZSBzaG91bGQgcHJv YmFibHkgZG9jdW1lbnQgaW4gdGhlIHNwZWMgaG93CmRyaXZlcnMgYmVoYXZlIG9uIHN1Y2ggY29t YmluYXRpb25zLgoKCj4gCj4gPiAgIEl0J3Mgd29ydGggdGhpbmtpbmcgIC0gYXQgdGhlIHNwZWMg bGV2ZWwgLQo+ID4gaG93IHdlIGNhbiBiZXN0IG1ha2UgdGhlIGNvbmZpZ3VyYXRpb24gZXh0ZW5z aWJsZS4KPiA+IEJ1dCB0aGF0J3Mgbm90IHNvbWV0aGluZyBzcGVjIHNob3VsZCB3b3JyeSBhYm91 dC4KPiA+IAo+ID4gCj4gPiA+ID4gKwo+ID4gPiA+ICAgIAlpZiAodmlydGlvX2hhc19mZWF0dXJl KHZkZXYsIFZJUlRJT19ORVRfRl9NVFUpKSB7Cj4gPiA+ID4gICAgCQlpbnQgbXR1ID0gdmlydGlv X2NyZWFkMTYodmRldiwKPiA+ID4gPiAgICAJCQkJCSBvZmZzZXRvZihzdHJ1Y3QgdmlydGlvX25l dF9jb25maWcsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgt Zm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4v bGlzdGluZm8vdmlydHVhbGl6YXRpb24=