Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C1BCC33C8C for ; Tue, 7 Jan 2020 16:45:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F2E32080A for ; Tue, 7 Jan 2020 16:45:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fN3VEd2o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F2E32080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H7B7YIrizbcUMUTqp6ksF6Z3Q5bNTMhdLKXNBwRlls8=; b=fN3VEd2oP8xpnoNeRCAytB+5/ f/2hFxxpQLzVLcD30iH6y2++h9yU88j2oFpppoyVDPVJvrSVUmHnIAAXkwsnTARQWF0FI0H7DvAxq lH7/0HPj5TQIyn2v3Ch/sxG40TKCSYPWQIHqEi3Lr/EAVm+PtENR3zpRG9tFGylsBr8CDK/d9d0ya f5Cj+F9YmIN4TaGHUTpXoByLEZFS6pSlvwMM5JKrVDOlQhyXQ83TaLjixm3K0Ak5ayt7GqDJ1Q3Vj +o9Zom20PtaWf4Rx1x+MS9vvKJt/xSupZ/1u+pT1PrFnzgp5Gsoyhar8TELm1F/lOl8YKUpvX8cfe 8mgq8+4mA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iorz1-0007xZ-JK; Tue, 07 Jan 2020 16:45:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioryx-0007wv-V4 for linux-arm-kernel@lists.infradead.org; Tue, 07 Jan 2020 16:45:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E6A85328; Tue, 7 Jan 2020 08:45:26 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6CFB13F703; Tue, 7 Jan 2020 08:45:26 -0800 (PST) Date: Tue, 7 Jan 2020 16:45:24 +0000 From: Mark Brown To: Will Deacon Subject: Re: [PATCH 1/3] arm64: asm: Add new-style position independent function annotations Message-ID: <20200107164524.GF4877@sirena.org.uk> References: <20200106195818.56351-1-broonie@kernel.org> <20200106195818.56351-2-broonie@kernel.org> <20200107144407.GB29001@willie-the-truck> MIME-Version: 1.0 In-Reply-To: <20200107144407.GB29001@willie-the-truck> X-Cookie: Will Rogers never met you. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200107_084528_049829_E2027651 X-CRM114-Status: GOOD ( 11.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============6854936989849748209==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6854936989849748209== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Y1L3PTX8QE8cb2T+" Content-Disposition: inline --Y1L3PTX8QE8cb2T+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 07, 2020 at 02:44:08PM +0000, Will Deacon wrote: > On Mon, Jan 06, 2020 at 07:58:16PM +0000, Mark Brown wrote: > > +#define SYM_FUNC_START_PI_WEAK(x) \ > > + SYM_FUNC_START_ALIAS(__pi_##x) ASM_NL \ > > + SYM_FUNC_START_WEAK(x) > Naming's hard, but I think this is particularly bad because it reads to me > like it's declaring a weak, position-independent symbol, whereas the weak > symbol is actually the version without the "__pi_" prefix. Maybe > SYM_FUNC_START_WEAK_PI() is a tiny bit better? Hrm. I really don't have strong feelings about the name, if you're happy with _WEAK_PI I'm more than happy to go with that. Like you say it's messy. --Y1L3PTX8QE8cb2T+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4UtaQACgkQJNaLcl1U h9AaDwf9F02KVjbont5IrVEn7RZLm6BdYz7UnfD2EVSGKYVx9pCheWUkHAsPSrKy qjkCilx1HFuT+lPC3GSBV2u/1rkxv07xcIbnZ6VR4cohbY5JW94UpV0mgFGruxd1 Pcr79Gvhyp87I7Kn8ZH2u0iWQ19gokzHsbGXJ0V3swNPLAAZQxOUpP2H+WhfZurw 6PL9tRM7WugthHpD1Wkf95q7YN6A3GG3TszzwOiL9HIZ05wPpQNLVkEPP7yJTIiw Cop+/jDLp+wOCzbK2lsmaqdccgpwBj/373LZh+be01luXxgTrIF8d1g9Z08iKi4E Szhtk+UhTyJbQglEwKfU0cXuYTp2IA== =Njck -----END PGP SIGNATURE----- --Y1L3PTX8QE8cb2T+-- --===============6854936989849748209== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6854936989849748209==--