Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F383CC33CAD for ; Mon, 13 Jan 2020 12:20:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB7A32080D for ; Mon, 13 Jan 2020 12:20:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726435AbgAMMUu (ORCPT ); Mon, 13 Jan 2020 07:20:50 -0500 Received: from 8bytes.org ([81.169.241.247]:59738 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbgAMMUu (ORCPT ); Mon, 13 Jan 2020 07:20:50 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id 2F3482C3; Mon, 13 Jan 2020 13:20:48 +0100 (CET) Date: Mon, 13 Jan 2020 13:20:45 +0100 From: Joerg Roedel To: Lu Baolu Cc: Jon Derrick , iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Keith Busch , Christoph Hellwig , David Woodhouse Subject: Re: [RFC 2/5] iommu/vt-d: Unlink device if failed to add to group Message-ID: <20200113122045.GE28359@8bytes.org> References: <1577823863-3303-1-git-send-email-jonathan.derrick@intel.com> <1577823863-3303-3-git-send-email-jonathan.derrick@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sun, Jan 12, 2020 at 09:36:56AM +0800, Lu Baolu wrote: > On 1/1/20 4:24 AM, Jon Derrick wrote: > > If the device fails to be added to the group, make sure to unlink the > > reference before returning. > > > > Signed-off-by: Jon Derrick > > Queued for v5.6. No need to do so, I sent it upstream with the last pile of iommu fixes. Thanks, Joerg