Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 569D0C33CAD for ; Mon, 13 Jan 2020 13:57:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37F882081E for ; Mon, 13 Jan 2020 13:57:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729203AbgAMN5m (ORCPT ); Mon, 13 Jan 2020 08:57:42 -0500 Received: from mga14.intel.com ([192.55.52.115]:56477 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729197AbgAMN5l (ORCPT ); Mon, 13 Jan 2020 08:57:41 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 05:57:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,429,1571727600"; d="scan'208";a="219300610" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga008.fm.intel.com with ESMTP; 13 Jan 2020 05:57:39 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1ir0Dr-0008Ue-Pv; Mon, 13 Jan 2020 15:57:39 +0200 Date: Mon, 13 Jan 2020 15:57:39 +0200 From: Andy Shevchenko To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Denis Ciocca , Leonard Crestez , Lorenzo Bianconi Subject: Re: [PATCH v1] iio: st_gyro: Correct data for LSM9DS0 gyro Message-ID: <20200113135739.GN32742@smile.fi.intel.com> References: <20191217171038.17004-1-andriy.shevchenko@linux.intel.com> <20191223124534.1ed2d23b@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191223124534.1ed2d23b@archlinux> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, Dec 23, 2019 at 12:45:34PM +0000, Jonathan Cameron wrote: > On Tue, 17 Dec 2019 19:10:38 +0200 > Andy Shevchenko wrote: > > > The commit 41c128cb25ce ("iio: st_gyro: Add lsm9ds0-gyro support") > > assumes that gyro in LSM9DS0 is the same as others with 0xd4 WAI ID, > > but datasheet tells slight different story, i.e. the first scale factor > > for the chip is 245 dps, and not 250 dps. > > > > Correct this by introducing a separate settings for LSM9DS0. > > > > Fixes: 41c128cb25ce ("iio: st_gyro: Add lsm9ds0-gyro support") > > Depends-on: 45a4e4220bf4 ("iio: gyro: st_gyro: fix L3GD20H support") > > Cc: Leonard Crestez > > Cc: Lorenzo Bianconi > > Signed-off-by: Andy Shevchenko > Looks good to me. Will just leave it a bit longer to give others > time to check it. > > Give me a shout if I seem to have missed this by about a week into the new > year (to let people get back from holidays etc). Gentle ping. -- With Best Regards, Andy Shevchenko