Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1ir5pp-00048k-0y for mharc-qemu-trivial@gnu.org; Mon, 13 Jan 2020 14:57:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43766) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ir5pm-00047i-8C for qemu-trivial@nongnu.org; Mon, 13 Jan 2020 14:57:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ir5pl-0002TJ-07 for qemu-trivial@nongnu.org; Mon, 13 Jan 2020 14:57:10 -0500 Received: from 19.mo1.mail-out.ovh.net ([178.32.97.206]:57762) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ir5pk-0002Rq-Qa for qemu-trivial@nongnu.org; Mon, 13 Jan 2020 14:57:08 -0500 Received: from player690.ha.ovh.net (unknown [10.108.42.23]) by mo1.mail-out.ovh.net (Postfix) with ESMTP id 8CD5B1A81B7 for ; Mon, 13 Jan 2020 20:57:06 +0100 (CET) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player690.ha.ovh.net (Postfix) with ESMTPSA id 60868E0C300C; Mon, 13 Jan 2020 19:57:00 +0000 (UTC) Date: Mon, 13 Jan 2020 20:56:58 +0100 From: Greg Kurz To: Laurent Vivier Cc: Markus Armbruster , qemu-trivial@nongnu.org, Daniel Henrique Barboza , qemu-devel@nongnu.org Subject: Re: [PATCH v1 12/59] virtfs-proxy-helper.c: remove 'err_out' label in setugid() Message-ID: <20200113205658.11fc5a78@bahia.lan> In-Reply-To: References: <20200106182425.20312-1-danielhb413@gmail.com> <20200106182425.20312-13-danielhb413@gmail.com> <20200107105113.7a443d51@bahia.lan> <87wo9vxu9n.fsf@dusky.pond.sub.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Ovh-Tracer-Id: 14668786937680730584 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrvdejtddguddvlecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkjghfofggtgfgsehtqhertdertdejnecuhfhrohhmpefirhgvghcumfhurhiiuceoghhrohhugheskhgrohgurdhorhhgqeenucfkpheptddrtddrtddrtddpkedvrddvheefrddvtdekrddvgeeknecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrheiledtrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepghhrohhugheskhgrohgurdhorhhgpdhrtghpthhtohepqhgvmhhuqdhtrhhivhhirghlsehnohhnghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 178.32.97.206 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2020 19:57:11 -0000 On Mon, 13 Jan 2020 17:32:31 +0100 Laurent Vivier wrote: > Le 13/01/2020 =C3=A0 16:15, Markus Armbruster a =C3=A9crit=C2=A0: > > Greg Kurz writes: > >=20 > >> On Mon, 6 Jan 2020 15:23:38 -0300 > >> Daniel Henrique Barboza wrote: > >> > >>> 'err_out' can be removed and be replaced by 'return -errno' > >>> in its only instance in the function. > >>> > >>> CC: Greg Kurz > >>> Signed-off-by: Daniel Henrique Barboza > >>> --- > >> > >> I don't really mind, but I confirm this doesn't change behavior. > >> > >> Acked-by: Greg Kurz > >> > >> What's the plan to get this and the other 9p related patches merged ? > >> Through the trivial tree or each subsystem tree ? > >=20 > > I guess qemu-trivial will eventually pick up whatever hasn't been merged > > by maintainers. > >=20 > > [...] > >=20 >=20 > Yes, but the difficulty will be to sort which ones of the 59 patches > series to collect... >=20 Ok, less work for you then. I've applied both 12/59 and 45/59 to 9p-next. I'm planning to send a PR later this week. > Thanks, > Laurent >=20 Cheers, -- Greg