Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECDAAC33CB1 for ; Tue, 14 Jan 2020 12:48:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD9AC24679 for ; Tue, 14 Jan 2020 12:48:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ABQG0htf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="wuNFl2uW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD9AC24679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lE+2bDX3yQ/YkK69FKerB3QofpZxSFJaWHlDQHgB8Aw=; b=ABQG0htf01K2oqNFKkOrH8kD1 bSgQD5f8Ml8m7En9BKRqOl0KRiaTqR9TK0EWKDCxitfNj4mLAHfyiBb/Ad3hK8Q9IMJ3sLy8zLzzx iKI7rVysZ6MVt0Hne52snkavqc1Y3xPcIqtT30sGpr/wtzck6jWpWtaQTZY+C69inlh0ttLz97Wg/ zY3ALyX67TtLXlB6YpCrFM+bN8wgeBlNIUWFkEWd7z7YNrUq2SD3HWfRnKiad51s/wPQ3I6VR679o fDOjQTiicwJOSr2VRa/zzaAM2DZE4MYWSm3/7/uKjvDKVnt+ptDA+XGOKFugiRdGlJ37TV1ggx+f9 lzKg6lPNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irLc0-0006Nc-7e; Tue, 14 Jan 2020 12:48:00 +0000 Received: from heliosphere.sirena.org.uk ([172.104.155.198]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1irLbv-0006N7-9Y for linux-arm-kernel@lists.infradead.org; Tue, 14 Jan 2020 12:47:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4GqE2Lx+k2JThlIRuOZwkWMYwse09vSDmRyJ5N5ET+Y=; b=wuNFl2uWonj2S+6POiWKI5XZR 4NUVe+SH2fp+SGWHoc8NPzlC26hmsxUaZuoImIWN0KxpfX4QevXRtioasxq8Ln8OPxr7lpqmc5BpO ZQnXJIriMGj0VXxVl3aDQSJtgB19WAxawavOQcslxGV9YJnMy5C2sitp3Lj26Yw29NUfQ=; Received: from fw-tnat-cam7.arm.com ([217.140.106.55] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1irLbl-00085w-9b; Tue, 14 Jan 2020 12:47:45 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id F3D37D01965; Tue, 14 Jan 2020 12:47:44 +0000 (GMT) Date: Tue, 14 Jan 2020 12:47:44 +0000 From: Mark Brown To: Takashi Iwai Subject: Re: [PATCH v6] ASoC: Add MediaTek MT6660 Speaker Amp Driver Message-ID: <20200114124744.GT3897@sirena.org.uk> References: <1578968526-13191-1-git-send-email-richtek.jeff.chang@gmail.com> MIME-Version: 1.0 In-Reply-To: X-Cookie: Programming is an unnatural act. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200114_044755_336806_8AEBCD94 X-CRM114-Status: GOOD ( 10.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.com, lgirdwood@gmail.com, Jeff Chang , jeff_chang@richtek.com, matthias.bgg@gmail.com, perex@perex.cz, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============4093615735296767151==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4093615735296767151== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="H88uUF932U8Oj0a6" Content-Disposition: inline --H88uUF932U8Oj0a6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 14, 2020 at 08:44:22AM +0100, Takashi Iwai wrote: > Jeff Chang wrote: > > + if (ret < 0) > > + return ret; > > + reg_data = (u8)ret; > > + if (on_off) > > + reg_data &= (~0x01); > > + else > > + reg_data |= 0x01; > > + return regmap_write(chip->regmap, MT6660_REG_SYSTEM_CTRL, reg_data); > Hm, this looks like an open-code of forced update bits via regmap. > But interestingly there is no corresponding standard helper for that. > Essentially it should be regmap_update_bits_base() with force=1. > Mark? regmap_write_bits(). --H88uUF932U8Oj0a6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4duHAACgkQJNaLcl1U h9Buowf/UyFuv5m4kkR3mDh23iVqGGfCUbs52vx5O6dxillJ76kZ71N7Vg2LPrOq c9B8A7CLb2Ao2pTBr3o1ZONyZiRm1L+5OqyeZZzSnUnuECVsQASRgBpssbrUINHV p5rY6kKIF5dKZGOBjmZWHSNjZ8GgC0BW4Si0P5WH0k7xDHlUsXQHiz47YXWcHQ2d zjenB+X5Kg74bvJ6uh+5KM0kqhQPKSHw33HR7DejUQQMyQFQtNtQVkebVEXnMM6/ sItgCSyukh8F9TTWI6StXdTeJvcveaa1VUAqu68nImD0VL2im79DbbPzoMks/29G GORmKiyK82lF0hw6y6zwOcga3GD/KQ== =xw93 -----END PGP SIGNATURE----- --H88uUF932U8Oj0a6-- --===============4093615735296767151== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4093615735296767151==--