Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 590B7C33CB1 for ; Thu, 16 Jan 2020 13:00:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C33F2073A for ; Thu, 16 Jan 2020 13:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726965AbgAPNAj (ORCPT ); Thu, 16 Jan 2020 08:00:39 -0500 Received: from a.mx.secunet.com ([62.96.220.36]:33798 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbgAPNAj (ORCPT ); Thu, 16 Jan 2020 08:00:39 -0500 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 7E7562006F; Thu, 16 Jan 2020 14:00:37 +0100 (CET) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B6lqxDFMhCzr; Thu, 16 Jan 2020 14:00:37 +0100 (CET) Received: from mail-essen-01.secunet.de (mail-essen-01.secunet.de [10.53.40.204]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 5CEBB2027C; Thu, 16 Jan 2020 14:00:34 +0100 (CET) Received: from gauss2.secunet.de (10.182.7.193) by mail-essen-01.secunet.de (10.53.40.204) with Microsoft SMTP Server id 14.3.439.0; Thu, 16 Jan 2020 14:00:34 +0100 Received: by gauss2.secunet.de (Postfix, from userid 1000) id E562531801A4; Thu, 16 Jan 2020 14:00:33 +0100 (CET) Date: Thu, 16 Jan 2020 14:00:33 +0100 From: Steffen Klassert To: Ulrich Weber CC: Subject: Re: [PATCH v2] xfrm: support output_mark for offload ESP packets Message-ID: <20200116130033.GD23018@gauss3.secunet.de> References: <20200115095358.GQ8621@gauss3.secunet.de> <20200115111128.8671-1-ulrich.weber@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200115111128.8671-1-ulrich.weber@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 15, 2020 at 12:11:29PM +0100, Ulrich Weber wrote: > Commit 9b42c1f179a6 ("xfrm: Extend the output_mark") added output_mark > support but missed ESP offload support. > > xfrm_smark_get() is not called within xfrm_input() for packets coming > from esp4_gro_receive() or esp6_gro_receive(). Therefore call > xfrm_smark_get() directly within these functions. > > Fixes: 9b42c1f179a6 ("xfrm: Extend the output_mark to support input direction and masking.") > Signed-off-by: Ulrich Weber Applied, thanks Ulrich!