Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 775D9C33CAF for ; Thu, 16 Jan 2020 17:26:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41890246BE for ; Thu, 16 Jan 2020 17:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195615; bh=ANUvViKeXBvEPwexAXTC3sSiZj/WPinEAqQ8t19PqOc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qDW1Y9W21d7Oho5cqNXWyt3hjGgYZV2NjkANqpmoDo7Ss5GxQXf2s9vksQ6uTHiuT 26IIUQvUJ/Q4H3Ib29YQovjbi4hqhR8uBB+uFlDauotKxCBddmHulqpcn//HoitHAK 2OgtFaCNGJaR1iz7Hr0fxIeBYsQokaWU93sFl8W8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392340AbgAPR0x (ORCPT ); Thu, 16 Jan 2020 12:26:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:36024 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392321AbgAPR0v (ORCPT ); Thu, 16 Jan 2020 12:26:51 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E7360246BE; Thu, 16 Jan 2020 17:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195610; bh=ANUvViKeXBvEPwexAXTC3sSiZj/WPinEAqQ8t19PqOc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KrVTv2TxoJtxyjgeDn1kd170hWr2gRZ4Tfr9PQ0eixlS9f/1n+Ms241jtZGx2ww8X MwFNEUBRE9graXx7WRIr1AhBnLRpYExSCvWk7lIkYCobu/ragDjxY4SgvqUULiHJYT aQAADU4RmLCkiJZsQ+CaM1jvmKPyruLJ4jN8abLU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sameeh Jubran , Arthur Kiyanovski , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 184/371] net: ena: fix incorrect test of supported hash function Date: Thu, 16 Jan 2020 12:20:56 -0500 Message-Id: <20200116172403.18149-127-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116172403.18149-1-sashal@kernel.org> References: <20200116172403.18149-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Sameeh Jubran [ Upstream commit d3cfe7ddbc3dfbb9b201615b7fef8fd66d1b5fe8 ] ena_com_set_hash_function() tests if a hash function is supported by the device before setting it. The test returns the opposite result than needed. Reverse the condition to return the correct value. Also use the BIT macro instead of inline shift. Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)") Signed-off-by: Arthur Kiyanovski Signed-off-by: Sameeh Jubran Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c index 1a4ffc5d3da4..011b54c541aa 100644 --- a/drivers/net/ethernet/amazon/ena/ena_com.c +++ b/drivers/net/ethernet/amazon/ena/ena_com.c @@ -2002,7 +2002,7 @@ int ena_com_set_hash_function(struct ena_com_dev *ena_dev) if (unlikely(ret)) return ret; - if (get_resp.u.flow_hash_func.supported_func & (1 << rss->hash_func)) { + if (!(get_resp.u.flow_hash_func.supported_func & BIT(rss->hash_func))) { pr_err("Func hash %d isn't supported by device, abort\n", rss->hash_func); return -EOPNOTSUPP; -- 2.20.1